Received-SPF: pass (google.com: domain of linux-kernel+bounces-138553-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <365ac7cd-7a93-4e48-a2b7-9db3a6432ff4@gmail.com>
Date: Wed, 10 Apr 2024 15:00:29 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH net-next v5 4/6] net: gro: add {inner_}network_offset to
 napi_gro_cb
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>, davem@davemloft.net,
 edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-kselftest@vger.kernel.org
References: <20240408141720.98832-1-richardbgobert@gmail.com>
 <20240408141720.98832-5-richardbgobert@gmail.com>
 <6615594ab06f2_23a2b22945@willemb.c.googlers.com.notmuch>
From: Richard Gobert <richardbgobert@gmail.com>
In-Reply-To: <6615594ab06f2_23a2b22945@willemb.c.googlers.com.notmuch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Willem de Bruijn wrote:
> Richard Gobert wrote:
>> This patch adds network_offset and inner_network_offset to napi_gro_cb, and
>> makes sure both are set correctly. In the common path there's only one
>> write (skb_gro_reset_offset).
>>
>> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>
>> ---
>>  include/net/gro.h      | 18 ++++++++++++++++--
>>  net/8021q/vlan_core.c  |  2 ++
>>  net/core/gro.c         |  1 +
>>  net/ethernet/eth.c     |  1 +
>>  net/ipv4/af_inet.c     |  5 +----
>>  net/ipv4/gre_offload.c |  1 +
>>  net/ipv6/ip6_offload.c |  8 ++++----
> 
> Should this cover more protocols, like geneve, ipsec?

Yes, my bad. It should be added to geneve, ipsec and vxlan too. I'll
double-check and post v6.