Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp135093lqj; Wed, 10 Apr 2024 06:26:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVsZjPmyYzEK/bc8tvJj5cLIhrj357HzVhQ4ZwBd5r3cu13AcH7tSMS8OMVuOYueLTZGOqoRSgqLVfXKZ41PhKB3rUMG1toyYm0TVs0ow== X-Google-Smtp-Source: AGHT+IEzFrUqAeHvINL4EJm4je4zLrIgaBmMMZrq9cWtLoLZfihMc0suqgmQFET7XcREg+5vAC3e X-Received: by 2002:a05:622a:389:b0:434:3eb6:65d2 with SMTP id j9-20020a05622a038900b004343eb665d2mr2946795qtx.62.1712755585290; Wed, 10 Apr 2024 06:26:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712755585; cv=pass; d=google.com; s=arc-20160816; b=GIK0S26dFBwrdtEz1twa3lyY9MuInz418hr4aWLT1P6f9+LOBKBsexaGau79YwhXD9 Vjib7uVZGGC1x8aM0i627WXs0ZZ8zULVd2fxxYcT57ucqWeK8m/OS9tyCSr+CXccCZHt ha/CR4fOJj9XCxvNW3xzK5Ro5UcMdyKnnpE1YpqMrtGXQe44/cZ0YD+8KvS15BhHgi6o HR+jvs0IE8VG5qEvy3IvjUR+5Xb8EGlvZ48iokIAjVGNqbnkNBLh8+hBeUh097zppd0E t1KGWJSOcRcmEcLb48V0zC+Kvj1sikQ3vRh9FQNfUhSu9pMDZ6OA20TB7xeAb73Hq8jb mO6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=WNjHEnZYwyX9uPtDNGEk3WQ8G2R5IDZTvmlqm+KjAj0=; fh=pcfEKmBbSKDDlwXZIFWFwDtPpNdVyjMtLBwLhoIgKA0=; b=bmdRaZ6U6U540hUZeV29WxsC88QKLLP21czS+kNuao3GUp7Qq0SGMVtgFv/kL9mMQ+ rNG90Xes9MWaqLqdICH+vLcL3EQ2CP/+expkI0WfQ6SOWXEKZCh4lbT3HcGPiD2mET4B yvXGcmDleGlXhEFOCjx+72Fq7R9Gb1ouGU+Pqhkj4xBnZFwdni9A/Got98c8Yd3HqddV W01DUlnZawBNN0FUMDM2blwXyrvMFUiU4ZB5JAflat8QX5GkNCuLX4WlDAot+IBGK1x7 mGNIrtMYShABAmzdzhYS0jsDQWuhLFia9gD3fCEyq1Kz6TwqpI5FVwoEQaJPweB82ply OXBA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eaok+4aH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-138594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x9-20020a05622a000900b00434ccb9854esi4465712qtw.108.2024.04.10.06.26.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 06:26:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Eaok+4aH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-138594-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138594-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E9D591C22DA2 for ; Wed, 10 Apr 2024 13:26:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0269115FA61; Wed, 10 Apr 2024 13:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Eaok+4aH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F4B15F3F4; Wed, 10 Apr 2024 13:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712755454; cv=none; b=D6HWwzr+MBGLrzWOGAsVpHV6+9UnVn8PUldVKdEqNbjm5dzn4Jl25h6gyq8ciOIYlT20wybaSZggdNs4PmO0fON2Nj82kakUn+fdYmnJd9p06OJeD4sMFCbMI36WFnVAlHd8KjMoHW2YemsJj6c0tMkBQEJSaqZqBrB+7W1eQ+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712755454; c=relaxed/simple; bh=WNjHEnZYwyX9uPtDNGEk3WQ8G2R5IDZTvmlqm+KjAj0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=biQbzswzLB8++EZzG4YT8WmS0mYCSjdH8aL6koahrkRNxdNGxz1eMWQawhxxqH3u0ZObHHU0EypFR5xt4DY3wjhDg5oBqEL4bkIo95x222JEOqbVA4Lb+1asIMHoZeJTiZCZsF7dZXFz9CZXpr1Zuop1T7ELWgaH5f3F4Tua5B8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Eaok+4aH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 937DEC433C7; Wed, 10 Apr 2024 13:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712755453; bh=WNjHEnZYwyX9uPtDNGEk3WQ8G2R5IDZTvmlqm+KjAj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Eaok+4aHCN8wUZsm/y/+J4rMX5hOhpAUn+GHi2BkviKOJj4O6qyRbFsHL0J9wQuCZ 560bix0pr3PEB/C9zVVqMNGYqnP4ZoKcqkWr1p2f+nFAGK8cJ7spiwTQOswhxqvExb Ryx/qOriQaDG4VeHIrGx1qnyG/YSzsFgGkQWmBGyL4UaIR7rjlnyS7aLURSgStOPRY SCieJNwJtB9OYFZ1/2Go6Ge3afIsIHlWx3mV25b1kHMwjmywQ6pefbCWzol/PP87Y/ P/+zK//v1smceidm0Nxh1TQiamFqM5w8nkfg9wUQRY2J0yhk0TLMGTRXQjBMLJpTLZ 4KB0dvQbOnRlg== Date: Wed, 10 Apr 2024 06:24:11 -0700 From: Jakub Kicinski To: Julien Panis Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Sumit Semwal , Christian =?UTF-8?B?S8O2bmln?= , Simon Horman , Andrew Lunn , Ratheesh Kannoth , Naveen Mamindlapalli , danishanwar@ti.com, yuehaibing@huawei.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH net-next v8 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool Message-ID: <20240410062411.1096c881@kernel.org> In-Reply-To: <6f356fec-4384-4367-8812-a18b71156116@baylibre.com> References: <20240223-am65-cpsw-xdp-basic-v8-0-f3421b58da09@baylibre.com> <20240223-am65-cpsw-xdp-basic-v8-2-f3421b58da09@baylibre.com> <20240409173948.66abe6fa@kernel.org> <6f356fec-4384-4367-8812-a18b71156116@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Apr 2024 10:36:16 +0200 Julien Panis wrote: > Also, about mem alloc failures, shouldn't we free 'pool' on kstrdup_const() > error at the beginning of k3_cppi_desc_pool_create_name() ? > I mean, it's not visible in my patch but I now wonder if this was done > properly even before I modify the file. Yes, it uses managed memory (devm_*) but prueth (I didn't check other callers) calls it from .ndo_open. So while not technically a full leak we can accumulate infinite memory by repeatedly failing here :S