Received-SPF: pass (google.com: domain of linux-kernel+bounces-138554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com>
Date: Wed, 10 Apr 2024 15:01:32 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management
Content-Language: en-US
To: Alexander Lobakin <aleksander.lobakin@intel.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Duyck <alexanderduyck@fb.com>, Yunsheng Lin
	<linyunsheng@huawei.com>, Jesper Dangaard Brouer <hawk@kernel.org>, "Ilias
 Apalodimas" <ilias.apalodimas@linaro.org>, Christoph Lameter <cl@linux.com>,
	Vlastimil Babka <vbabka@suse.cz>, Andrew Morton <akpm@linux-foundation.org>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>, <netdev@vger.kernel.org>,
	<intel-wired-lan@lists.osuosl.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
References: <20240404154402.3581254-1-aleksander.lobakin@intel.com>
 <20240404154402.3581254-8-aleksander.lobakin@intel.com>
 <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com>
 <bebf1a1a-e4ec-4ec0-9d01-57a51bcf14ca@intel.com>
 <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com>
 <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWpnZXFJeUhTTXJramNhWXVkN2FCSVJSaGl1VlVrWUdMa2xwY3VlSkVqRitq?=
 =?utf-8?B?NlZobDA4eXR3VHh6cUEyeFBSTnVlY3NCNmZpV1huWDFvNWQ4VE9pZldwYzZQ?=
 =?utf-8?B?bTFoNlI5aisybGo4VEpQYUxZUVFLRC9na3B3aDdjRDVQQThrK0pmQkd1UnlP?=
 =?utf-8?B?TDJlS0JhSHZYM3ZhZXNoNWZFTVR2TlFSM2RNMkJLWmh3Sm9jTWErckRubVYz?=
 =?utf-8?B?WjYyckQ2dnlFVTJnZzV6aG5YSFh5QUNPRlN3SW83U2didWhWUEQ5QVJuY08w?=
 =?utf-8?B?RlExKzdRazN1SHFTelkxelQxUHg3eHJ2N1J2aFlWb1lMQ2pyRXNXMmFiNVRj?=
 =?utf-8?B?aWpqTThuZko4elFJMnhrR2VrVVBZZjNRblVjZ3N6aVdmNndsTjM4WHVZSnBo?=
 =?utf-8?B?eEZWZElZcXhFTzdScTFzWmtuOTBKdzRacEdnVmd2SEJ0TTd4eG96ZEk2U2tq?=
 =?utf-8?B?QmhkdGdGQ1FON010bnFvZ3dBQ2NSNUtzQVRPd1VMQTFrMGR3ZWl5S2ErK2dB?=
 =?utf-8?B?QkFMQzBvMjRaSy85Q1ZtdkJ5U1NGS0xOOG1xMTdMS0JHQndzU3QvSU9xWXN5?=
 =?utf-8?B?TlozekprKzgrbmpLWVdCbEJhRWhaUVluSFVtdHp1RzhEY1RqWVErUENYQkRJ?=
 =?utf-8?B?OHdBYTBDaTRlUWFrTitmeTJXcFdTR2xNUkpXM3daL0NHU29wMHFMZXhlQjlt?=
 =?utf-8?B?aTZvWVZTcElHaklHZ2JpYmR3dnFWZ3JDdVkra05hS1hWalVsclBXby94UnNG?=
 =?utf-8?B?SDdpRU5UL2IzajUrOGpZYkpEdWVhR1FvQlNTRjB0MXh0Z09UbTN2SFNVd3h6?=
 =?utf-8?B?RGh0ZWkrUWFjcndRZnBFTnA5ckdFV3lZMlpISTlhSk9yL3dTYnM3SkRzemE3?=
 =?utf-8?B?NHNQcm10U1RJcUVBTEphTVhuNUkzbFlhZ2NXS0NVZkdNNlN0NzduNWtxK2hS?=
 =?utf-8?B?RkVIQlFrOFlDY0c2U2lzN2ZpaEFFOGcwOEJwMGlUclRoR3BTank2amdTeU1z?=
 =?utf-8?B?a09lOW5LVERoL0llU2xRR1pwME43ZThtNkwvRkROaExwOTE0WXpGVVRmeitt?=
 =?utf-8?B?NlJrY3o3L2FNbTVBSUtaRnFzQzh5bFpFVzJ6UkI0ZE5USnZyM3NDMkt6VWNo?=
 =?utf-8?B?ZWtsWVpBN21FQ0hZYTlXcW96VWYxcklWdU5BUXdjN0RlWGUwTlRYTG5rdzhY?=
 =?utf-8?B?MVEwS3JMRkZiVFg0QnduaFd3dUJFK3pkYm1ZakhnMEVjK2o0VExUVzhXM3h5?=
 =?utf-8?B?NW9CNUhKejBEODErS0V2V3UxY1BiYUhwU1VNVmduWWxWWVY5U2hJaU02anR0?=
 =?utf-8?B?VWFrQUpFcEYweklLc0ptdlNmbjVIOG04L3QyVURaazEzL29ueE9YMndvWkxw?=
 =?utf-8?B?ZXJMM3B1bnBybG1FQjIrb05PUjRia0VHdXpBanRCbUpFWWtsRmtwa3pVRUto?=
 =?utf-8?B?TDR4SGRyYWhOOUR2bmhyYS9CZjY1aVdyNEdYaG42TmM5aFNlNTNNS0xvT0gv?=
 =?utf-8?B?M3FTdHZGVnFiRVBNTSthdWFPMFJhMGxYUnVLdTBCNjFGVllON1hZKzMyRmRX?=
 =?utf-8?B?TEsyaWlGSEc0VVRicUg3ajVIRldCRWdtS2lMVkVYTHZSWEFKK0ZZUFJQM0p2?=
 =?utf-8?B?RUIxRkIwRmovS0lBWUdNYmFCZ2R2dlp1VnpXQ3JwellZcWtQOWc3UTBYV3dW?=
 =?utf-8?B?bFcxWGhRdXhCQlEwSlg1UkpuQ1ZNR2wxZ1djMkhHbDQ2NjAwa2p5YUt3RXNw?=
 =?utf-8?B?bTZzRHBhbFBRaTNPMytOaEg5UEoyditSMzBBTVVmVjUxT21YODVOekxhQ0lO?=
 =?utf-8?B?L2w5djUyYzc5L0pRVFJKRTlPVHV5UGNoYm01UkxoSUY0VVk4bnFoSy91ZmNa?=
 =?utf-8?B?REp6Qm5YSXVXU2JXVDNZbWRKeHdrSTdvSFlIczdKM3Z5eDlhd0llQWVKb2Nl?=
 =?utf-8?B?NlpUSERXWjJuRk0zZ0NEVGRjcWRtRURXcE9teE40MDRtS2I5eUowckZYbWtk?=
 =?utf-8?B?MjJZUXhVNlV5SnNFbmxYVUt4NkU4bFZMUzFNVEwzUDdSVTVrVTdvWTMyc2dP?=
 =?utf-8?B?b1JjZVR4RUhJL2NtcG9GcnZSMTN0OTRTL0gva25TamFuNHF4enRuUXRWV0RO?=
 =?utf-8?B?R3NMb0dpaWFLdGpxMG5VWFBNMlhORlJhc2pBa3AzNUhGZHBvcFNGOXVuQk9x?=
 =?utf-8?Q?OA8ZCDyB2PoAVZXhuiyRXr4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f6716eec-4b81-45c7-26cc-08dc595e5bd4
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:01:38.3302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BMY4kpeJTN2eqze3mcoMWhsVKrFyKyaQszj1ytoFZ0K5sKWpQ1Hh4JVoEsstmbBEnDlZIHONmEg4+eWSWVCQn0hkNW2Iqh9U66Im8hSPMqI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6753
X-OriginatorOrg: intel.com

On 4/10/24 13:49, Alexander Lobakin wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Date: Tue, 9 Apr 2024 12:58:33 +0200
> 
>> On 4/8/24 11:09, Alexander Lobakin wrote:
>>> From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>>> Date: Fri, 5 Apr 2024 12:32:55 +0200
>>>
>>>> On 4/4/24 17:44, Alexander Lobakin wrote:
>>>>> Add a couple intuitive helpers to hide Rx buffer implementation details
>>>
>>> [...]
>>>
>>>>> +struct libeth_fqe {
>>>>> +    struct page        *page;
>>>>> +    u32            offset;
>>>>> +    u32            truesize;
>>>>> +} __aligned_largest;
>>>>> +
>>>>> +/**
>>>>> + * struct libeth_fq - structure representing a buffer queue
>>>>> + * @fp: hotpath part of the structure
>>>>> + * @pp: &page_pool for buffer management
>>>>> + * @fqes: array of Rx buffers
>>>>> + * @truesize: size to allocate per buffer, w/overhead
>>>>> + * @count: number of descriptors/buffers the queue has
>>>>> + * @buf_len: HW-writeable length per each buffer
>>>>> + * @nid: ID of the closest NUMA node with memory
>>>>> + */
>>>>> +struct libeth_fq {
>>>>> +    struct_group_tagged(libeth_fq_fp, fp,
>>>>> +        struct page_pool    *pp;
>>>>> +        struct libeth_fqe    *fqes;
>>>>> +
>>>>> +        u32            truesize;
>>>>> +        u32            count;
>>>>> +    );
>>>>> +
>>>>> +    /* Cold fields */
>>>>> +    u32            buf_len;
>>>>> +    int            nid;
>>>>> +};
>>>>
>>>> [...]
>>>>
>>>> Could you please unpack the meaning of `fq` and `fqe` acronyms here?
>>>
>>> Rx:
>>>
>>> RQ -- receive queue, on which you get Rx DMA complete descriptors
>>> FQ -- fill queue, the one you fill with free buffers
>>>     FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever
>>>
>>> Tx:
>>>
>>> SQ -- send queue, the one you fill with buffers to transmit
>>>     SQE -- send queue element, i.e. "iavf_tx_buffer"
>>> CQ -- completion queue, on which you get Tx DMA complete descriptors
>>>
>>> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk
>>>
>>> I know that rxq, txq, bufq, complq is more common since it's been used
>>> for years, but I like these "new" ones more :>
>>>
>>
>> Thank you, that sounds right. If you happen to sent v10, a bit of code
>> comment with this info would be useful ;)
> 
> The current kdoc in front of each struct and function declaration is not
> enough? :D
> 
> Thanks,
> Olek

I've asked my initial question just after reading it thrice, without
your reply `FQE` was as meaningful as `ABC`