Received-SPF: pass (google.com: domain of linux-kernel+bounces-138607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240328035540.13194-1-raag.jadav@intel.com> <ZhYq_HDwAi4B49Zz@black.fi.intel.com>
In-Reply-To: <ZhYq_HDwAi4B49Zz@black.fi.intel.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 10 Apr 2024 15:31:01 +0200
Message-ID: <CAJZ5v0idPeRmx1oRHoVEZYmGm1D-5SFP9_C0Bu_fiuyf7YiYqQ@mail.gmail.com>
Subject: Re: [PATCH v1] ACPI: bus: allow _UID matching for integer zero
To: Raag Jadav <raag.jadav@intel.com>
Cc: rafael@kernel.org, lenb@kernel.org, robert.moore@intel.com, 
	mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, 
	stanislaw.gruszka@linux.intel.com, linux-acpi@vger.kernel.org, 
	acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 8:00=E2=80=AFAM Raag Jadav <raag.jadav@intel.com> w=
rote:
>
> On Thu, Mar 28, 2024 at 09:25:40AM +0530, Raag Jadav wrote:
> > Commit b2b32a173881 ("ACPI: bus: update acpi_dev_hid_uid_match() to
> > support multiple types") added _UID matching support for both integer
> > and string types, which satisfies NULL @uid2 argument for string types
> > using inversion, but this logic prevents _UID comparision in case the
> > argument is integer 0, which may result in false positives.
> >
> > Fix this using _Generic(), which will allow NULL @uid2 argument for
> > string types as well as _UID matching for all possible integer values.
> >
> > Fixes: b2b32a173881 ("ACPI: bus: update acpi_dev_hid_uid_match() to sup=
port multiple types")
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
>
> Bump.
>
> Anything I can do to move this forward?

Should be there in linux-next already, isn't it?

Maybe I forgot to send an "applied" message.