Received-SPF: pass (google.com: domain of linux-kernel+bounces-138730-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Claudiu.Beznea <claudiu.beznea@tuxon.dev>, "wim@linux-watchdog.org"
	<wim@linux-watchdog.org>, "linux@roeck-us.net" <linux@roeck-us.net>,
	"robh@kernel.org" <robh@kernel.org>, "krzk+dt@kernel.org"
	<krzk+dt@kernel.org>, "conor+dt@kernel.org" <conor+dt@kernel.org>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "geert+renesas@glider.be"
	<geert+renesas@glider.be>, "magnus.damm@gmail.com" <magnus.damm@gmail.com>
CC: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>,
	Claudiu.Beznea <claudiu.beznea@tuxon.dev>, Claudiu Beznea
	<claudiu.beznea.uj@bp.renesas.com>
Subject: RE: [PATCH RESEND v8 03/10] watchdog: rzg2l_wdt: Use
 pm_runtime_resume_and_get()
Thread-Topic: [PATCH RESEND v8 03/10] watchdog: rzg2l_wdt: Use
 pm_runtime_resume_and_get()
Thread-Index: AQHai0zBWu2V0gpeGk2Rf6eyLae+ArFhiuxg
Date: Wed, 10 Apr 2024 14:13:03 +0000
Message-ID:
 <OSAPR01MB158744E15B527496A8ABA4CE86062@OSAPR01MB1587.jpnprd01.prod.outlook.com>
References: <20240410134044.2138310-1-claudiu.beznea.uj@bp.renesas.com>
 <20240410134044.2138310-4-claudiu.beznea.uj@bp.renesas.com>
In-Reply-To: <20240410134044.2138310-4-claudiu.beznea.uj@bp.renesas.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?pTIkHJWP87KQD4JrDRFc+ZYSGKZl31B1Ek9lYJSL20dezIu6j/R3Msa/ydKD?=
 =?us-ascii?Q?TYSRt0q08RaQEXk8PLjetMx5TCxenqNY9Ef178YugwE0MV+YU7HMgUQAW6oL?=
 =?us-ascii?Q?MKVyRo70vyaUhPiWd3Lnq/k7jffsDbnpYv/8qouSzUNUTpklNuT90vXmo9Xf?=
 =?us-ascii?Q?HANuwFC+YXmIzFI8EdmlKPF4pUzu/KO6cbq7cOWG8oR8Pl0C3o9ws7LlVAKi?=
 =?us-ascii?Q?jM7g2uUNrwlMjAkCeWB9LuhSqL9S9YktHbiWy/R7Ybqm+9D9B5xf7lER1kRg?=
 =?us-ascii?Q?+Eexc460BCv9/damc3z072wxfxej2R/7GkvIfMIJ0TbWz8Q1WdTLGweefnvs?=
 =?us-ascii?Q?OCICHagLmlhXFb/FhG1Sf2n4tckAEg2KtgXysqCTyewjQTxdEt1j4jh1K0vL?=
 =?us-ascii?Q?UIh+CsrDcnkWDWmap8g2DFD9ZBrMTn6wTiFoTrwGenPH6TC+OSbqHJvij5cb?=
 =?us-ascii?Q?+3opPFxvoIP7NR3LwWpa+ZHlDFwi4JExEbA50jDrougEE6RJjRR9uQZLu962?=
 =?us-ascii?Q?1giJICz6DkJmJgQ2jjJo30jCULDyJip15hpOqqoZcUMUNGQdsPRDJKGgCzQX?=
 =?us-ascii?Q?nVEtXjvfZHaD6fVE5v1hYZa8e09yV+7Ka5rOAIvf8pwJr6xX0DTDDhF3hS6C?=
 =?us-ascii?Q?SZ261d4B00swMf9mIHAVDdxkciU13jq3REKxS3gwrPbK8Ju6wCJE71FA8Av5?=
 =?us-ascii?Q?frWBjQTlE4p5HW0d2A+Dii0nirxQ59RucBR6jhF7WjWm/XEIlAVc3ailoy/9?=
 =?us-ascii?Q?lkPPc+tKgBJEJSH/bt7Uc7g5Ni6wIkP+rrGtWIOZmSmPCQDt1AzNs1o7SgpN?=
 =?us-ascii?Q?QCfEZBrHGVt4GFu7u+mH+9J6VkARBdSk3+92d5RgK2iezJOEDk/xF+XNqDfS?=
 =?us-ascii?Q?RVHfikcV+3JgmTmaSYQ8OTfONahYFABQhp/LhEtirNyvV2AsG5u98IErsE2g?=
 =?us-ascii?Q?lvtIKZdZZaRsbbpAL6Cq1OW1c3DLBG6BNHYQ6UpS1ovCgxBXXBdMGYun+Wrn?=
 =?us-ascii?Q?rCd/Unf8xIz8DSr+V70G92txIGTvVpPP38eLWYPh8rUV6kExvTUF+P9FBg6x?=
 =?us-ascii?Q?SQXlPs4E5tmaNiCALAx7bl00XcmtKMCBpZfQYyfkLr3NW/pISH7wG0tDs7M8?=
 =?us-ascii?Q?/jYwJG7cLwouHl/8V4YL47j2OHdr4H8gm2ZvbBfr3FALsBJp5I74xSvBkj7f?=
 =?us-ascii?Q?rOtwIjQKg1sLbpPx0ut82HPQe+H5humG6aoUAYd2FLkJqASzcw3eZzv1kObc?=
 =?us-ascii?Q?hmPchX0fbSJ+JhZUtIIuvPqdjRmEmjf6XGvIZjJjIEM/p6OnXeiuL8WHv+hI?=
 =?us-ascii?Q?9pCxSyZs8f22Z/eTmzidSm/9h4Ts1vkO1NL20X9RCZvO+DB5/q6oLCAqczCG?=
 =?us-ascii?Q?agiVsyseyeDXOpBSavlAzYVNL6vPo9mpPSitvh9WTMui041nZj4wFZKAPgBt?=
 =?us-ascii?Q?HxY2WQjNMLMm6oxZeDJtE909BIU6qu2Wd7NywM1CwEmzQp80UF2RYNRKUFWq?=
 =?us-ascii?Q?mOuzRuTnTaaSaOrY8/z3Q+xlK2kigwSykimom8P0btWCE06uhKf2dXxhngQX?=
 =?us-ascii?Q?7g7wPOZ9qYrsCM/MGzN3ZBWSBnIZWRsufp+xidyDfmhzIw6rDBDNmsyLEJ5f?=
 =?us-ascii?Q?/g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB1587.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3320a258-9fc7-47ae-7d14-08dc596855d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2024 14:13:03.1155
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: z4vOBiCEpUS+AqWrBdvfaR+nEA2F/Du41Z+ysLOOW08hiOLEcOqnpSahRa6DiqL3JFTVPNs5jH5tqwWsnipd6y7wWoEE++UFvFaWGYt2kAQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8368

Hi Claudiu,

> -----Original Message-----
> From: Claudiu <claudiu.beznea@tuxon.dev>
> Sent: Wednesday, April 10, 2024 2:41 PM
> Subject: [PATCH RESEND v8 03/10] watchdog: rzg2l_wdt: Use pm_runtime_resu=
me_and_get()
>=20
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>=20
> pm_runtime_get_sync() may return with error. In case it returns with erro=
r
> dev->power.usage_count needs to be decremented.
> dev->pm_runtime_resume_and_get()
> takes care of this. Thus use it.
>=20
> Along with it the rzg2l_wdt_set_timeout() function was updated to propaga=
te the result of
> rzg2l_wdt_start() to its caller.
>=20
> Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for RZ/G2L")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> ---
>=20
> Changes in v8:
> - none
>=20
> Changes in v7:
> - none
>=20
> Changes in v6:
> - none
>=20
> Changes in v5:
> - none
>=20
> Changes in v4:
> - none
>=20
> Changes in v3:
> - none
>=20
> Changes in v2:
> - propagate the return code of rzg2l_wdt_start() to it's callers
>=20
>=20
>  drivers/watchdog/rzg2l_wdt.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c =
index
> 1741f98ca67c..d87d4f50180c 100644
> --- a/drivers/watchdog/rzg2l_wdt.c
> +++ b/drivers/watchdog/rzg2l_wdt.c
> @@ -123,8 +123,11 @@ static void rzg2l_wdt_init_timeout(struct watchdog_d=
evice *wdev)  static int
> rzg2l_wdt_start(struct watchdog_device *wdev)  {
>  	struct rzg2l_wdt_priv *priv =3D watchdog_get_drvdata(wdev);
> +	int ret;
>=20
> -	pm_runtime_get_sync(wdev->parent);
> +	ret =3D pm_runtime_resume_and_get(wdev->parent);

Do we need this change at all? If we have balanced usage then
this won't be a issue. Did any unbalanced usage count popup
during the testing?

Cheers,
Biju

> +	if (ret)
> +		return ret;
>=20
>  	/* Initialize time out */
>  	rzg2l_wdt_init_timeout(wdev);
> @@ -150,6 +153,8 @@ static int rzg2l_wdt_stop(struct watchdog_device *wde=
v)
>=20
>  static int rzg2l_wdt_set_timeout(struct watchdog_device *wdev, unsigned =
int timeout)  {
> +	int ret =3D 0;
> +
>  	wdev->timeout =3D timeout;
>=20
>  	/*
> @@ -159,10 +164,10 @@ static int rzg2l_wdt_set_timeout(struct watchdog_de=
vice *wdev, unsigned int
> time
>  	 */
>  	if (watchdog_active(wdev)) {
>  		rzg2l_wdt_stop(wdev);
> -		rzg2l_wdt_start(wdev);
> +		ret =3D rzg2l_wdt_start(wdev);
>  	}
>=20
> -	return 0;
> +	return ret;
>  }
>=20
>  static int rzg2l_wdt_restart(struct watchdog_device *wdev,
> --
> 2.39.2