Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp173011lqj; Wed, 10 Apr 2024 07:23:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWGGu1iQYbLrbtR9MkyoeTpFW8Nz/DO8ZULxY0uE+82vOGWw2LHZrOGKkWyYaP0zVpUHrYKLU9GI/fg7FLXMFTCpKsV/IYBCk27+LYKaQ== X-Google-Smtp-Source: AGHT+IGGyd01+2rCmqW+dWp3QhFzAyF7RGBn0LjLGg/QNEhObeWNwVHOyQFtccOpvaZ+dK1oqla1 X-Received: by 2002:a17:906:f207:b0:a4e:a2b3:f28d with SMTP id gt7-20020a170906f20700b00a4ea2b3f28dmr4032434ejb.13.1712758998823; Wed, 10 Apr 2024 07:23:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712758998; cv=pass; d=google.com; s=arc-20160816; b=M3K161TaHGI5AplUdgJ/dpy6nz3chRggM7A0IR6Ab62RYAw7UVCuJ6/xPMhNAkoC26 YodnlNaqWM6hM19fRXPBfyEOvQQStQHXwryNR1zIQ9ToemFFXqvGfRscr6KX9tbUhY4E mlSFXxkFe4YgODkhpE9GJccU6sQjXvrJqp+IiIJvAaWGXzYrOuzwwzJQYKm3/rerRyH+ pIPNCi2c/bXkmoVTIYDC31ahtMfQf98go6kiXjwg9d802m0UvVobAXwF+Wq9XsTVzz8f V6ogX8s8NYQxwBMATEFi34G21qpRWlfBGsR2OcwG/I/hyKzyBQuUW1RJ4xymrvxrnH2k inBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=dKudWSPi1Iu7TxLjPm3UxpQgYscfG9LL8/XF7l+GrvA=; fh=pRwuCX5p3t786Iq2avXH0Gp3ImG0DI+yXIJ2GY0U9Bc=; b=JOGNmK6en0yGhwIMM2DWX+iLXl65xo5mLqFilpv/X/CoTIHQ+3fnIig9Zjr1dfM4EM P7MFiePWSegnvDHiUTzXkpDPqKKntQP6LSF53XITAAF77UXWo4l4B5DeEXte0rKJZXQM ll3sZB2VEgZLFSmDQzeDVjk56rZHer8NyAyojTedTyEaVckj1Qdw8ArzVUl6/XFa7IvO 95gQheON8dHCcZvstLtpK+ooze09rtDJCtdp7mGOzkWwKNb54lT8KHB7m9W8P4XwSpQJ 1SOjkwHb8eUoUc/QrEGbh1E/ODjLqvoqyxdzpeIELJ+2p3hWR82C2v3kXpjzMCluaPv7 +Uew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HyGuA7aN; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-138733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id x2-20020a50ba82000000b0056e47321892si4614038ede.374.2024.04.10.07.23.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 07:23:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HyGuA7aN; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-138733-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D46501F30FC0 for ; Wed, 10 Apr 2024 14:17:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1F0815EFB3; Wed, 10 Apr 2024 14:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HyGuA7aN"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4xJUkqSe" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4DE15B12A; Wed, 10 Apr 2024 14:17:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758645; cv=none; b=o2bRg+vCO4BM2cU2JAE4QiOQNulAyFw8c1XqVff0Qu20bdM2hA56ed7pfIC2rD8br/7yTNaRDp7IdtqBiw1jOiH7M/qP1CLZhMJkuxZ2q9NYRpiYQHkfmUskL+OniJ3mwG7ceaEfeEvnJNmVZEXzwkNYEcBj9f9GYAVVqSYeXcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712758645; c=relaxed/simple; bh=iiLXM1gHb2fTzL1lNsUML+2NbfICPf9BJeU7hfbuI6k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=h4z6HxxZPtBzaJB3RZXrPINYq/omKg3Yt0SOavIO4mmjbW9kGWzMHgTJCffhjh39OQh4nfhV6osPG+vFv489qoAYXKjhBwuWvL8hFIfCHu+RWZDU5XTqL6DjmtSckXmKTnohAqwnOYzBV2kKTs87bRvJQ7DaHXhRzcIqYOk9UuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HyGuA7aN; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4xJUkqSe; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1712758642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKudWSPi1Iu7TxLjPm3UxpQgYscfG9LL8/XF7l+GrvA=; b=HyGuA7aNqIHvi+4YBZ2QTOZarh53jTI7l8pcSR0KU9yTM0x6W08XWU/pG67KKgdebK+sIX FwjoVZmyg7O6xEUcvy+MO47yD03ffWBG/lff3YyabpnGJKHwoaheyhwW5IP8k9wEfXefaF mYA/SjvfDZJZ+GKi2/1UsSyopdwaYdea5VK+/9Nr6IAnCdWrbNvA+4ezEc0FS8/ORLA2Ae 0koMqYMoes8RWFR8DrFeCRaZJ93fDlcnb2QUW9W+gXdKfhuFJpYMazyq1XlKIkYJx1OGKA 7GcCYStS4+NRnOcXxE9Xnrn+uwyydjRUi4I/lXtbSu2V6sqJgXLpz/ph/JC4Cw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1712758642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dKudWSPi1Iu7TxLjPm3UxpQgYscfG9LL8/XF7l+GrvA=; b=4xJUkqSelu6YTEbO70Sq2RQ639AxhkKBi91Xaeg78LxGCFeiiaamNADOI/cbtpAQXtMwxa U0veKRge4GuNBODg== To: Bitao Hu , dianders@chromium.org, liusong@linux.alibaba.com, akpm@linux-foundation.org, pmladek@suse.com, kernelfans@gmail.com, deller@gmx.de, npiggin@gmail.com, tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com, jan.kiszka@siemens.com Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, yaoma@linux.alibaba.com Subject: Re: [PATCHv12 1/4] genirq: Provide a snapshot mechanism for interrupt statistics In-Reply-To: References: <20240306125208.71803-1-yaoma@linux.alibaba.com> <20240306125208.71803-2-yaoma@linux.alibaba.com> <87frvu7t85.ffs@tglx> Date: Wed, 10 Apr 2024 16:17:21 +0200 Message-ID: <875xwp480e.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Apr 10 2024 at 14:45, Bitao Hu wrote: > On 2024/4/9 17:58, Thomas Gleixner wrote: > By the way, what do you think of my reason for using printk() instead of > pr_crit()? Should I change this part of the code in v13? Either way is fine. Just put a proper explanation into the change log if you stick with printk(). Thanks, tglx