Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp194205lqj; Wed, 10 Apr 2024 07:57:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXXLk+XfEWU/HfR1wz8l3j8NvTht6tKJMPbVkuJtq94d3zN0MkWmk/ouMT1YE4kIigcJ3x9Q8DFuKnsY4/YVC5oMNgP/AlyXsD91ASzow== X-Google-Smtp-Source: AGHT+IG200pJzKEmfx7tp7cFPBUPmXqfcn0mpyow2YgGAgo7Ps3pMYHK9pD7sUUfIzSRBTOnqJDc X-Received: by 2002:a17:902:9348:b0:1e2:a449:da15 with SMTP id g8-20020a170902934800b001e2a449da15mr2539892plp.15.1712761063546; Wed, 10 Apr 2024 07:57:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712761063; cv=pass; d=google.com; s=arc-20160816; b=q/K8UzCUR0MO2nd5pOBZF3s+RXJIUUDnLMvOX0PXwFGceJtb9b55CnN0Kf8HkB+52w epB9GdUHasJeL3cBDPsCd2DwlPUksjh5+tT7UhQXvN2G1yUR09oKJm4vOnx5KtxZQviC gWzxVMfb13Dxvj3dZv4TLB6yci+Iocxgd9S69OqS3VTst8AuXVg+qTLsaRaSv8Tre+UR H9CvdOrCnwsqbRaZERPye7nWJM0KugswDMteObWK3inmpm+dv1jZEpY6KlJFJ/zFPXQZ wERzTm8LCqZgzYM4Cp5KgNNzxcbhcbjBCPxTdUMsWLb18wWng0g+/gs+CIREqbYQU/NP vmCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=r5hhICO2Tuhg0O6s88ESY/Px6fYRxYIzb84iKPTZhY8=; fh=Tt2O2G2438UVNonlto6sZITjPW1+rCx/q+Tn2Shuo7A=; b=Aa+0yn3l3axT3roT+jg1F6Kb6sA3BROSSVHYam+ucA6NeqVpUmssC1Gq1Q9O7z5WAj YqpAqq412+tOZiz0PfekQGpvu0FJdVHkpix155hcf0wB9abdZ+NZJ3FxEfDTp/abYdok N+mJOwpf/lnGAgglk5nBUanCf8Qla8l3pqAEXFWSX1Tqmhc5ynWmJX+vt/6A1xENon3r HklDdJghy7io1SrY6lvAnjqympscpwYUDNTCxe1sojP12sPkhLhPYAz4tMh+1PtFhB7h e1PNO+9JWW9K1xXAREyXXk3VEfHCCqO7LpSKvt1kHoNAzo8K6vLnCi70djxAQT+ebJTS uTUw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HOHWODub; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-138818-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138818-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id iz5-20020a170902ef8500b001e0a08bbe43si10643340plb.519.2024.04.10.07.57.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 07:57:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138818-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=HOHWODub; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-138818-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138818-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EFAAA28BA42 for ; Wed, 10 Apr 2024 14:56:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C4AD16F0F5; Wed, 10 Apr 2024 14:54:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="HOHWODub"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="nTBZ53J9" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B70716F0E9; Wed, 10 Apr 2024 14:54:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712760878; cv=none; b=KmyZCN+MkgmmENormbkWKc8fnsfLhH4uc+e+DszH0EVZYKwXOgXls0PLZFkBY7/HlCapIivlm2RmVqcjOw7nOoSae+SNDN0pCG0zHexLM+6z5RQ2GsGocKOgsOOszx/+aAOQKEs6P9naromiVBcswHXWHEDbIPbwp6ZYdwq5r/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712760878; c=relaxed/simple; bh=/wL+CsvkkMwaJAgDAaETeMNQO2L94tEPin5keiX6FVI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=A+zyQLZaUP62S5rJTGkVi7m8xyAWdviMbIrhPEyy4xwHIIuoeGRzRnKAScGMZBRNbjTVzBW0MuNOKtLwst4hq+Y9xKrJg/DrqeLFLO4W/VgdOHc7n7HmOS+ImYoPG3/Jri66yfGNJFI0V3LLx1P/DLQ1IsPgXi+4aE9vTZ62n3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=HOHWODub; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=nTBZ53J9; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1712760875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5hhICO2Tuhg0O6s88ESY/Px6fYRxYIzb84iKPTZhY8=; b=HOHWODubEITQQy3ny2ZVhXd6g6NzO7iUD+DlfezqL527zz9sNlX5C4EeXhl3z5dnq953pN Rh3DlWxW3rGzM2jt9GyMvfWsUxUTUvfPGzr0v4aMq+UJ3HZ+POAqv/meIyfFKbsrjuLx0U wKUAJEm6OOCa7lRatmhCcpns/6Oo1GwDqLn5jXuAGi3KOHbElrsHoVVPDhODOJUcL2gP+S 6gv/v669zCCwQk5YYiH/kapgxHFAYF4baJ8Y3m+dVm29oCjATORrrf8PCQ9sFffaIuNpQY lemqb4oDnpP5R+SlroGgZvHeescbyQfQHz90gtChXucecWrKhpWa/hocdHuO/g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1712760875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r5hhICO2Tuhg0O6s88ESY/Px6fYRxYIzb84iKPTZhY8=; b=nTBZ53J9KKuTdWfMwgMlw5koSi2TGSLNr4GdPzI2reBz3Hwi0aVi95nuITyo9TKaI8afA2 Dzkji7/LaDwsV4DA== To: Ingo Molnar , linux-kernel@vger.kernel.org Cc: linux-tip-commits@vger.kernel.org, Mirsad Todorovac , Sean Anderson , x86@kernel.org Subject: Re: [tip: timers/urgent] timekeeping: Use READ/WRITE_ONCE() for tick_do_timer_cpu In-Reply-To: References: <87cyqy7rt3.ffs@tglx> <171269748856.10875.3911619468870441338.tip-bot2@tip-bot2> Date: Wed, 10 Apr 2024 16:54:34 +0200 Message-ID: <87y19l2rpx.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Apr 10 2024 at 10:15, Ingo Molnar wrote: >> @@ -232,7 +233,7 @@ static void tick_setup_device(struct tick_device *td, >> !tick_nohz_full_cpu(cpu)) { >> tick_take_do_timer_from_boot(); >> tick_do_timer_boot_cpu = -1; >> - WARN_ON(tick_do_timer_cpu != cpu); >> + WARN_ON(READ_ON_ONCE(tick_do_timer_cpu) != cpu); > > So there's no such thing as READ_ON_ONCE() - I've amended the commit with > the fix below. Can you hand me a brown paper bag please?