Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp214834lqj; Wed, 10 Apr 2024 08:25:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVePYVym76gJhZ3ZbBgez0EWQGiwWjO8z5o3dmmCjQ4EyqDSxRIvKe32xLtv4g1/5wM0Rufb8noHR5FKNeR3XHbKkU5/Na2laEJytJEXw== X-Google-Smtp-Source: AGHT+IEK4Fbf7a9hUUDq0Gd9ZGU4mb1p1G0yNQRYGiiaCQLHq4K6LQrmAPEOQUYJmlxx/iXPVz/f X-Received: by 2002:a05:6102:5121:b0:47a:2a08:e325 with SMTP id bm33-20020a056102512100b0047a2a08e325mr1296138vsb.21.1712762744572; Wed, 10 Apr 2024 08:25:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712762744; cv=pass; d=google.com; s=arc-20160816; b=DlzQsCtuIc4Q2N7b0hPbDmr205TUiGl3+LpDdgPXeOnzh3rCOWx1fpBZAvHJygs2ED VpAEOrsB1CVTvywMdgEJHyrpGIqfkLig4DL5CNVDXkytahdEDp0DyJjER5vlQs7gxKlY 7/C2+0MzcBTnnmcn8Lo6ZSd7hTrr22RG5liOrnUFnYGgHyHvAp9aANP8QrFIS8OrHuTU mnTE6Bs1QPeyphIHiG8qmhrnEu6knM/qi+DI8oEt0F+U913+DSJW5wQkqHnPOc+IX/Fr PP0L+ckjLKVxW/seVi2DvR2gGJ7d7zlfpzps5poCylKczHZ5p/3WHI9Ym6ORgz+GT3Sb HmfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:to :from:date:dkim-signature; bh=Hk5Tw0Ob3uOx6aPyFJ5KL7i/Hx9JDDO8v0E9b1iK6WI=; fh=NxjT2fCTUx1/Lemmu/W7nE7PJ+5Dt/jUu3DXjzdhGNQ=; b=zaquFOxCLliyZGGjmm7GuaUMsV4KLmiuIRzlAzOs/FOAqub7GHankrmKYQZkqTGFdB +lnYe3sqiU+DBb7dKmiiMvZyQBX2CUwBY7xGVArc23lyiYdZApjksmsbaYVpXi2NPyQo gavhU10NTTWVpsvaUvFOATTO5Q0BhWsAA07fsShQjJ4qY7NYAk2K6oQvDs+KXtO2Z1q+ OXf+arS/MKZhZth5aYBsjS0g7X0j1iL6sUcHIjG3kFAs4Vtv1ZO/ig6HQbhEUv7fOz9/ HrQIWtqoFuib/4eepAdqJlyW98u9+1kB423yIY6I0RSpvX1v68x3tIFsMTBVXP1Re0qU B07A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HXZkqCa5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-138868-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138868-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id i20-20020ab04754000000b007e620799dc1si1436160uac.84.2024.04.10.08.25.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 08:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138868-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HXZkqCa5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-138868-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138868-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 41AB81C21B9E for ; Wed, 10 Apr 2024 15:25:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1696816E87F; Wed, 10 Apr 2024 15:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HXZkqCa5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E2F215EFBF; Wed, 10 Apr 2024 15:25:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712762736; cv=none; b=XMJkNy2RjjmsT4IHN3ZFhVYbdFrfFGP0mYumOM9KqWm+yE5pW8f/rPtCDsEgv6d3ue7PWEKLI6syKCNV3PIrvxsDe4O+IVbJJIuAuEgLl4z9KJeAIooGGZ1lWgs7ArYdL8UbbQJ+OASj4gze5ENHPI0uGpF3QkHkKs0Vo7msB4w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712762736; c=relaxed/simple; bh=LQ/3a9IWIRDOqBxwrTVme9CWku1ILOMQBl7mQRLiAWo=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=suq5eW4F3qM4OOzKzI4p9KGWp58lYcw5CJSXEgqqMUNtr6mvDwT974SzlzeSNgZSpXCAp7o63cvOpH0lubo50Q1tUSa35FF/pGV/pzCDPkssDGi+ILeR/FRGb7GfdxtihOAsUiZvvhheq7wLvwefyBhsXH51gY0N5c9jmd7NVpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HXZkqCa5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 575CDC433F1; Wed, 10 Apr 2024 15:25:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712762735; bh=LQ/3a9IWIRDOqBxwrTVme9CWku1ILOMQBl7mQRLiAWo=; h=Date:From:To:Subject:References:In-Reply-To:From; b=HXZkqCa5C0cWESyOvDvsdJ7721ywkhj/ZHDFrvD0IPpt97pujLFOxypMEA9gROI/E 2f60JkFVXQSBcP62ktSdW5Sp+dbS4S0iOCvLYqDeAIPwmVaEKjjIcRuNpBELHUXSp/ 4xe+yjxKl08Sp5q9dpHF4yKlqjz+YASdD6MPd/ZYSBkfk2eJfq+GTld7hZbIPJvrsZ /gcSdMLe0UdDc6O0EXmeEAO89UeSGXMOBdyx2yqqqPPnzUpGry+b2wf4PB7zAcLH3+ 3Bfkk2kgYJMrp39G0/2VtCdQe3R3wDp0gzMuxXGEGxNG8VCEY/8SdRUXL3ekVPbeVg YZ11CgOGXfeDQ== Date: Wed, 10 Apr 2024 17:25:31 +0200 From: Andi Shyti To: Wolfram Sang , linux-i2c@vger.kernel.org, Jochen Friedrich , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/64] i2c: cpm: reword according to newest specification Message-ID: <26y3smrxv3q56peuqatospr3q6annxvdmleyhykyrjrovne6mu@yg44mmr7aaqp> References: <20240322132619.6389-1-wsa+renesas@sang-engineering.com> <20240322132619.6389-15-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > > > out_8(&cpm->i2c_reg->i2mod, 0x00); > > > - out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Master mode */ > > > + out_8(&cpm->i2c_reg->i2com, I2COM_MASTER); /* Host mode */ > > > > I2COM_MASTER might be coming from the datasheet. > > Maybe we can just drop the comment? The value we write is pretty > self-explaining. indeed. Andi