Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp218176lqj; Wed, 10 Apr 2024 08:31:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWC9AvTOAICYChmOI++zwHvgajX1Tc11w+5iYSeUgMAwsJEPV73nWaiw8CNkALTSgo/Ai0+AFmUDf4S+D6/nUyL/Kku82ImmH9w9IB7Hw== X-Google-Smtp-Source: AGHT+IEHWk62uNDij/4Qga5CNZHcnrJNCnp+qkoTdbgSM2obwlXlAZ/GvurE/wDWC++07jnWnsyR X-Received: by 2002:a05:6214:b6c:b0:696:79f1:c637 with SMTP id ey12-20020a0562140b6c00b0069679f1c637mr5340190qvb.25.1712763069665; Wed, 10 Apr 2024 08:31:09 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712763069; cv=pass; d=google.com; s=arc-20160816; b=dLPOK6H2ZA+rUe8FHEtWQa8UVGWy2/htgJrTkPBimb9qoVFkjG4yYn0eizH9QBuEuA yJaY7JJAmBPauCmSIqM1pFZ1riRmPMaitgxcuYm+y6sOWe718UbNWUDSMr+mHCXjg0o1 wHhnGxdRRKpLn/ueluvAMpd+Am4bNPk5oDKQlHBnM5nYcbpcsS9Mw7O7ZEfz+EsD0LVg jTYGEDhmx4EiBPBeByNJRXDNv0jFwNZxVis1Nu4e9dKsxQ6DNoNbx3mfbtR/nQifXzWm sut6j3nw6b/5zmpjQdHjeIoL54DLL07/TXmEy+DuvGWeYaYhYEmbXJGrHpWGudtsT+ay dXgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:references:in-reply-to :message-id:cc:to:from:date:dkim-signature; bh=xU1hy2U0mJLbOe7yjnAS91sF71BnTGdYJcXm1GozIKs=; fh=UubhtqRIWLLHaFTb7pDRy7K1yB/WDR6soAD+udDWLF0=; b=W5sTF3El8CkGvY8GHxmWmvNdlRocZa/ol00vGes+YZzcNi+ha04d4r9Wfp0ChccZPh BC1luLHqPLlxhOztqHvTqbv9AuCRVMOxVeRzO9lwGKHDwTAFDl2yl90Dt6LYmCxfHikA ioedWQfKnrShpOz1GG6nDtmChSEwDB5wx4vA8rYs/udGmnSjz6hXkYLdwPmJPCULAC05 AUa6SITKk53+Phmj2GrHoRZSzt/eszq6Bd1qiRmW9SgTK5wCxtwi3Vw0Mau9RUg8F8d4 C8bZYuPiN/w0JaA2XdCzvptP3Bco5PMfhTtrHyvbJRkYNnCZWaoWENe8LM9abGUZKfvd CPyg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eNyu4NcM; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-138878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138878-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id fe4-20020a0562140b8400b00695d4a4fbfasi12675189qvb.53.2024.04.10.08.31.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 08:31:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-138878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=eNyu4NcM; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-138878-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-138878-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 60CD71C21B29 for ; Wed, 10 Apr 2024 15:31:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 547DD16EC1B; Wed, 10 Apr 2024 15:30:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eNyu4NcM" Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C86415ADB0; Wed, 10 Apr 2024 15:30:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712763058; cv=none; b=EwdvePX0uAJj3J3orchARYHCp1JbDITB4kHnPaskUzdK8Zm+mZhH6JYQXWSUzosaVEAhkLXs+4Zj5mdqnWKxNCvgC8NaeYEArC6kBVAHkflTYrLO2ptjHDx0Rdztp1WhZj8Pvq/PsM8RkYRzfSYop/mXm21z7Rh11HgW5/lDSho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712763058; c=relaxed/simple; bh=OmeHXoy2ncpoQhQGyEMX/xcVd8Rz4jLJzk0iOK1XF+w=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=isr25YgUk+Qw/CvrBkMT4rTRvop3twJsy99nL0y5Ohs+BLUDH2Q8riNR/Uj3S3Oruxq5DyZmf1nMv9wQyq4ax6qgt0xSeM2YwHW9/Z7u412bGeXaXTO92cw7IGHR7CgHeGa19bNDJWxpeXucC9LwnA6NYj5LEmiTTO67drz7a9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eNyu4NcM; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-78d70890182so147319085a.0; Wed, 10 Apr 2024 08:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712763056; x=1713367856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xU1hy2U0mJLbOe7yjnAS91sF71BnTGdYJcXm1GozIKs=; b=eNyu4NcMjqU3NSgFAwmiRI+fIsLMWLpcHQ8/HOhC5ez5ZHCFXblARQmb9ADbtwM/V4 utXpQsiyjg3khSonupaCbaiXXyVfT0xBs+7nyYBY8h+xO+DB5HV6UAVERYl1FrQNpfms MMK06NHSH39I8CI242QoK+nxa0yHzspLwHy2sqLI2oFG6oXiuaRYpKkJzXxbRPLbYXyT IWik5Jt0RnfJBySaC8mK/NK8J+F0XBKO22VltC1TEVLAUNSuyxp1hxkIr3ikWnW/n07Q o6f1slrMTuxqwrJJ3s/W9uhF2rhHAASdq3/1OYNuCxE9gzqEjI6/TMET3N9r+cRoXOOI 9bVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712763056; x=1713367856; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xU1hy2U0mJLbOe7yjnAS91sF71BnTGdYJcXm1GozIKs=; b=XgNj3NhTsLVLsNOiK+93mLUU3ruI+qq7qw+s/nVXoWD13EsUFGgir5f03UohT5QJSC IQEw6gqg/YjgA4wBD2Rfy0cuDVNDipKs4cCnKr9PEpjq3IrI13JXAAEHWP6mp/4SWrVW ZGQ7RyCzQrYrsdQsASqPB7SOFQt/bvGJF4zdvfwoSKy2UUnnbPC+mNIpagmBy2M9AVAv dxhPeACu/VGevz4qut/+9HwCCIpFL+6xgzeTmdoNI2E0YKUMLiRK2iH29HxoiqBjiObA 7YtTn6Vf8ghYfmzvji5RHdE9k/O1YgGdBWd8FksbdvGgiTi1BvFT1eyUr5KUsYpOOD2b Y+7w== X-Forwarded-Encrypted: i=1; AJvYcCXyP9113+bTaSlJqd7uxzuDv/dwgRfT74ZhpTYNkT1e+BRoJ4Pfr5Zy5FAFNq0zNHzdzdQI3SV7EBV4H9Zat06kmJTkhUey+cbm6KgTjDFoT29vdUgPQmQeB9xnH6kH3zKhRl1E6z796f8mdK48DI9KGHMeNJc65rJO X-Gm-Message-State: AOJu0YyNWzieJfS0Uo/J9aSV2GgThDgai75XZAv/64jwz/jFaQETxKWX V471waYkNrByXbJk/T+TfLsYH0ZZWYS/+35F61fc2zu0PCZPk0JhhKXZOdCO X-Received: by 2002:a05:620a:e8b:b0:78b:d75c:f9f5 with SMTP id w11-20020a05620a0e8b00b0078bd75cf9f5mr4407896qkm.38.1712763055865; Wed, 10 Apr 2024 08:30:55 -0700 (PDT) Received: from localhost (73.84.86.34.bc.googleusercontent.com. [34.86.84.73]) by smtp.gmail.com with ESMTPSA id d7-20020a05620a158700b0078d5f7b9a2dsm3952197qkk.15.2024.04.10.08.30.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 08:30:55 -0700 (PDT) Date: Wed, 10 Apr 2024 11:30:55 -0400 From: Willem de Bruijn To: Abhishek Chauhan , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Willem de Bruijn , Martin KaFai Lau , Martin KaFai Lau , Daniel Borkmann , bpf Cc: kernel@quicinc.com Message-ID: <6616b0af63eed_2a98a52947e@willemb.c.googlers.com.notmuch> In-Reply-To: <20240409210547.3815806-2-quic_abchauha@quicinc.com> References: <20240409210547.3815806-1-quic_abchauha@quicinc.com> <20240409210547.3815806-2-quic_abchauha@quicinc.com> Subject: Re: [RFC PATCH bpf-next v1 1/3] net: Rename mono_delivery_time to tstamp_type for scalabilty Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Abhishek Chauhan wrote: > mono_delivery_time was added to check if skb->tstamp has delivery > time in mono clock base (i.e. EDT) otherwise skb->tstamp has > timestamp in ingress and delivery_time at egress. > > Renaming the bitfield from mono_delivery_time to tstamp_type is for > extensibilty for other timestamps such as userspace timestamp > (i.e. SO_TXTIME) set via sock opts. > > Bridge driver today has no support to forward the userspace timestamp > packets and ends up resetting the timestamp. ETF qdisc checks the > packet coming from userspace and encounters to be 0 thereby dropping > time sensitive packets. These changes will allow userspace timestamps > packets to be forwarded from the bridge to NIC drivers. > > In future tstamp_type:1 can be extended to support userspace timestamp > by increasing the bitfield. > > Link: https://lore.kernel.org/netdev/bc037db4-58bb-4861-ac31-a361a93841d3@linux.dev/ > Signed-off-by: Abhishek Chauhan > --- > include/linux/skbuff.h | 18 +++++++++--------- > include/net/inet_frag.h | 4 ++-- > net/bridge/netfilter/nf_conntrack_bridge.c | 6 +++--- > net/core/dev.c | 2 +- > net/core/filter.c | 8 ++++---- > net/ipv4/inet_fragment.c | 2 +- > net/ipv4/ip_fragment.c | 2 +- > net/ipv4/ip_output.c | 8 ++++---- > net/ipv6/ip6_output.c | 6 +++--- > net/ipv6/netfilter.c | 6 +++--- > net/ipv6/netfilter/nf_conntrack_reasm.c | 2 +- > net/ipv6/reassembly.c | 2 +- > net/sched/act_bpf.c | 4 ++-- > net/sched/cls_bpf.c | 4 ++-- > 14 files changed, 37 insertions(+), 37 deletions(-) Since the next patch against touches many of the same lines, probably can just squash the two.