Received-SPF: pass (google.com: domain of linux-kernel+bounces-138865-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240301203023.2197451-1-jsavitz@redhat.com> <87jzmduiva.fsf@kernel.org>
 <CAL1p7m5BoxFDeK0MryQCmTDCeBLN3rMLRGx3cHa6teS02wsgZw@mail.gmail.com> <CAL1p7m5VHGL+-st7zgGA9LPft6DND=qz0ifiD_ki1hLvfRv=7Q@mail.gmail.com>
In-Reply-To: <CAL1p7m5VHGL+-st7zgGA9LPft6DND=qz0ifiD_ki1hLvfRv=7Q@mail.gmail.com>
From: Joel Savitz <jsavitz@redhat.com>
Date: Wed, 10 Apr 2024 11:22:45 -0400
Message-ID: <CAL1p7m7f=b_qJrU8qea2n1+-1KzEVLMOpY9ov5fH2ZZxGrDK5A@mail.gmail.com>
Subject: Re: [PATCH] powerpc: align memory_limit to 16MB in early_parse_mem
To: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: linux-kernel@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>, 
	Nicholas Piggin <npiggin@gmail.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, 
	"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>, Benjamin Gray <bgray@linux.ibm.com>, 
	Paul Mackerras <paulus@ozlabs.org>, linuxppc-dev@lists.ozlabs.org, 
	Gonzalo Siero <gsierohu@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 1, 2024 at 10:17=E2=80=AFAM Joel Savitz <jsavitz@redhat.com> wr=
ote:
>
> On Tue, Mar 26, 2024 at 12:45=E2=80=AFAM Joel Savitz <jsavitz@redhat.com>=
 wrote:
> >
> > On Fri, Mar 8, 2024 at 5:18=E2=80=AFAM Aneesh Kumar K.V <aneesh.kumar@k=
ernel.org> wrote:
> > >
> > > Joel Savitz <jsavitz@redhat.com> writes:
> > >
> > > > On 64-bit powerpc, usage of a non-16MB-aligned value for the mem=3D=
 kernel
> > > > cmdline parameter results in a system hang at boot.
> > > >
> > > > For example, using 'mem=3D4198400K' will always reproduce this issu=
e.
> > > >
> > > > This patch fixes the problem by aligning any argument to mem=3D to =
16MB
> > > > corresponding with the large page size on powerpc.
> > > >
> > > > Fixes: 2babf5c2ec2f ("[PATCH] powerpc: Unify mem=3D handling")
> > > > Co-developed-by: Gonzalo Siero <gsierohu@redhat.com>
> > > > Signed-off-by: Gonzalo Siero <gsierohu@redhat.com>
> > > > Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> > > > ---
> > > >  arch/powerpc/kernel/prom.c | 6 +++++-
> > > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.=
c
> > > > index 0b5878c3125b..8cd3e2445d8a 100644
> > > > --- a/arch/powerpc/kernel/prom.c
> > > > +++ b/arch/powerpc/kernel/prom.c
> > > > @@ -82,8 +82,12 @@ static int __init early_parse_mem(char *p)
> > > >  {
> > > >       if (!p)
> > > >               return 1;
> > > > -
> > > > +#ifdef CONFIG_PPC64
> > > > +     /* Align to 16 MB =3D=3D size of ppc64 large page */
> > > > +     memory_limit =3D ALIGN(memparse(p, &p), 0x1000000);
> > > > +#else
> > > >       memory_limit =3D PAGE_ALIGN(memparse(p, &p));
> > > > +#endif
> > > >       DBG("memory limit =3D 0x%llx\n", memory_limit);
> > > >
> > > >       return 0;
> > > > --
> > > > 2.43.0
> > >
> > > Can you try this change?
> > >
> > > commit 5555bc55e1aa71f545cff31e1eccdb4a2e39df84
> > > Author: Aneesh Kumar K.V (IBM) <aneesh.kumar@kernel.org>
> > > Date:   Fri Mar 8 14:45:26 2024 +0530
> > >
> > >     powerpc/mm: Align memory_limit value specified using mem=3D kerne=
l parameter
> > >
> > >     The value specified for the memory limit is used to set a restric=
tion on
> > >     memory usage. It is important to ensure that this restriction is =
within
> > >     the linear map kernel address space range. The hash page table
> > >     translation uses a 16MB page size to map the kernel linear map ad=
dress
> > >     space. htab_bolt_mapping() function aligns down the size of the r=
ange
> > >     while mapping kernel linear address space. Since the memblock lim=
it is
> > >     enforced very early during boot, before we can detect the type of=
 memory
> > >     translation (radix vs hash), we align the memory limit value spec=
ified
> > >     as a kernel parameter to 16MB. This alignment value will work for=
 both
> > >     hash and radix translations.
> > >
> > >     Signed-off-by: Aneesh Kumar K.V (IBM) <aneesh.kumar@kernel.org>
> > >
> > > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> > > index 0b5878c3125b..9bd965d35352 100644
> > > --- a/arch/powerpc/kernel/prom.c
> > > +++ b/arch/powerpc/kernel/prom.c
> > > @@ -824,8 +824,11 @@ void __init early_init_devtree(void *params)
> > >                 reserve_crashkernel();
> > >         early_reserve_mem();
> > >
> > > -       /* Ensure that total memory size is page-aligned. */
> > > -       limit =3D ALIGN(memory_limit ?: memblock_phys_mem_size(), PAG=
E_SIZE);
> > > +       if (memory_limit > memblock_phys_mem_size())
> > > +               memory_limit =3D 0;
> > > +
> > > +       /* Align down to 16 MB which is large page size with hash pag=
e translation */
> > > +       limit =3D ALIGN_DOWN(memory_limit ?: memblock_phys_mem_size()=
, SZ_16M);
> > >         memblock_enforce_memory_limit(limit);
> > >
> > >  #if defined(CONFIG_PPC_BOOK3S_64) && defined(CONFIG_PPC_4K_PAGES)
> > > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/pr=
om_init.c
> > > index e67effdba85c..d6410549e141 100644
> > > --- a/arch/powerpc/kernel/prom_init.c
> > > +++ b/arch/powerpc/kernel/prom_init.c
> > > @@ -817,8 +817,8 @@ static void __init early_cmdline_parse(void)
> > >                 opt +=3D 4;
> > >                 prom_memory_limit =3D prom_memparse(opt, (const char =
**)&opt);
> > >  #ifdef CONFIG_PPC64
> > > -               /* Align to 16 MB =3D=3D size of ppc64 large page */
> > > -               prom_memory_limit =3D ALIGN(prom_memory_limit, 0x1000=
000);
> > > +               /* Align down to 16 MB which is large page size with =
hash page translation */
> > > +               prom_memory_limit =3D ALIGN_DOWN(prom_memory_limit, S=
Z_16M);
> > >  #endif
> > >         }
> > >
> > >
> >
> > Sorry for the delayed reply. I just tested this patch and it fixes the
> > bug for me.
>
> Hi,
>
> Just a quick follow up on this.
>
> The above patch fixed the bug for me.
>
> How do we want to proceed?
>
> Best,
> Joel Savitz

Hi,

I haven't heard anything on this thread so I'm just sending a quick follow =
up.

Do we want to merge this

Best,
Joel Savitz