Received-SPF: pass (google.com: domain of linux-kernel+bounces-138963-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240410103458.813656-1-james.clark@arm.com>
In-Reply-To: <20240410103458.813656-1-james.clark@arm.com>
From: Ian Rogers <irogers@google.com>
Date: Wed, 10 Apr 2024 09:17:04 -0700
Message-ID: <CAP-5=fVgf3cOgbV1KGGLd5gykxT+BzuX1=XUsp+2BNUahGn6QQ@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] perf test: "object code reading" test fixes
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, namhyung@kernel.org, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, "Liang, Kan" <kan.liang@linux.intel.com>, 
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>, Spoorthy S <spoorts2@in.ibm.com>, 
	Leo Yan <leo.yan@linux.dev>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 3:35=E2=80=AFAM James Clark <james.clark@arm.com> w=
rote:
>
> A few fixes around the object code reading test. The first patch
> appears to be unrelated, but in this case the data symbol test is
> broken on Arm N1 by the second commit.
>
> Changes since V1:
>   * Put data symbol test fix first so that bisecting still works on N1
>   * Instead of skipping "test data symbol" on N1, add some noise into
>     the loop.
>   * Add a commit to replace the only usage of lscpu in the tests with
>     uname
>
> James Clark (4):
>   perf tests: Make "test data symbol" more robust on Neoverse N1
>   perf tests: Apply attributes to all events in object code reading test
>   perf map: Remove kernel map before updating start and end addresses
>   perf tests: Remove dependency on lscpu

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

>  tools/perf/tests/code-reading.c                 | 10 +++++-----
>  tools/perf/tests/shell/test_arm_callgraph_fp.sh |  4 +++-
>  tools/perf/tests/workloads/datasym.c            | 16 ++++++++++++++++
>  tools/perf/util/machine.c                       |  2 +-
>  4 files changed, 25 insertions(+), 7 deletions(-)
>
> --
> 2.34.1
>