Received-SPF: pass (google.com: domain of linux-kernel+bounces-138985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 10 Apr 2024 12:35:42 -0400
From: Frank Li <Frank.li@nxp.com>
To: Will Deacon <will@kernel.org>
Cc: Xu Yang <xu.yang_2@nxp.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"john.g.garry@oracle.com" <john.g.garry@oracle.com>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"irogers@google.com" <irogers@google.com>,
	"mike.leach@linaro.org" <mike.leach@linaro.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"acme@kernel.org" <acme@kernel.org>,
	"alexander.shishkin@linux.intel.com" <alexander.shishkin@linux.intel.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [EXT] Re: [PATCH v8 3/8] perf: imx_perf: let the driver manage
 the counter usage rather the user
Message-ID: <Zha/3tsYQMBI652O@lizhi-Precision-Tower-5810>
References: <20240322063930.749126-1-xu.yang_2@nxp.com>
 <20240322063930.749126-3-xu.yang_2@nxp.com>
 <20240409152627.GA23621@willie-the-truck>
 <DU2PR04MB882209413AB62531713166B38C062@DU2PR04MB8822.eurprd04.prod.outlook.com>
 <20240410154546.GA25225@willie-the-truck>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240410154546.GA25225@willie-the-truck>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kaz5WuQ6C0wcmX0BR1iuc5kwpxUxKWkeQ3VEpDg6S24rqxyufcjvnZUAO5XY?=
 =?us-ascii?Q?t8JW8onf+NiSst2yI13gc6bk1mOptIVn34r/4AbLQNbc+EbXJxRyVga41GAk?=
 =?us-ascii?Q?B3AaV0O8nl3TQqCO8JPwhf1/TWG1IxyC6a88EOB+z/vD4SefPb7ecMycyMiE?=
 =?us-ascii?Q?LRHeETFQ0Yjig7MYo9LxWV43SWMMoooIvs7bxgBKKrunZGRr24GVem6F8JOm?=
 =?us-ascii?Q?XspmdrAOKbX63PDTgZHo1SEmP+Gwf5WQa5ZGsxUviCeltrwpYF9qFJSpAMhE?=
 =?us-ascii?Q?FN6FAGhPAnFUyPnvv2aP5OeeJhqX2wJLSATPp8C6RhRzrKECPptP9e9k3mz6?=
 =?us-ascii?Q?kG1xOG9fN04JZs1FwPSLGx4int1zKtFYJ3xDduw2ZeBE+cJc6+gs0GjyJaTY?=
 =?us-ascii?Q?m0flVELjFp4M61xl0WvPGR94RAXoSwD2ncw9t4colLdL0Fi8ccbZEtAxstnf?=
 =?us-ascii?Q?ZMZBfxHgd8Y04p0Q2/6BE9hIIFvkYfOZ+fgkNgUoW8MIEQNl8/kjyE7jC4bV?=
 =?us-ascii?Q?kiW0YzP+C4R6NaHSg1PA7sH4CxwGh3zC76UUMTEcM25uo6kk+kOYAaoXvhQA?=
 =?us-ascii?Q?ab5N2ANLykIpQcGZdyqSn8/A2yqINqdF0+fyhlDFLk7R59eB7kwJJI0JjYGX?=
 =?us-ascii?Q?KyyTUwyGbKv5Aq2ikkv3tWIZmmtiQ83/LhyBIDEBocGITkmWqGnkDUURwXQn?=
 =?us-ascii?Q?EqsiVZ/wJVQXMovRjemXmFEXxa11QvC8owWQqhXOoyeLgaW6P4/jF6ZIfzlR?=
 =?us-ascii?Q?o9TPeRKh725JJJj8Hz78tssACP/bo+L8fINIrY9hmTIbf/uK9WaHTJvrQ94u?=
 =?us-ascii?Q?uGdfGYa+2W9M7LoNWAFPK1tbFAzru/fjHj7mRvyxnEJrWmKAydPK5CjG4us6?=
 =?us-ascii?Q?6sb1OFDtUR4beSEcP3Zar5Uv9eAq7DDxBmUwbv39L/LvLwotdbp8Hy407ceu?=
 =?us-ascii?Q?9uP0x9H3zcpjMY80qs9dAT79v94KBTA5MSCtt14YZIkoRHnZGsgDOkvKU7JQ?=
 =?us-ascii?Q?e3qwQu+q7n5QpYZXfsPX3d5WFYfwzC8Yf+biAXK59kkIKFvhxRO0QG7G8fqL?=
 =?us-ascii?Q?h0QhrBJsiK6c+2iQaAwv6lYcca9JaSv/jfOKSe8p61264T+NR40lN30eOCs/?=
 =?us-ascii?Q?i0IfYGUK9v2fIJUrZTlOIO0l2xFTn36dkWJVewcgrP18Q4xQRg0IJbaKc+zw?=
 =?us-ascii?Q?Q+vwN2cl5cosUgpFz/O/6lZTlYiQh16gXoegBfAbZ7RY/x1ViYuugHIDv4F0?=
 =?us-ascii?Q?Rmy0VOzlZC4JRwcFl0VQh86XRbzljYrppBGfotQCRDjdHnlWQlUQA/X/4cWd?=
 =?us-ascii?Q?GYLxgiaOe1uuGBLI/HZMfG6mw9qzCPyMPzan2bHLXpB4FoVES58hudWs+kjF?=
 =?us-ascii?Q?KYffuOjAYx+b5jY6wu6YXjz4Zog1V0ASz9M20F+Ya8UqzZsGUj8GYLmUaAxk?=
 =?us-ascii?Q?+sSB/exRzipuTZYDmTHS7B8TKcB9YqWMUGFf6P7N+t4LbtNckfMeaRlCukfP?=
 =?us-ascii?Q?q7eYbkAWIDcCeBgftDHiDomVuQf+NdODCzfrjEpjKkyhZRgdvoo8ULbA1cWq?=
 =?us-ascii?Q?VwCTgYdZ3PHP4gSxss9+AWI3jXRRojSyMYw3w22F?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49a15624-7b81-46a2-bea8-08dc597c49a4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 16:35:52.7044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q9Ocy21G4TwlJNhKp+Ec/OEbA2YmSQL2vipVjo7sV4KaHTcq9bIDyzFfk50ZAgoJdUX9KW8QeJgtaQuR5fT+2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8638

On Wed, Apr 10, 2024 at 04:45:47PM +0100, Will Deacon wrote:
> On Wed, Apr 10, 2024 at 07:39:46AM +0000, Xu Yang wrote:
> > > On Fri, Mar 22, 2024 at 02:39:25PM +0800, Xu Yang wrote:
> > > > In current design, the user of perf app needs to input counter ID to count
> > > > events. However, this is not user-friendly since the user needs to lookup
> > > > the map table to find the counter. Instead of letting the user to input
> > > > the counter, let this driver to manage the counters in this patch.
> > > 
> > > I think we still have to support the old interface so that we don't break
> > > those existing users (even if the driver just ignores whatever counter ID
> > > is provided in a backwards-compatible way).
> > > 
> > > > This will be implemented by:
> > > >  1. allocate counter 0 for cycle event.
> > > >  2. find unused counter from 1-10 for reference events.
> > > >  3. allocate specific counter for counter-specific events.
> > > >
> > > > In this patch, counter attribute is removed too. To mark counter-specific
> > > > events, counter ID will be encoded into perf_pmu_events_attr.id.
> > > >
> > > > Reviewed-by: Frank Li <Frank.Li@nxp.com>
> > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> > > >
> > > > ---
> > > > Changes in v6:
> > > >  - new patch
> > > > Changes in v7:
> > > >  - no changes
> > > > Changes in v8:
> > > >  - add Rb tag
> > > > ---
> > > >  drivers/perf/fsl_imx9_ddr_perf.c | 168 ++++++++++++++++++-------------
> > > >  1 file changed, 99 insertions(+), 69 deletions(-)
> > > >
> > > > diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> > > > index 0017f2c9ef91..b728719b494c 100644
> > > > --- a/drivers/perf/fsl_imx9_ddr_perf.c
> > > > +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> > > > @@ -245,14 +249,12 @@ static const struct attribute_group ddr_perf_events_attr_group = {
> > > >       .attrs = ddr_perf_events_attrs,
> > > >  };
> > > >
> > > > -PMU_FORMAT_ATTR(event, "config:0-7");
> > > > -PMU_FORMAT_ATTR(counter, "config:8-15");
> > > > +PMU_FORMAT_ATTR(event, "config:0-15");
> > > 
> > > Sadly, this is a user-visible change so I think it will break old tools,
> > > won't it?
> > 
> > For imx ddr pmu, most of the people will use metrics rather event itself,
> > and we have speficy the format of event parameters in metrics table.
> > The parameters is also updated in this patchset.
> > 
> > And to easy use for user, the counter should be hidden (transparent) to
> > user after I had talk with Frank. Then, the user need't to look up the event
> > table to find which counter to use. 
> > 
> > So this patchset will basically not break the usage of perf tools and will
> > improve practicality.
> 
> Sorry, but I don't agree. The original commit adding this driver
> (55691f99d417) gives the following examples in the commit message:
> 
> For example:
>       perf stat -a -I 1000 -e imx9_ddr0/eddrtq_pm_rd_trans_filt,counter=2,axi_mask=ID_MASK,axi_id=ID/
>       perf stat -a -I 1000 -e imx9_ddr0/eddrtq_pm_wr_trans_filt,counter=3,axi_mask=ID_MASK,axi_id=ID/
>       perf stat -a -I 1000 -e imx9_ddr0/eddrtq_pm_rd_beat_filt,counter=4,axi_mask=ID_MASK,axi_id=ID/
> 
> I don't think these will work any more if we apply this patch.

Yang:

    keep compatible is important. Please try well's suggestion
    "if the driver just ignores whatever counter ID is provided in a 
backwards-compatible way)." 

    If you have further question, you can ping directly. Please avoid
use outlook to reply community email. It always append annoised "EXT".

Frank

> 
> Will