Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp287156lqj; Wed, 10 Apr 2024 10:20:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWqtIbEP2lMHzJFjbGOSiEMAvuWgCGyJRP3GIdsZJ424KwCWEva+D0lwF/3Jm7oomfIVa4NIbYLwmmGJMLybAzQMuMCnj2tB2wvzTGOrA== X-Google-Smtp-Source: AGHT+IFGYqQoRblmp0pdlhGs1/kVE/82zWimNglfLoLGvSPLEz+93UQLiHnBgWdVPAmQkugBi446 X-Received: by 2002:a05:6358:90c2:b0:186:29ce:397d with SMTP id e2-20020a05635890c200b0018629ce397dmr3701071rwe.20.1712769622320; Wed, 10 Apr 2024 10:20:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712769622; cv=pass; d=google.com; s=arc-20160816; b=LD8cE4/tDKtHEA/6nIRUPORwDNU5Q8HHkFHGW4JZ5PwrT4YMhQPuuqgIP4R710Z/KS FBo805XDoAIzqmpWsM8ZvmRlFymIoIKTnrjI9iQwLHsyMLH+tqVF+8vHgsWjF+TiKAfx ytT0vbTGG/xIzBhSUyOvQFG/DflNzuuT/26/HqpojXmLCNFZzUqMdf9S5fAtkoT2Dzw4 36FooWAKDcaJ+Do+PxJvOGczxbaIL+mWcRdST2UxaSfNkw4iiPp+UH2U2LtrIJ+M5sL/ Us+APm9SsGjewZ0+sulYp0xF9rWFpSXy//Vv7fS7NMzTQNGCzbP/p0sAotduXOHsvSrh L0Yg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=vg1pd797WWI5MkkVt5VBGTIHJqGZcRFQ/HmMvJNLEVU=; fh=vsj12YzCszPUCmMfm3bFHbnowGAdFMUJF9G4Odzv4b0=; b=HB3h2cGC8XP4+T5VZ33hTqOeR8q3DWCygHysg7qVLYG+uDaLUxl4uOdApVOAnRLpZs 2FMxYEEAdzek5oDfrF8QfLC+/iRNpDJFN4ulUPWulYWyS1HeftnJzQv3FolBMYFrmYDR LEBcZE4DmR7bbadzhsqQtYz2Bm/NY4ScRvXFPkQVqdcc2VvBh1M5QBnkVzv1MP+yYpLY 6ExhezSksdypvDJLXkqUdrOoachzZ1hqGs4eq3QJ1+r2N4iuldtJpPm8wVczDlHKJHwJ 9soZNidURiiOpbNXfD1IDLb8yHBo2MvoP3410DdyKViVabhpH/7oYisFpJf07C/IPIkp vEVg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bV3S7kYl; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-139003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139003-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m25-20020a637119000000b005dc47dd5dd2si11030271pgc.791.2024.04.10.10.20.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 10:20:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=bV3S7kYl; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-139003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139003-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8475DB2B8B3 for ; Wed, 10 Apr 2024 16:42:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D76417B506; Wed, 10 Apr 2024 16:41:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bV3S7kYl" Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3AD617B4F8; Wed, 10 Apr 2024 16:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712767318; cv=none; b=L/jR2u8Kg4WRcvu9gz1U0e8RqpKmw8AdniVfmbh4/385w2HBtPhwfxyM92tcuOhIrIeZJDSTVhrEsPgfBlFf8hrb9G7ygGSi84NJu7q7EGKHFx32nDOlig0ty4h+1bJrfDAAV3X0T33wFSMEqrYzBRdUBgZmI4QK8rxyZfjXqCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712767318; c=relaxed/simple; bh=9zBa+XKIY0+8MFywDp1jOUp+YUf+42xwXubODtyuNXU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DSe3jydDZ8nvAcWG0URf4qsxc2cAP0eUvcY1NiVt0rI8PDZ1LcjseCnv47+6HF78t65QDQL/hJgUqGGyWE7vOs6NKPN+tYzrlGzyTceEF2kf1shiUp6oLWMIwQssv1c/XInN2/r+/xnfaEH9KE2swXWgyHxpPGo6IhHKpFTgUsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bV3S7kYl; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-6ed054f282aso4263521b3a.0; Wed, 10 Apr 2024 09:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712767316; x=1713372116; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=vg1pd797WWI5MkkVt5VBGTIHJqGZcRFQ/HmMvJNLEVU=; b=bV3S7kYlxIUA7F50taKsJgwt2T898MtaFegrB1iWl2m7CeXdHkswY8TiCiCr2tcRVt kF8bQMu5F4xqVZc6j0RCW6ucraMuTtI+dslKgthv+KHBRY6v+nwj5d0GH9ORjFL1uV4R qIJuNB21RIuVcCfA96qUwb5jaBC97nVCaLkV2VvqrghUQd7otrwX9zOZCXUj6m226idz enDbXFutUgQlh+SvLE5YLlbWHG9p3QwmTioleNn8UAQdedpzC0+/Y/pIwqTdJF2Zr9cH i9bQL4GKWOWkt3+9jtf+Z+t5VkkkKhBEhFPYOaqFGqAqfTPx4MQ/TFufSnY+tx+eodej XeNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712767316; x=1713372116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vg1pd797WWI5MkkVt5VBGTIHJqGZcRFQ/HmMvJNLEVU=; b=hBgUdq4If5cjCltMnE3016/r+gLW3ypSubgmCVAEEu95jOvezHvHp7Kjfj48OoYn23 xojx9kKXJdCsjNQFjMxvrzULRu5ZsKxr38XQtLf+4tLvGKaZSskXDySYKqukCjenciDa VZs2LWhee+CwV/Uj1J33xtPkYkdcPIV93kjeENM7wii280m9gSjWHtbwYdg3p2NWWAXb deoLo2OCNKxYGyzEi7POy9uu3+rWt+Av/Z7E+dTibvyNOa4XdNfenfyJywyDn9B0ugf8 /nU+LxVMU/iRZHcPIUXc3SkRY30n+wHALADu189FbGkg0aYEOx9S+1BB98icAnjdzhR1 URWw== X-Forwarded-Encrypted: i=1; AJvYcCVZOtRBxw3B0XOOzMS4/5u3oTCq3j1vKghgQ9YH+I8RU4/6YDXWbJg9CRsJiObds/w01s+WIj66xznWzlb0y0FE7cM400+Nb9Aiprqruuv0tFeYw5WpWBtfxrrVQ1zpc+hNZ6FDBR11v/2hG50CQOd00LUKDgipxAkrKPAFRzLLpMalK+ftrAra511XRTiT3XzxIhS5zZuDeIM48G1ZKyUpq+2VnRjSJkNx17g= X-Gm-Message-State: AOJu0YwNIMznL7TYIBYyS9dzwViwodkNann3k9gSi+hsqSuINWF5xBVm 0jHLgb0qUCjx8SPMZLYLYAmZPsX152fCn3UO1nBXqWURnG30HGBU X-Received: by 2002:a05:6a00:1915:b0:6ec:d972:c3d8 with SMTP id y21-20020a056a00191500b006ecd972c3d8mr3523379pfi.10.1712767316021; Wed, 10 Apr 2024 09:41:56 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d23-20020aa78697000000b006ecec1f4b08sm10297677pfo.118.2024.04.10.09.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 09:41:55 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 10 Apr 2024 09:41:54 -0700 From: Guenter Roeck To: Claudiu Cc: wim@linux-watchdog.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, geert+renesas@glider.be, magnus.damm@gmail.com, biju.das.jz@bp.renesas.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Claudiu Beznea Subject: Re: [PATCH RESEND v8 06/10] watchdog: rzg2l_wdt: Remove comparison with zero Message-ID: <822db9c7-c9a9-414a-8a7a-5917b8cf5066@roeck-us.net> References: <20240410134044.2138310-1-claudiu.beznea.uj@bp.renesas.com> <20240410134044.2138310-7-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410134044.2138310-7-claudiu.beznea.uj@bp.renesas.com> On Wed, Apr 10, 2024 at 04:40:40PM +0300, Claudiu wrote: > From: Claudiu Beznea > > devm_add_action_or_reset() could return -ENOMEM or zero. Thus, remove > comparison with zero of the returning value to make code simpler. > > Signed-off-by: Claudiu Beznea Reviewed-by: Guenter Roeck > --- > > Changes in v8: > - none > > Changes in v7: > - none > > Changes in v6: > - none > > Changes in v5: > - none > > Changes in v4: > - none > > Changes in v3: > - none > > Changes in v2: > - none > > > drivers/watchdog/rzg2l_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/rzg2l_wdt.c b/drivers/watchdog/rzg2l_wdt.c > index 93a49fd0c7aa..29eb47bcf984 100644 > --- a/drivers/watchdog/rzg2l_wdt.c > +++ b/drivers/watchdog/rzg2l_wdt.c > @@ -316,7 +316,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) > > watchdog_set_drvdata(&priv->wdev, priv); > ret = devm_add_action_or_reset(&pdev->dev, rzg2l_wdt_pm_disable, &priv->wdev); > - if (ret < 0) > + if (ret) > return ret; > > watchdog_set_nowayout(&priv->wdev, nowayout); > -- > 2.39.2 >