Received: by 2002:ab2:4a89:0:b0:1f4:a8b6:6e69 with SMTP id w9csp330303lqj; Wed, 10 Apr 2024 11:38:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWrzalTpJXfHTg4Hb63SdCGls/3aJX0Kngro34fsrl9KAKfYJFKrVj9sQjfsTs6c/CT2IQLq6pifMcU6aK9S2DSDQcKTcoWbjxRpTtXFw== X-Google-Smtp-Source: AGHT+IHaKxc6+LiPfmodTd0D2ZfMZaf89mXoRJ3qH72cTK73JHZ6qVkbLPz1d/n1ozLzjuETCRga X-Received: by 2002:a17:906:f108:b0:a51:c88e:e95a with SMTP id gv8-20020a170906f10800b00a51c88ee95amr1717954ejb.23.1712774307983; Wed, 10 Apr 2024 11:38:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712774307; cv=pass; d=google.com; s=arc-20160816; b=z88T+oJyQZ05NmKnV5V+gG7tMJZu+1sL5rzIyn2m0ZMTFLGxX/tPby95pFbRsCG7In WARtv+8bQ/NPpybbuHUPxp0er0T38Yzx0h5xNCiI4nkGGaY5Hy4sA7Ty+CEgP6y9Hl5A 6g3PK+BMeE6njLMYWaIXvLaZrKY4ht6+CCqREQsclVUAH8vqrouK2amAsrqGmPWpXnyT IjH1SCRZg7xhWQoyo4UKAd3WfupGwciTkIkaenUOl1e7dFb5D6RxsjVWWTebGwuXPMHy IUp1p11WKw5wXNvwjiuZJjoV519l5g/hEmUbrkmJLyYfImrktGFijj78fnbBM3oXJ9/t 8a3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=pEE+xgr+mIvlXPRvnWk4B6lc0AYdaO9fL8/9QPaQSB0=; fh=8j/IhlEdyUwH6sLNx+VqwjYz/xz87W/G7zIttIjGHYY=; b=OD4QNS8SiwuRRuAkgAyUlweyefxYtSFGFXtL4Pd+Pfi91dDA6zRpvEpwfNdUyit7C/ 8TPLVp4A7T049rNtC3bzLKKSU2exz6nYscrnUpFcsuu6Y2INCKghHM2UKtoLdy1c+V03 k+Yvzk6/fs0+N2axSrwkFvrGdV4NKGWRR01cntDaweWGrlzyTfCJrcdVCeSKFocefTP9 FM8tuJd9l24hHBdtnkW9Uk2DISJvcFpqhOLSg1klkKosY/qOz96Z2g9V1pNXEsj+8Lvu NKokHU3WgV/pOZJyyJAGePDqYcLxape0mFdiAH5vg7yhqbzefgVVhSGOYx0xQEiDSl4k vZhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eAk82lcO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139204-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id xa11-20020a170907b9cb00b00a5219cab40bsi133474ejc.612.2024.04.10.11.38.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 11:38:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eAk82lcO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139204-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139204-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F007A1F2A783 for ; Wed, 10 Apr 2024 18:30:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16EE1181304; Wed, 10 Apr 2024 18:28:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eAk82lcO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3872E1802BF; Wed, 10 Apr 2024 18:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712773727; cv=none; b=Uc1t6bbAlsMzwE+NJUVRFmAHyPJvu5u5py7iaGm+r5Ej0xUEKkpHfam1IuRdPN1mjy98q5NtvQU1o6MUy6fznjU8u5FuX0cR2Zmd1v6YsQfkqSEUDKeSUcXANjIkzYR1yhw5aKses++pbI9xvrg85fkawFhlqI/ZAdEX2umEMUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712773727; c=relaxed/simple; bh=aIvegxIwbMj6/MAqgtGgSgJk65LlTqgxYpHoBrkDAdc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VVRC89w2PVA0ytwJlI0sTLcvunu4Una9pDJ282jsERus+N//yL68HIBZMF/6shuELHrRRTVWHhyn6uGp2bX0FtdcCqKvLal5t7o/0j1pFb+PsYAU5bPmqG79ZeLRY6hnDFvdNx4CbXLTFIDYwqpHwbUMbD06u8U8dzFvg+YTg2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eAk82lcO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD387C433C7; Wed, 10 Apr 2024 18:28:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712773725; bh=aIvegxIwbMj6/MAqgtGgSgJk65LlTqgxYpHoBrkDAdc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eAk82lcOEg9ZbneOAZHkRYOPj9yUVokbKNeshaLGSmhmrdNoHSR9QgtkVFd0QeUgM 8p5t1z3MV6KpBkqwnF/UNrGs447f1FBfJVjeiN0sofHP9TmYdPBPV7kUqdph3jSFgV g1yBzcFM7/qzGmqQgz4ViRrJbckEw1ShR7blHXZYfCzYAot8j23aFFolOpw69Zyfmq 4R5A7ZZMveun7zBhn4iCzMDo8F5KpVLQDVQXWWjEZnLwQf4eup42gSrTz6sJOejDBL DDZTI1ZLkGa4syzQRoKgo2fuqS7h/kc5HTuIYkBmoykHvKSVsV+TSqiGu6wmtRkBkn pm27PNykA4D7g== Message-ID: <689f6a74-185d-4f2f-8c31-e6502b7e6060@kernel.org> Date: Wed, 10 Apr 2024 20:28:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: fix module autoloading To: Bjorn Andersson , Konrad Dybcio Cc: Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240410164045.233198-1-krzk@kernel.org> <22f5eb76-8f81-46ea-b0a7-5f1d231e7833@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/04/2024 20:11, Bjorn Andersson wrote: > On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote: >> >> >> On 4/10/24 18:40, Krzysztof Kozlowski wrote: >>> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded >>> based on the alias from of_device_id table. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >> >> These were omitted intentionally, as these are both debug drivers. >> > > Makes sense to me, could we have a comment added that clarifies this > intention? > >> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer >> > > Not sure if that is necessary, and IMO it wouldn't convey that > MODULE_DEVICE_TABLE() was omitted intentionally. I think this deserves a comment, so no one will be doing my same again (it's part of bigger effort). Best regards, Krzysztof