Received-SPF: pass (google.com: domain of linux-kernel+bounces-139172-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 10 Apr 2024 11:11:31 -0700
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>,
        Bjorn Andersson
	<andersson@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: qcom: fix module autoloading
Message-ID: <ZhbWU0lk4mNBv1OE@hu-bjorande-lv.qualcomm.com>
References: <20240410164045.233198-1-krzk@kernel.org>
 <22f5eb76-8f81-46ea-b0a7-5f1d231e7833@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <22f5eb76-8f81-46ea-b0a7-5f1d231e7833@linaro.org>

On Wed, Apr 10, 2024 at 07:53:32PM +0200, Konrad Dybcio wrote:
> 
> 
> On 4/10/24 18:40, Krzysztof Kozlowski wrote:
> > Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> > based on the alias from of_device_id table.
> > 
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> 
> These were omitted intentionally, as these are both debug drivers.
> 

Makes sense to me, could we have a comment added that clarifies this
intention?

> Perhaps we could mkdir drivers/soc/qcom/debug to make this clearer
> 

Not sure if that is necessary, and IMO it wouldn't convey that
MODULE_DEVICE_TABLE() was omitted intentionally.

Regards,
Bjorn