Received-SPF: pass (google.com: domain of linux-kernel+bounces-139277-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <0655cea93e52928d3e4a12b4fe2d2a4375492ed3.camel@linux.ibm.com>
Subject: Re: [REGRESSION] Loss of some SMART information in v6.1.81
From: James Bottomley <jejb@linux.ibm.com>
Reply-To: jejb@linux.ibm.com
To: Cyril Brulebois <kibi@debian.org>, regressions@lists.linux.dev,
        stable@vger.kernel.org
Cc: Mike Christie <michael.christie@oracle.com>,
        "Martin K. Petersen"
 <martin.petersen@oracle.com>,
        Sasha Levin <sashal@kernel.org>, gregkh@linuxfoundation.org,
        Bart Van Assche <bvanassche@acm.org>, Christoph
 Hellwig <hch@lst.de>,
        John Garry <john.g.garry@oracle.com>, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Diederik de Haas
 <didi.debian@cknow.org>,
        Salvatore Bonaccorso <carnil@debian.org>
Date: Wed, 10 Apr 2024 15:36:18 -0400
In-Reply-To: <20240410193207.qnb75osxuk4ovvm6@mraw.org>
References: <20240410193207.qnb75osxuk4ovvm6@mraw.org>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-jIeTBq4V93wWqSdiIOVb"
User-Agent: Evolution 3.42.4 
Precedence: bulk
MIME-Version: 1.0


--=-jIeTBq4V93wWqSdiIOVb
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 2024-04-10 at 21:32 +0200, Cyril Brulebois wrote:
> Hi,
>=20
> Munin uses the following command to get sensor-type information out
> of SMART-aware disks (e.g. temperature):
>=20
> =C2=A0=C2=A0=C2=A0 /usr/sbin/smartctl -A --nocheck=3Dstandby -d ata /dev/=
sda
>=20
> This broke following an upgrade from v6.1.76 (as found in Debian 12)
> to v6.1.82 (as currently found in the proposed-updates repository for
> the next point release of Debian 12), with smartctl's now reporting:
>=20
> =C2=A0=C2=A0=C2=A0 smartctl 7.3 2022-02-28 r5338 [x86_64-linux-6.1.0-19-a=
md64]
> (local build)
> =C2=A0=C2=A0=C2=A0 Copyright (C) 2002-22, Bruce Allen, Christian Franke,
> www.smartmontools.org
> =C2=A0=C2=A0=C2=A0=20
> =C2=A0=C2=A0=C2=A0 Device is in SLEEP mode, exit(2)
>=20
> This happens on baremetal with 2 pairs of disks:
> =C2=A0- 2=C3=97ST4000VN008-2DR1 (sda, sdb)
> =C2=A0- 2=C3=97ST8000VN004-2M21 (sdc, sdd)
>=20
> and that's an obvious lie with one pair doing system stuff and the
> other
> one doing media stuff.
>=20
> This also happens within a Debian 12 QEMU VM running on a Debian 12
> libvirt host, when using a SATA disk, which is what I've used to test
> various builds from the stable/linux-6.1.y branch and associated
> tags.
>=20
> Building stable releases, I pinpointed it as a regression between
> v6.1.80 and v6.1.81, then pinpointed it to commit cf33e6ca12d8.
>=20
> #regzbot introduced: v6.1.80..v6.1.81
> #regzbot introduced: cf33e6ca12d8
>=20
> This is also affecting v6.1.84 and v6.1.85 (released during my git
> bisect session).
>=20
> Reported in Debian via: https://bugs.debian.org/1068675=C2=A0(which
> included a trace with the distribution-provided v6.1.82 package).
>=20
> Most recent trace, with v6.1.85 (mainline, using the distribution's
> config but without any patches):
>=20
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547027] ------------[ cut here ]-----=
-------
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547034] WARNING: CPU: 0 PID: 697 at
> drivers/scsi/scsi_lib.c:214 scsi_execute_cmd+0x42/0x2c0 [scsi_mod]
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547082] Modules linked in: tls tun in=
tel_rapl_msr
> intel_rapl_common kvm_intel kvm irqbypass ghash_clmulni_intel
> sha512_ssse3 sha512_generic sha256_ssse3 sha1_ssse3
> snd_hda_codec_generic ledtrig_audio snd_hda_intel snd_intel_dspcfg
> snd_intel_sdw_acpi aesni_intel snd_hda_codec crypto_simd cryptd rapl
> snd_hda_core snd_hwdep bochs drm_vram_helper pcspkr drm_ttm_helper
> snd_pcm iTCO_wdt snd_timer intel_pmc_bxt ttm iTCO_vendor_support snd
> watchdog soundcore virtio_console virtio_balloon drm_kms_helper
> button joydev evdev serio_raw sg binfmt_misc fuse loop drm efi_pstore
> dm_mod configfs qemu_fw_cfg virtio_rng ip_tables x_tables autofs4
> ext4 crc32c_generic crc16 mbcache jbd2 hid_generic usbhid hid sd_mod
> t10_pi crc64_rocksoft crc64 crc_t10dif crct10dif_generic ahci libahci
> virtio_scsi virtio_blk virtio_net net_failover failover xhci_pci
> crct10dif_pclmul crct10dif_common crc32_pclmul libata crc32c_intel
> xhci_hcd psmouse i2c_i801 i2c_smbus scsi_mod scsi_common lpc_ich
> virtio_pci
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547194]=C2=A0 virtio_pci_legacy_dev v=
irtio_pci_modern_dev
> usbcore usb_common virtio virtio_ring
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547205] CPU: 0 PID: 697 Comm: smartct=
l Not tainted 6.1.85
> #1
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547210] Hardware name: QEMU Standard =
PC (Q35 + ICH9,
> 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
> =C2=A0=C2=A0=C2=A0 [=C2=A0=C2=A0 30.547217] RIP: 0010:scsi_execute_cmd+0x=
42/0x2c0 [scsi_mod]

This is a different manifestation of the same bug in stable that was
introduced by a backport of scsi_execute_cmd.  The proposed fix for the
domain validation problem here will also sort out this problem:

https://lore.kernel.org/linux-scsi/yq1frvvpymp.fsf@ca-mkp.ca.oracle.com/

James


--=-jIeTBq4V93wWqSdiIOVb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iHUEABMIAB0WIQTnYEDbdso9F2cI+arnQslM7pishQUCZhbqMgAKCRDnQslM7pis
hW3aAP9cB50hV7umpS8AXMm+EU6/C3B+X0AS2f7y6wZIGUfgDAEA02ZobSW6RlRI
1kbTb8SI4lt+YAiluDoI19ehkVz4rvI=
=JIJn
-----END PGP SIGNATURE-----

--=-jIeTBq4V93wWqSdiIOVb--