Received-SPF: pass (google.com: domain of linux-kernel+bounces-139288-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 10 Apr 2024 21:03:14 +0100
From: Mark Brown <broonie@kernel.org>
To: =?iso-8859-1?Q?Th=E9o?= Lebrun <theo.lebrun@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Vaishnav Achath <vaishnav.a@ti.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Rob Herring <robh@kernel.org>, linux-spi@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>
Subject: Re: [PATCH v3 4/9] spi: cadence-qspi: allow FIFO depth detection
Message-ID: <161eebc1-9417-4ab0-ad8c-c1b17be119b4@sirena.org.uk>
References: <20240410-cdns-qspi-mbly-v3-0-7b7053449cf7@bootlin.com>
 <20240410-cdns-qspi-mbly-v3-4-7b7053449cf7@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="BRtEqc5sxDPHJ2tk"
Content-Disposition: inline
In-Reply-To: <20240410-cdns-qspi-mbly-v3-4-7b7053449cf7@bootlin.com>


--BRtEqc5sxDPHJ2tk
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 11:29:07AM +0200, Th=C3=A9o Lebrun wrote:

> If FIFO depth DT property is provided, check it matches what hardware
> reports and warn otherwise. Else, use hardware provided value.
>=20
> Hardware exposes FIFO depth indirectly because
> CQSPI_REG_SRAMPARTITION is partially read-only.

This breaks an allmodconfig build:

/build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function =E2=80=98=
cqspi_of_get_
pdata=E2=80=99:
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1506:45: error: unused=
 vari
able =E2=80=98ddata=E2=80=99 [-Werror=3Dunused-variable]
 1506 |         const struct cqspi_driver_platdata *ddata =3D cqspi->ddata;
      |                                             ^~~~~
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function =E2=80=98=
cqspi_control
ler_detect_fifo_depth=E2=80=99:
/build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1582:45: error: unused=
 vari
able =E2=80=98ddata=E2=80=99 [-Werror=3Dunused-variable]
 1582 |         const struct cqspi_driver_platdata *ddata =3D cqspi->ddata;
      |                                             ^~~~~
cc1: all warnings being treated as errors

--BRtEqc5sxDPHJ2tk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYW8IEACgkQJNaLcl1U
h9AP3Qf9HrV26p6I6pNjiy1Rr+g3QMlk44F2HNPvnj7jvAfZmd1M6+sG/WykOdPX
Wnkq1igLy45LZzQB/smyw3eFOzlDyZHs7diTtDOKsx7hC1KLYzbX1n7s8IVzx2FD
UDJYdBzop0PAQT6Sk1VrHPgC5TCWwRNlwTs+WKqo+/aLndCxKlS+4ZVZeyGV+FYJ
gE1YZe/Z9EZZoVm86tEd9Os57oQUfq0T6gU29g7H9cDMu0TJy4uwPnnOxbf74GCO
z1qBAffTfUAERgs7anH+e3xNyvejRwTM9spESFKPxeNiH8s0eg9N+tzcGTa5GsAl
I2Dx4GjIaTHoao5epVvxs6ODnuTk5w==
=sDD9
-----END PGP SIGNATURE-----

--BRtEqc5sxDPHJ2tk--