Received-SPF: pass (google.com: domain of linux-kernel+bounces-139343-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 10 Apr 2024 18:00:23 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: James Clark <james.clark@arm.com>, Ian Rogers <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org, namhyung@kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	"Liang, Kan" <kan.liang@linux.intel.com>,
	Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
	Spoorthy S <spoorts2@in.ibm.com>, Leo Yan <leo.yan@linux.dev>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] perf test: "object code reading" test fixes
Message-ID: <Zhb95zKXvVDtUljY@x1>
References: <20240410103458.813656-1-james.clark@arm.com>
 <CAP-5=fVgf3cOgbV1KGGLd5gykxT+BzuX1=XUsp+2BNUahGn6QQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAP-5=fVgf3cOgbV1KGGLd5gykxT+BzuX1=XUsp+2BNUahGn6QQ@mail.gmail.com>

On Wed, Apr 10, 2024 at 09:17:04AM -0700, Ian Rogers wrote:
> On Wed, Apr 10, 2024 at 3:35 AM James Clark <james.clark@arm.com> wrote:
> >
> > A few fixes around the object code reading test. The first patch
> > appears to be unrelated, but in this case the data symbol test is
> > broken on Arm N1 by the second commit.
> >
> > Changes since V1:
> >   * Put data symbol test fix first so that bisecting still works on N1
> >   * Instead of skipping "test data symbol" on N1, add some noise into
> >     the loop.
> >   * Add a commit to replace the only usage of lscpu in the tests with
> >     uname
> >
> > James Clark (4):
> >   perf tests: Make "test data symbol" more robust on Neoverse N1
> >   perf tests: Apply attributes to all events in object code reading test
> >   perf map: Remove kernel map before updating start and end addresses
> >   perf tests: Remove dependency on lscpu
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to perf-tools-next,

- Arnaldo