Received-SPF: pass (google.com: domain of linux-kernel+bounces-139388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <4875349a-90e5-4a04-8a56-7d172b17e245@intel.com>
Date: Thu, 11 Apr 2024 09:54:13 +1200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/5] x86/kexec: do unconditional WBINVD for bare-metal
 in stop_this_cpu()
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CC: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <dave.hansen@intel.com>,
	<bp@alien8.de>, <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
	<luto@kernel.org>, <peterz@infradead.org>, <rick.p.edgecombe@intel.com>,
	<thomas.lendacky@amd.com>, <ashish.kalra@amd.com>, <chao.gao@intel.com>,
	<bhe@redhat.com>, <nik.borisov@suse.com>, <pbonzini@redhat.com>,
	<seanjc@google.com>
References: <cover.1712493366.git.kai.huang@intel.com>
 <33b985a8f4346f4bcf0944eaf37193a906b11af3.1712493366.git.kai.huang@intel.com>
 <a4o4wlaojm5am4hc5yhr2mpn7clm3sjy5vx3w76ahm52lhxvwr@msdcnkcj3i6k>
Content-Language: en-US
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <a4o4wlaojm5am4hc5yhr2mpn7clm3sjy5vx3w76ahm52lhxvwr@msdcnkcj3i6k>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2NGR0w5M2JPaDFzaThuZDQxS0lHdjNtTjZtcENuTUpsOWNoT1YyOThPWk16?=
 =?utf-8?B?NVd4NXU4WnZmelRYQ1hiSDlESzdpeldwZjRyREt5cG1sL3ZaMmlpNTZ1enVh?=
 =?utf-8?B?N29aa2FjaVNzcVEyOVRPTytFOVNjaE9xUzMxYkU1NjV5aVA3cDJZRWt3bTVl?=
 =?utf-8?B?dTV4WXQyRkxXLytTYXhKaGd5azB3Ky9HY29pdnRHZW9MMDN6M3lnMjZlYjJj?=
 =?utf-8?B?M25hTytqWUFkZTVrRjNCUXVYS05wOHpWbEtybWwxK29XZDZ4bTVUNGNnU0FS?=
 =?utf-8?B?U21OUmJmQVQ0WXVkbVdTYkRidjdhZHJqd2Z3U2s3aE5DSHNnVFNwWFdiYzhs?=
 =?utf-8?B?dXZRUDc4OVpraVVibUNYR1d1cjRYVzJNOWRXWjJPZVNpekpMTklVWlRwalZn?=
 =?utf-8?B?M3hBaGtodzBLTDFDYmROWFRWR2hnUk5hdFVIYURORWhUT3FYUlExSzNBcjFP?=
 =?utf-8?B?V2lvd29nUDNkZEJqbHJaM1R0a0JCaXVtT2ZKV1JKZ2VLSlk4RzFhbXZ1T0x3?=
 =?utf-8?B?bGgwWERKbUtISG83akd4R3NpeGZkaHcrU3lCTGEzY1ZzUGVCQWIwalQ4RjhZ?=
 =?utf-8?B?ZDFWdUZVNHc3VkxNM3F3Y28rb3B3N0ZSd0doa2d0S2xRSUxncjFNcVAzVEhq?=
 =?utf-8?B?bjRLZW5hbDA5eXlPSXlEZ25VZHpoNmdCb05oV0RmQ1dFUHkvSUdxaTB6bjA1?=
 =?utf-8?B?NDNWOXBDWmlzWmhwODRnc0pTcjVFZkJ4bFlkRkpJcWhkZ2M5cExtLzNWMjJD?=
 =?utf-8?B?Y1dkL0VqbnFoZTl0ZWd1c2lLdHA1RDZxK29iTjlkTEY5ZVljTzRXMWJQRjFR?=
 =?utf-8?B?Z05aVnh5eHYvRTlVc1pqRUsydzBqWXdsMUVJNE9qWjZRQ3FFcEE4VW1OeVZY?=
 =?utf-8?B?SjNtYWY0b2tBUWFSNmFzOHdBRHp0ejh5Z3Q2T0NURy8yUTlCdzNKYmpvUENy?=
 =?utf-8?B?VWh6WFp0V051bkxSV3IxUmN4RlVkbDJFa2dOelRFOW1RU3FhbUxqT0tNcFph?=
 =?utf-8?B?QjVoUisrUDhmL0pMaERuWHRmY3NESkE2dEVXQnpWRlp2YlNWbG9pV2lNVE1T?=
 =?utf-8?B?eXlMck8yYWpXbUNycmtWN2YyRmNLUytNdytFa1l4am5YNmFwaDNhRFh4YStX?=
 =?utf-8?B?VlNKT2NJcXJDN05DUzRqT0U4S0JZMWxkVXNTUElpVWpuSHJoY3BFQlpHTDRO?=
 =?utf-8?B?SndacEJ1UnVvZmVScklhcjVJcDZCc1B0YTVhbnVQMU5EVUNYMVFrcy90dzcv?=
 =?utf-8?B?bHJxRDBLUHVoYytLYXJ5aDFtUFo5QVdFeTFyZXBSUHBIbTNQNU40WjdHREdR?=
 =?utf-8?B?S1AwUFZnd0dxS3R5S3JOUFFkRXV1bzdLeDhkSTFCR2NBQkFVOGlFSHB5Q1d5?=
 =?utf-8?B?ckdET2F0Wnd5M0hFem55V0FKUUc3Zjk5dXJPSFJieWlnVUI3OWVmc01NRlhL?=
 =?utf-8?B?OWhid0pFcEYvQkVXbHdvV0doNi9SZ2Q5WEkzNDNYUzdJdDJZdHBRcUdIUU9m?=
 =?utf-8?B?SnJoaWo2b1g5Uld0cUlzSU5Sb0Q0TUgzVGRzQ0xXSHBXYTh5d1BNM01saGZF?=
 =?utf-8?B?WlJ1WnI3VUkxQ2dORXovZTByaXBydkJZZnJ0V2U4S3Y0ZEtVNXFPM1AzODJL?=
 =?utf-8?B?VFE4aktOWTFyS1h4aTNQaDJOVXlXb3hxdEtrODUrU0E4NE0xTERRRGE3NFFo?=
 =?utf-8?B?cHd6OU5VdzdyNUdNNEQ4NXhhTjFUdHRTWHIxNzFnRjZNSzBldWo5NDRDaUxU?=
 =?utf-8?B?Z0JwZmVsUFEwRCs4TnRDY2dRTjBTQ1Nta3pCRXgwdWRQRVdSdVVxaHNnRFlJ?=
 =?utf-8?B?Si93VmFXQ0tFeXorMTF0S2hjNnROTU5xNTBEVHVCZTNaVlNOUUxZY3Q3TElk?=
 =?utf-8?B?a2MxUWp1TGtxZERvUy9kTk9TekFrczl6d3gxVUFYWHUxcFdyYUMzb1JBU3Yr?=
 =?utf-8?B?MVFzd0NHRzhiYWxYaWFQVmZOcFEwa0JzWThWSlF4Vm0zTlg1WHNEOWlFdktq?=
 =?utf-8?B?cjNJK0UvR2pPSSs2eUI5NktaQ0R5aWpqMHhXSHlzRklwc2RJZWd4Q0xjSmoz?=
 =?utf-8?B?QktrcmV4VHJiVmNSUVBsZStlSWYvdm1IemNTN0JST0RVOFFwZTM0WHZMTksy?=
 =?utf-8?Q?mWHIffrCwQoeEm5XyYpzgThsT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7abc864d-a7a4-4d1a-1767-08dc59a8c9ab
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 21:54:25.4562
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Xh9PEwTaVnxVCyyestT2FU+WyLg4Wgfqh9u4ZxQX+t360mEp09UYqiqHYNX1FKS3rf0RPqdtpjKLbA/GOFz1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8723
X-OriginatorOrg: intel.com


On 11/04/2024 2:12 am, Kirill A. Shutemov wrote:
> On Mon, Apr 08, 2024 at 12:44:54AM +1200, Kai Huang wrote:
>> TL;DR:
> 
> The commit message is waaay too verbose for no good reason. You don't
> really need to repeat all the history around this code.

Could you be more specific?

I was following Boris's suggestion to summerize all the discussion 
around the "unconditional WBINVD" issue.

https://lore.kernel.org/linux-kernel/20240228110207.GCZd8Sr8mXHA2KTiLz@fat_crate.local/

I can try to improve if I can know specifically what should be trimmed down.

> 
>> ---
>>   arch/x86/kernel/process.c | 18 ++++++++----------
>>   1 file changed, 8 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
>> index b8441147eb5e..5ba8a9c1e47a 100644
>> --- a/arch/x86/kernel/process.c
>> +++ b/arch/x86/kernel/process.c
>> @@ -813,18 +813,16 @@ void __noreturn stop_this_cpu(void *dummy)
>>   	mcheck_cpu_clear(c);
>>   
>>   	/*
>> -	 * Use wbinvd on processors that support SME. This provides support
>> -	 * for performing a successful kexec when going from SME inactive
>> -	 * to SME active (or vice-versa). The cache must be cleared so that
>> -	 * if there are entries with the same physical address, both with and
>> -	 * without the encryption bit, they don't race each other when flushed
>> -	 * and potentially end up with the wrong entry being committed to
>> -	 * memory.
>> +	 * The kernel could leave caches in incoherent state on SME/TDX
>> +	 * capable platforms.  Flush cache to avoid silent memory
>> +	 * corruption for these platforms.
>>   	 *
>> -	 * Test the CPUID bit directly because the machine might've cleared
>> -	 * X86_FEATURE_SME due to cmdline options.
>> +	 * stop_this_cpu() is not a fast path, just do unconditional
>> +	 * WBINVD for simplicity.  But only do WBINVD for bare-metal
>> +	 * as TDX guests and SEV-ES/SEV-SNP guests will get unexpected
>> +	 * (and unnecessary) #VE and may unable to handle.
> 
> s/#VE/exception/
> 
> On SEV it is #VC, not #VE.
> 

Thanks.  I think I'll use "exception (#VE or #VC)" which is clearer, as 
Tom typed in the comments to patch 2.