Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp71318lqg; Wed, 10 Apr 2024 16:04:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFnlJbcci2r0TrG2m6LWHgXZbxqcSyZ+JEUm+vcXiRoeW9LDik2161UGTiRK9tUlK0/zT3JQ5+KaO1wNZMZfogRoacw4/qKJoOYL74ng== X-Google-Smtp-Source: AGHT+IEBqN7jPLQiQQQJLxF4BHN4Pg/2rpcxw4hdSKon4fDwkE2shAbghyOJIIzlOujJ9lBq21pY X-Received: by 2002:a17:902:f552:b0:1e4:ccf6:209f with SMTP id h18-20020a170902f55200b001e4ccf6209fmr5204987plf.28.1712790282259; Wed, 10 Apr 2024 16:04:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712790282; cv=pass; d=google.com; s=arc-20160816; b=PSOPH5nLFJezmLFSOIli0uVZivg+EBJQsL070Y+/XwNrfnAtlNa96lLhI1RU2FU9Qi N1XGxv6vLO/riuOTeLg97CXJkqm22pizfPcLbMhvhKnAwll6gr9iahnqh+2z0SjNJqfr xzJumGOjCdrDPTvc9eKlOsLGIJD8GkTVZwr+fKj8qCWkHiWMlu2BUkIWrpUFiwkZ/V2S tMLZBD+mj6YXJ0rwWioWpiOpoB8gXfQD1RYDrSHBA4DtJy/1UhF1VGGHnqk6LnS0nJaG bz/RBc0V4MkJl6bwYHav/I964fuagwwxCkrNYwP3m18sHWO/z0oeLS1BIMVoZLUEgJBR Tttw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:mime-version:list-unsubscribe:list-subscribe:list-id :precedence:references:subject:cc:to:from:dkim-signature :dkim-signature:message-id; bh=HdIXDmhsPUZ2RPLujxzrsxlJ5xE23RHzUivxcwc9L5U=; fh=joBs/8L+orz77ylyCy6wqNwwi35f7sYhLR+/TQjQjhI=; b=VdTn0NRJvgTxemlU57GkEJxUM2Cy2wM7TbiBPLJsa1bFblY3g/Wi3hjXJ5vunAbz8F 9//pb8RQitHY9QBYYqchqhHDpF/KLDdDlplr7SlrDj7P0HBkpMC/QU0/88CNlUZeqzCa H+ZwvbPZzf5pyzmjyZIagmP1+ahZy2RW4Le6YT41ZQTh12iYh0W+GM9+LKElEFBjtsr1 OZSAEyvj6ZnWlP3awWiYldk6IekIklP8hcoW18beJiivILjBUwOLyaJfzMTxa4fP2CXr n/9woDG066PFP6ZxXcDhY/+xg1a4ZWLQDL5ERgo2du8sB0W1Qk5hA/6TdYiv046qHVTH AU9g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YZJxQh1d; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-139503-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l18-20020a170903121200b001e261642385si112280plh.321.2024.04.10.16.04.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 16:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139503-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YZJxQh1d; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-139503-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139503-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5240C28CE84 for ; Wed, 10 Apr 2024 22:57:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CF4B13793A; Wed, 10 Apr 2024 22:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="YZJxQh1d"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="U0MpMRws" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ACA2137920 for ; Wed, 10 Apr 2024 22:47:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712789262; cv=none; b=EmpG5TwvvTBPak7G7nli3OfP0HWI8a+RKX/stGbnew4I6d3btBRKbmrE340hsTIIon/AkYDj48r6z1/X6lVZOUbkvlw/R/vp7P5eR9eLXJfnI9Lo+kCtUfH61JiH2pEdM0WoGv/eWetga50J8FI+R5pj3oMZ+BjarJoUr+iwyks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712789262; c=relaxed/simple; bh=dVOMH7eiDEHVePUyZa4h1ExK1Rjvcqco8G9d9SW/qIU=; h=Message-ID:From:To:Cc:Subject:References:MIME-Version: Content-Type:Date; b=gmAVOXhulHbyYCUQbTCkNwihjluPXmnCeD0//7dGIDBlVKSsRIiDwtNv9Y++JDVWp/Brj4uPZt3YPKKe+6Z8ao9ZUIHjfur86AMLReqivygsEZdbMKAchZLJiSHAvOCkPnEfrxYvHMY91VOhLGoj8A94fvp2M1XaRCqf2a1n/IY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=YZJxQh1d; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=U0MpMRws; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Message-ID: <20240410165554.006264248@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1712789259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HdIXDmhsPUZ2RPLujxzrsxlJ5xE23RHzUivxcwc9L5U=; b=YZJxQh1d7Qif5pxOkRNipZyUppU6m7sWLta6DG+n/0pZ/d3DDBme6w9JKblkxesr2xKRAe NDaUMFmXYwQ9k99YKrz5ayXJsIr9vM4nVNU+Lv3v9p61poxL0/miinJE1MJQfRblI5ZyqN wcjBBnQYDjmBwfv2r6tUVY5XSmGXsrolH68Uj6Jz7l4ZquTNpim7Syda1dmz3LZ9KNni8a hGX+OomHVlNmRnTnMixD78g8r6fkWXWyD1AUGmCHQIHqWjMxOImsSYyjnrgPUQA6On6lD+ 9Py09DDHUzPQMnf1p+2VUU+b9TtySj8Rw+QN2Rr8u753N1WQHpr8KLL7zFIu2A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1712789259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=HdIXDmhsPUZ2RPLujxzrsxlJ5xE23RHzUivxcwc9L5U=; b=U0MpMRwsQqLODerCJMW3g9iewUoFzUAL4LK7s/hdDaIgFg7aH5IFT4KJfnF94R40zLByef hPYWncPcq/ud5NCw== From: Thomas Gleixner To: LKML Cc: Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Peter Zijlstra , Ingo Molnar , Stephen Boyd , Eric Biederman , Oleg Nesterov Subject: [patch V2 49/50] alarmtimers: Remove the throttle mechanism from alarm_forward_now() References: <20240410164558.316665885@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Date: Thu, 11 Apr 2024 00:47:38 +0200 (CEST) Now that ignored posix timer signals are requeued and the timers are rearmed on signal delivery the workaround to keep such timers alive and self rearm them is not longer required. Remove the unused alarm timer parts. Signed-off-by: Thomas Gleixner --- kernel/time/alarmtimer.c | 28 ++-------------------------- 1 file changed, 2 insertions(+), 26 deletions(-) --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c @@ -469,35 +469,11 @@ u64 alarm_forward(struct alarm *alarm, k } EXPORT_SYMBOL_GPL(alarm_forward); -static u64 __alarm_forward_now(struct alarm *alarm, ktime_t interval, bool throttle) +u64 alarm_forward_now(struct alarm *alarm, ktime_t interval) { struct alarm_base *base = &alarm_bases[alarm->type]; - ktime_t now = base->get_ktime(); - - if (IS_ENABLED(CONFIG_HIGH_RES_TIMERS) && throttle) { - /* - * Same issue as with posix_timer_fn(). Timers which are - * periodic but the signal is ignored can starve the system - * with a very small interval. The real fix which was - * promised in the context of posix_timer_fn() never - * materialized, but someone should really work on it. - * - * To prevent DOS fake @now to be 1 jiffie out which keeps - * the overrun accounting correct but creates an - * inconsistency vs. timer_gettime(2). - */ - ktime_t kj = NSEC_PER_SEC / HZ; - if (interval < kj) - now = ktime_add(now, kj); - } - - return alarm_forward(alarm, now, interval); -} - -u64 alarm_forward_now(struct alarm *alarm, ktime_t interval) -{ - return __alarm_forward_now(alarm, interval, false); + return alarm_forward(alarm, base->get_ktime(), interval); } EXPORT_SYMBOL_GPL(alarm_forward_now);