Received-SPF: pass (google.com: domain of linux-kernel+bounces-139546-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Peng Fan <peng.fan@nxp.com>
To: Rob Herring <robh@kernel.org>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
	<conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer
	<s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Topic: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extension
 protocol
Thread-Index: AQHah1U59RmV1LBnZEq28+9F7LvjPrFhx86AgABr+tA=
Date: Wed, 10 Apr 2024 23:47:14 +0000
Message-ID:
 <DU0PR04MB9417B8B6F35D3F0934D205DA88062@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240405-imx95-bbm-misc-v2-v2-0-9fc9186856c2@nxp.com>
 <20240405-imx95-bbm-misc-v2-v2-2-9fc9186856c2@nxp.com>
 <20240410171925.GA564262-robh@kernel.org>
In-Reply-To: <20240410171925.GA564262-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?AIqdLLANQBLXdh+rS09AciJOFuWKULDDYD2S1iocgv0jC9NpYe0LF3VJ6EsF?=
 =?us-ascii?Q?08LtIcPOlUBQGJRfXE+F6Mk0Qto/Sk+H+Fv/WSaoElZ7DAzKYPWtTPjepp4/?=
 =?us-ascii?Q?c7jE0iRWTH54LqIIvFIsRUegDAQMEYz38O4tB/6CdPsHU1VOsNKwE9DKqMiS?=
 =?us-ascii?Q?MA75cp4ujvpboVFUKfC+Ti3VnyqO9yaiyrRun7BGZmzYqohmN6aQifpr3kp2?=
 =?us-ascii?Q?9wVwASj1vYN1AojGf+acQ9rLbjwwFPGPPuvmvVYxvyKn4R3SxyJipgb0Hjku?=
 =?us-ascii?Q?HJiXCnGr6Polm3+EevBmLqU1wBUiRm4BC1aR7zv9nS4RGgQ0q+qd32C7sZ3w?=
 =?us-ascii?Q?udPkOmIgibVEA8HLQVxc2+Nj0P33b8doRXW8sa8L3KT6vrpj4xmY2mLqAAJ9?=
 =?us-ascii?Q?SKBWcbGVayzC03O3xmD62WSAVmpQzYKtLMYm3vEvivtX4QrrMzER+ABmqxxv?=
 =?us-ascii?Q?D5SVaTtSYM4SzIMg9tot1kH4iTmvAZ28WE9sSJiJXqYnObyDR150SF6N6C5o?=
 =?us-ascii?Q?JKdVe+fdwP9cyXkEPmU0b0FJFb/rbDnjPFSiGjncPXr1FRndp01JsxUdBtP9?=
 =?us-ascii?Q?OCaVBAFdRHIkoiYQMsCRxY3mZvWNapKn9QSE7ABxpVohXcPwL/VL108bt9g5?=
 =?us-ascii?Q?O0tCyfhaxKO1/kV0d6/ISZXtBDdi+gG2H5caF9ETFHbPXYhGbSwvjby3mw20?=
 =?us-ascii?Q?vsLV1vHtTM2dsV7cjQid/HZDrPkTV8ysIgcY50Cjxuc8ikz17nB/DvQQ2hPE?=
 =?us-ascii?Q?PgiF20J9DzBF+O+6M0UU4ef7CbtapDskPumdjzUYKv4zLwTujP33/S6/rQsb?=
 =?us-ascii?Q?26S1s6vGr1K1jSv82sBllmuQSMs7aat4AzxkMxo417rCk1yQ4ZznewYlCbMO?=
 =?us-ascii?Q?NzjEJiu2LYn9sltlSV2hxl6PCc+eqoppFOPZZs2I2VlDGul7KTX4e0IwOXM+?=
 =?us-ascii?Q?kuN+bkfH2RMWgYTWDPEJI1oCFnhQuFBAD7tJ4X+Md2f/7880aoyUfXw6Msob?=
 =?us-ascii?Q?1pmCMT5bB2IjLof1YrcnNwVJdNXTLl3eByon09y3kcMf/aQFWPLGSZTlOtyd?=
 =?us-ascii?Q?0LpLV/7q2N7QEU8/hVoRFRJdj5XrTGa7WZ/4D6/yyY20hilE1rMx4QaSbsLr?=
 =?us-ascii?Q?7cmtBEMBXjwLredS48j2+BLYZ+afBeKdoWNgassAAs/z+C/ZquMgHd9WrpCw?=
 =?us-ascii?Q?raDtVgaAVz9pGxR6rvesPicK1GKqG7uSrBLEuJ4t6I7Q5jK/ks0oPet9IhyK?=
 =?us-ascii?Q?5V1W8DIjclOSujW4/tjZunGT4iQiIB9NkKTEaiS13xiyQ0z8ByFBgqobvSwH?=
 =?us-ascii?Q?B42nQ+63++r50tyAUB5mRfVtutS2OEDETN482xkhEnlGiPt0D3Tt2pDC8P7A?=
 =?us-ascii?Q?Z2mGvYrhM/fTXeH7LH72CdJ2qnHR3gbiRP7BUDM8Fwi72KTBSH9YcfBJrnwj?=
 =?us-ascii?Q?FzXpnNPZj69nel0/v8tpa3gFl7CMpLyFf+0XkpyhLv74s5lJ0j/uV76mT3+J?=
 =?us-ascii?Q?479A+uAo2ZrONqyzQoOwNuHyU0u7aawKq+eBxYFahzdHEfNbelf7WOKPe8gB?=
 =?us-ascii?Q?xG9W63gHcFaXrf62VzU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94b8d669-8b7e-4d3e-d616-08dc59b88c90
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2024 23:47:14.6387
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tfAAVYu43rART49F79RIZBwZKXShNxDo4Nku/vafPvDHoNVApipMV8tUDzDZSuyXEI8Iq5Wuqh0KlwKA0UPF/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9182

> Subject: Re: [PATCH v2 2/6] dt-bindings: firmware: add i.MX SCMI Extensio=
n
> protocol
>=20
> On Fri, Apr 05, 2024 at 08:39:24PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add i.MX SCMI Extension protocols bindings for:
> >  - Battery Backed Secure Module(BBSM)
> >  - MISC settings such as General Purpose Registers settings.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  .../devicetree/bindings/firmware/imx,scmi.yaml     | 80
> ++++++++++++++++++++++
> >  1 file changed, 80 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > new file mode 100644
> > index 000000000000..7ee19a661d83
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/firmware/imx,scmi.yaml
> > @@ -0,0 +1,80 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2024
> > +NXP %YAML 1.2
> > +---
> > +$id:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> >
> +cetree.org%2Fschemas%2Ffirmware%2Fimx%2Cscmi.yaml%23&data=3D05%7
> C02%7Cp
> >
> +eng.fan%40nxp.com%7C25c72418c9864a73924808dc59826288%7C686ea
> 1d3bc2b4c
> >
> +6fa92cd99c5c301635%7C0%7C0%7C638483663734828123%7CUnknown%
> 7CTWFpbGZsb
> >
> +3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn
> 0%3D
> >
> +%7C0%7C%7C%7C&sdata=3DY2uSGDorqR9HK8PO4AQDQ%2FaTv%2BETnulvU
> C8u9ktDoio%3
> > +D&reserved=3D0
> > +$schema:
> > +https://eur01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdev=
i
> > +cetree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=3D05%7C02%7Cpeng.fan%40nx
> >
> +p.com%7C25c72418c9864a73924808dc59826288%7C686ea1d3bc2b4c6fa
> 92cd99c5c
> >
> +301635%7C0%7C0%7C638483663734841350%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoiM
> >
> +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7
> C%7C%7
> >
> +C&sdata=3Dh6lSgnPvR88CEBxmU%2B%2FCfCx9GHUrogWVxck38sIdhB4%3D&r
> eserved=3D0
> > +
> > +title: i.MX System Control and Management Interface(SCMI) Vendor
> > +Protocols Extension
> > +
> > +maintainers:
> > +  - Peng Fan <peng.fan@nxp.com>
> > +
> > +allOf:
> > +  - $ref: arm,scmi.yaml#
>=20
> This needs to be the other way around. Add a ref to this file in arm,scmi=
yaml
> under an 'anyOf' entry.

ok, I will give a try.

>=20
> > +
> > +properties:
> > +  protocol@81:
> > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > +    unevaluatedProperties: false
> > +    description:
> > +      The BBM Protocol is for managing Battery Backed Secure Module
> (BBSM) RTC
> > +      and the ON/OFF Key
> > +
> > +    properties:
> > +      reg:
> > +        const: 0x81
> > +
> > +    required:
> > +      - reg
> > +
> > +  protocol@84:
> > +    $ref: 'arm,scmi.yaml#/$defs/protocol-node'
> > +    unevaluatedProperties: false
> > +    description:
> > +      The MISC Protocol is for managing SoC Misc settings, such as
> > + GPR settings
> > +
> > +    properties:
> > +      reg:
> > +        const: 0x84
> > +
> > +      wakeup-sources:
> > +        description:
> > +          Each entry consists of 2 integers, represents the source and=
 electric
> signal edge
> > +        items:
> > +          items:
> > +            - description: the wakeup source
> > +            - description: the wakeup electric signal edge
>=20
> No constraints on the entry values?

I will change the property name to imx,wakup-sources with constraints
minItems: 1
maxItems: 32.

>=20
> > +        $ref: /schemas/types.yaml#/definitions/uint32-matrix
> > +
> > +    required:
> > +      - reg
> > +
> > +additionalProperties: false
>=20
> And then this can be true.

Fix in v3.

Thanks
Peng.

>=20
> Rob