Received-SPF: pass (google.com: domain of linux-kernel+bounces-139549-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240409235000.1893969-1-namhyung@kernel.org> <20240409235000.1893969-4-namhyung@kernel.org>
 <Zhb0raj1yW8JhuFW@x1> <Zhb-17CrgZt_PdUH@x1> <Zhb_F6hvWrjMcoM1@x1>
 <ZhcAvddbSEcMXzvH@x1> <ZhcB2Vh6lAcqPasI@x1> <ZhcCgzslBmDK4-vn@x1> <ZhcFXm9a2fzNeZwm@x1>
In-Reply-To: <ZhcFXm9a2fzNeZwm@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 10 Apr 2024 16:49:52 -0700
Message-ID: <CAM9d7cgz52wYFh16o9053OimT_Np11bfxLYGBWW9VnEqb_djsA@mail.gmail.com>
Subject: Re: [PATCH 3/6] perf annotate-data: Add hist_entry__annotate_data_tui()
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>, 
	Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 2:32=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Wed, Apr 10, 2024 at 06:20:06PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Wed, Apr 10, 2024 at 06:17:16PM -0300, Arnaldo Carvalho de Melo wrot=
e:
> > > On Wed, Apr 10, 2024 at 06:12:32PM -0300, Arnaldo Carvalho de Melo wr=
ote:
> > > > On Wed, Apr 10, 2024 at 06:05:27PM -0300, Arnaldo Carvalho de Melo =
wrote:
> > > > > On Wed, Apr 10, 2024 at 06:04:26PM -0300, Arnaldo Carvalho de Mel=
o wrote:
> > > > > > On Wed, Apr 10, 2024 at 05:21:01PM -0300, Arnaldo Carvalho de M=
elo wrote:
> > > > > > > On Tue, Apr 09, 2024 at 04:49:57PM -0700, Namhyung Kim wrote:
> > > > > > > > Support data type profiling output on TUI.
> > > > > > >
> > > > > > > Added the follow to the commit log message, to make reviewing=
 easier.
> > > > > > >
> > > > > > > As followup patches I think having the DSO name together with=
 the type
> > > > > > > is important, also I think we could have a first menu with al=
l the pairs
> > > > > > > of DSO/type, sorted top down by the types with most samples, =
wdyt?
> > > > > > >
> > > > > > > Applied.
> > > > > > >
> > > > > >
> > > > > > There is something else here with the static build, checking...
> > > > >
> > > > > Probably because of:
> > > > >
> > > > > Makefile.config:810: slang not found, disables TUI support. Pleas=
e install slang-devel, libslang-dev or libslang2-dev
> > > > >
> > > > > Fixing...
> > > >
> > > > Trying with:
> > >
> > > Not really, I need to check for HAVE_DWARF_SUPPORT as well? Doing tha=
t
> >
> > Attempting with:
>
> Nope, the surgery needed is a bit bigger, as you made
> hist_entry__annotate_data_tty dependent on DWARF but calls it without
> checking HAVE_DWARF_SUPPORT from builtin-annotate.c.
>
> I put what I have in tmp.perf-tools-next, please take a look, I'll
> continue  tomorrow.

Oops, thanks a lot for fighting with this.  I think I can add a
dummy version in case it doesn't have the slang support.
I'll send v2 including all your other improvements.

Thanks,
Namhyung