Received-SPF: pass (google.com: domain of linux-kernel+bounces-139587-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240409235000.1893969-1-namhyung@kernel.org> <20240409235000.1893969-6-namhyung@kernel.org>
 <Zhb6jJneP36Z-or0@x1> <Zhb7pPySSGnIU3bO@x1>
In-Reply-To: <Zhb7pPySSGnIU3bO@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 10 Apr 2024 17:30:46 -0700
Message-ID: <CAM9d7choZ7WQXa_+RWm-eODjah+k_A5T3eSFXWFYRqTO5euyxg@mail.gmail.com>
Subject: Re: [PATCH 5/6] perf report: Add a menu item to annotate data type in TUI
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Ian Rogers <irogers@google.com>, Kan Liang <kan.liang@linux.intel.com>, 
	Jiri Olsa <jolsa@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, 
	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, 
	LKML <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 1:50=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> (gdb) bt
> #0  0x00007ffff6ebd385 in __GI___libc_free (mem=3D0x69647225202c3866) at =
malloc.c:3368                                                              =
                                            =E2=96=92
> #1  0x000000000066c2c0 in delete_data_type_histograms (adt=3D0x8dedf0c0) =
at util/annotate-data.c:1655                                               =
                                            =E2=96=92
> #2  0x000000000066c363 in annotated_data_type__tree_delete (root=3D0xe6bc=
68) at util/annotate-data.c:1669                                           =
                                            =E2=96=92
> #3  0x0000000000553bc5 in dso__delete (dso=3D0xe6bbd0) at util/dso.c:1376=
                                                                           =
                                            =E2=96=92
> #4  0x0000000000553d63 in dso__put (dso=3D0xe6bbd0) at util/dso.c:1409   =
                                                                           =
                                            =E2=96=92
> #5  0x000000000057ed76 in __dso__zput (dso=3D0xf5b540) at util/dso.h:262 =
                                                                           =
                                            =E2=96=92
> #6  0x000000000058027e in map__exit (map=3D0xf5b520) at util/map.c:300   =
                                                                           =
                                            =E2=96=92
> #7  0x00000000005802bc in map__delete (map=3D0xf5b520) at util/map.c:305c=
ord -b ... ; perf report --total-cycles                                    =
                                            =E2=96=92
> #8  0x0000000000580325 in map__put (map=3D0xf5b520) at util/map.c:312
> #9  0x00000000005818aa in __map__zput (map=3D0xf3e300) at util/map.h:196
> #10 0x0000000000582241 in maps__exit (maps=3D0xf5aee0) at util/maps.c:246
> #11 0x000000000058233c in maps__delete (maps=3D0xf5aee0) at util/maps.c:2=
68
> #12 0x00000000005823fd in maps__put (maps=3D0xf5aee0) at util/maps.c:285
> #13 0x000000000055c4ca in __maps__zput (map=3D0x47856d8) at util/maps.h:3=
2
> #14 0x000000000055c55f in map_symbol__exit (ms=3D0x47856d8) at util/map_s=
ymbol.c:8
> #15 0x00000000005c36bf in hist_entry__delete (he=3D0x4785660) at util/his=
t.c:1319
> #16 0x00000000005c1049 in hists__delete_entry (hists=3D0xe68fe0, he=3D0x4=
785660) at util/hist.c:382
> #17 0x00000000005c1197 in hists__delete_entries (hists=3D0xe68fe0) at uti=
l/hist.c:410
> #18 0x00000000005c7a4d in hists__delete_all_entries (hists=3D0xe68fe0) at=
 util/hist.c:2872
> #19 0x00000000005c7ac7 in hists_evsel__exit (evsel=3D0xe68d70) at util/hi=
st.c:2884
> #20 0x0000000000531928 in evsel__exit (evsel=3D0xe68d70) at util/evsel.c:=
1489
> #21 0x000000000053196d in evsel__delete (evsel=3D0xe68d70) at util/evsel.=
c:1497
> #22 0x0000000000526a70 in evlist__purge (evlist=3D0xe67a00) at util/evlis=
t.c:163
> #23 0x0000000000526b7d in evlist__delete (evlist=3D0xe67a00) at util/evli=
st.c:185
> #24 0x0000000000585fd8 in perf_session__delete (session=3D0xe670a0) at ut=
il/session.c:313
> #25 0x0000000000434503 in cmd_report (argc=3D0, argv=3D0x7fffffffe430) at=
 builtin-report.c:1828
> #26 0x00000000005062c3 in run_builtin (p=3D0xe3f160 <commands+288>, argc=
=3D3, argv=3D0x7fffffffe430) at perf.c:350
> #27 0x0000000000506532 in handle_internal_command (argc=3D3, argv=3D0x7ff=
fffffe430) at perf.c:403
> #28 0x0000000000506681 in run_argv (argcp=3D0x7fffffffe21c, argv=3D0x7fff=
ffffe210) at perf.c:447
> #29 0x0000000000506978 in main (argc=3D3, argv=3D0x7fffffffe430) at perf.=
c:561
> (gdb)
>

Thanks for the report.  I think I missed stack canary not handling
histogram updates.  The data file I tested with TUI didn't have an
entry for stack canary so I didn't catch this.  For some reason, I
still cannot reproduce it on my box.  Anyway I will fix in v2.

For the verification, it'd be nice if you can print the type name
in the delete_data_type__histogram().

  (gdb) p adt->self.type_name


Thanks,
Namhyung