Received-SPF: pass (google.com: domain of linux-kernel+bounces-139589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 08:36:37 +0800
From: Chen Yu <yu.c.chen@intel.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
CC: <linux-efi@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>, Chao Gao
	<chao.gao@intel.com>, <linux-kernel@vger.kernel.org>, "Hossain, Md Iqbal"
	<md.iqbal.hossain@intel.com>
Subject: Re: [PATCH] efi/unaccepted: touch soft lockup during memory accept
Message-ID: <ZhcwlY+W54aTe1d8@chenyu5-mobl2>
References: <20240410102301.634677-1-yu.c.chen@intel.com>
 <btc6xpiw3kvo4tj6a7cn7uahvcvge7g3jqkutrwmlnuz6g55lr@fu3lsytwhfpy>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <btc6xpiw3kvo4tj6a7cn7uahvcvge7g3jqkutrwmlnuz6g55lr@fu3lsytwhfpy>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lYR0BydquNlii+r3BGuwkNH6x7suhzI8EAdpjGpQpBSOIYSWh7QchZU7pbDE?=
 =?us-ascii?Q?oEXrmTfXo0ukCTIQsQG6urZwfjfI7SBH2e6xHfrsQ4OOoiGMyoCql+zCh+y1?=
 =?us-ascii?Q?1TbaKSdnybqes/1qWHRxgq6zAmlNHVfBeNszPr+Bf1oGwnGD5HuEfAQjXujB?=
 =?us-ascii?Q?t6UMfX5pHLtb78UiGZWnEi5+1VawLgu+AzF3Qg4HQu9p7oesZwot25yBZV1U?=
 =?us-ascii?Q?qpt/DuIhPTL/zn+n27LCQCT4WHtsuaHmouTQDUolUdJNWmCKS2vhlpB4FhPi?=
 =?us-ascii?Q?dBTfAi35OLGKHOEQnGfiUM6G+JXjUphjDoMfTyUDo+MgsX2Tjl2Sm/cCHkzp?=
 =?us-ascii?Q?ULM15NoJK7I9fHAdkRH14vlLkYv6WkSB9AimOg8LJGKENClzBrfOPVOeZ+TZ?=
 =?us-ascii?Q?dwwz0ELRquT67aruuED8RWaFQItbgWZMimxZqqlaZhmUbbCSe4BhGPuV9ZhV?=
 =?us-ascii?Q?zxbfSAX4BR1Jl7Ytfxq6sZI/IKiKwt/B9i4xg/BLDE7TfZeDVsH3Ad8CR0z7?=
 =?us-ascii?Q?YwKKSXqxAiXSin6rupDEXHOYn9myaFMNMSs68N20G0INFtJ+o/hSLw/+vC/y?=
 =?us-ascii?Q?OJ+Yxk9DGhNUnQ/yaHN+T1EoHBd36jrTEwJgA4Yl10/awo9rLiIbE4GJ5a5f?=
 =?us-ascii?Q?EGDWFymgsKa6asnnygwxH+7PPaupnzacpEsTcFNj/KdL6eYh5WXKEOwARZp4?=
 =?us-ascii?Q?Ilnc1WE4hkTxLj7FHUzM0igjzh1SFDRCeog1wlL+mLfcL9efIcUpAF8+3s96?=
 =?us-ascii?Q?aOj8gBQk8PJYBPUzYBXrjqRLQLZHW+HaAsZVuTyFoM9oqWoHPFYfpVGCTU4Y?=
 =?us-ascii?Q?NJ4okaYtcWcPHOz39cHcvuZSVIYNdxsf8fBmLwyDd37Axu3ccpZRhcS+l3KZ?=
 =?us-ascii?Q?KobalDidkkIYw9mnFylZZYYUGp/bqOSqQ1coVJFCsLZyWxq/GlBbBN+pRXAU?=
 =?us-ascii?Q?trtSRbO0gkJe/+/lVJrSuln8PGK8bV8C8fvmvAi6JJWz6ZqK1VLq6ZYfVDNE?=
 =?us-ascii?Q?ij9pC4CnJdo8tdr57lAmaRF9Ozuo/Xb7fHOuEWGuUZkspGDSKjJpUm5TiJc+?=
 =?us-ascii?Q?JwYupMK3c44M5H4ujaXmAvKsn1JkLol40GQsXhGnERX+o5dhsCVjzaZQsmXC?=
 =?us-ascii?Q?zgUT96xXhiIhL+M2z2LJmTt6OY+iJ4d+igrFHvXJhcbit1DroapGPoP1y2Ot?=
 =?us-ascii?Q?VylgfkhWpFNUw4kELE3Lwb9eJokfYwRIK7YNaUjY7Yymn6nWFLQT6ONcjc1A?=
 =?us-ascii?Q?hbgQnc+VbM4UZpyeaAeRQPgWV39A8GaNhi6r9H042XCR4daG9wDI0lmLVOU2?=
 =?us-ascii?Q?VJu/TPxl2qYC6PrTaxQf5RvcY1R7eir5JAmNCAqNS4PKksvruhJbFLZZcB/p?=
 =?us-ascii?Q?FBOap+FymaDjQEW/hmjirFz/1ElkLVpLmNDlfSkCztq985Q1Tw2mjLuH3Fe7?=
 =?us-ascii?Q?jRf0neDq63bfaqVfJiLZvDXxkwYVCJQPlKFLmIIEOlKRAfqlSFCtkOR4N1K0?=
 =?us-ascii?Q?khKNCjk0KT9GTd77xHGd10jwFU1Kk8fLO3gIFLXMiVXpX5HvKPCZ+2oAEMlY?=
 =?us-ascii?Q?GkRLOadnlupIJ8d+oESpkYhJ41hi02Kb7SaTO1JA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13873b8a-7207-4ab9-f3b2-08dc59bf7714
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 00:36:45.3231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RRUzG5O4dwwfoSeHLYR9tw+yep/R/EQ0d00Pv8A+sFYdolt5h2mofvYJZgAtvNlMQVscdkeiu6ltxt6yXTyvkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4817
X-OriginatorOrg: intel.com

On 2024-04-10 at 15:35:39 +0300, Kirill A. Shutemov wrote:
> On Wed, Apr 10, 2024 at 06:23:01PM +0800, Chen Yu wrote:
> > Commit 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused
> > by parallel memory acceptance") has released the spinlock so
> > other CPUs can do memory acceptance in parallel and not
> > triggers softlockup on other CPUs.
> > 
> > However the softlock up was intermittent shown up if the memory
> > of the TD guest is large, and the timeout of softlockup is set
> > to 1 second:
> > 
> >  RIP: 0010:_raw_spin_unlock_irqrestore
> >  Call Trace:
> >  ? __hrtimer_run_queues
> >  <IRQ>
> >  ? hrtimer_interrupt
> >  ? watchdog_timer_fn
> >  ? __sysvec_apic_timer_interrupt
> >  ? __pfx_watchdog_timer_fn
> >  ? sysvec_apic_timer_interrupt
> >  </IRQ>
> >  ? __hrtimer_run_queues
> >  <TASK>
> >  ? hrtimer_interrupt
> >  ? asm_sysvec_apic_timer_interrupt
> >  ? _raw_spin_unlock_irqrestore
> >  ? __sysvec_apic_timer_interrupt
> >  ? sysvec_apic_timer_interrupt
> >  accept_memory
> >  try_to_accept_memory
> >  do_huge_pmd_anonymous_page
> >  get_page_from_freelist
> >  __handle_mm_fault
> >  __alloc_pages
> >  __folio_alloc
> >  ? __tdx_hypercall
> >  handle_mm_fault
> >  vma_alloc_folio
> >  do_user_addr_fault
> >  do_huge_pmd_anonymous_page
> >  exc_page_fault
> >  ? __do_huge_pmd_anonymous_page
> >  asm_exc_page_fault
> >  __handle_mm_fault
> 
> Stacktrace doesn't add much value here. Just drop it.
>

OK, will do.
 
> > When the local irq is enabled at the end of accept_memory(),
> > the softlockup detects that the watchdog on single CPU has
> > not been fed for a while. That is to say, even other CPUs
> > will not be blocked by spinlock, the current CPU might be
> > stunk with local irq disabled for a while, which hurts not
> > only nmi watchdog but also softlockup.
> > 
> > Chao Gao pointed out that the memory accept could be time
> > costly and there was similar report before. Thus to avoid
> > any softlocup detection during this stage, give the
> > softlockup a flag to skip the timeout check at the end of
> > accept_memory(), by invoking touch_softlockup_watchdog().
> > 
> > Reported-by: "Hossain, Md Iqbal" <md.iqbal.hossain@intel.com>
> > Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> 
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> 
> And I think it is justified to add Fixes tag:
> 
> Fixes: 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused by parallel memory acceptance")
>

OK, I'll refine the patch and send v2, thanks!


thanks,Chenyu