Received: by 2002:ab2:3350:0:b0:1f4:6588:b3a7 with SMTP id o16csp748928lqe; Sun, 7 Apr 2024 01:59:13 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU0LEreb8bYEs7voIVpl+8dSnF6pjnQeg8M9TEOE3eUliwUfrGwbr7G7V85zgb8lBS86+7GtPHnIj9LZ5vY3OVSsYcF56yAkARNhZqfuQ== X-Google-Smtp-Source: AGHT+IHQoftbcDUwKeMEKlOW2QltmOGRKnq9o3zPDe7EZuvtrMGAo+Rr+E628SIAxckF8YaFElwp X-Received: by 2002:a05:622a:188e:b0:431:4eb6:32fa with SMTP id v14-20020a05622a188e00b004314eb632famr7092763qtc.46.1712480353617; Sun, 07 Apr 2024 01:59:13 -0700 (PDT) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o17-20020a05622a139100b00434587753a0si5855403qtk.119.2024.04.07.01.59.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Apr 2024 01:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-134270-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@proton.me header.s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail header.b=W4KM894T; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-134270-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-134270-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=QUARANTINE) header.from=proton.me Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 578321C206A2 for ; Sun, 7 Apr 2024 08:59:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B8CC12B7D; Sun, 7 Apr 2024 08:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=proton.me header.i=@proton.me header.b="W4KM894T" Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A76DC125A9 for ; Sun, 7 Apr 2024 08:59:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.134 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712480348; cv=none; b=L4zfaI7lFPhEVhp2f5CZPCQQomyh0fHlRDySEv6w110GRla5iLUXDGETbO3Gr7Z1suRyMDeOJeVJAEkjd3aoQ8X8mOTlsWJrfn0OvjJvxlwA/XrAeiXFHGkHU2Ny3113F3bKUHRScvTwv12K0jl3Tq5OXN/4MX4gWYbEwfMYLSE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712480348; c=relaxed/simple; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rgqUyD0Y7R7KP3gdt6F3f4M1yAYjKsYe5Wd4rU4OWVju5Rsc3higeBHDjfW3UuC+DhK1XCuZcvJugOYimhcsy7cxnSu6QE2KaN8pqu7F4z+WMLejx2JejkINvPiQDCCNjOflv5noDAC7t0qFnYElypgjuVt6c4eCfW9JdWqNf+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me; spf=pass smtp.mailfrom=proton.me; dkim=pass (2048-bit key) header.d=proton.me header.i=@proton.me header.b=W4KM894T; arc=none smtp.client-ip=185.70.40.134 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=proton.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=proton.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail; t=1712480338; x=1712739538; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=W4KM894T30Nvu/5Jg8f5a0pedkYEE9Ylz9e18LTSxXUYXznis8BometXs7Yrf7al6 SU7+lWst6jQZdOOyRDFBM4ps0WD/pkIt0cuSbgU/hFttyxhj/p200c9O7D+XSdfb2S uBHSq2l8JFwrOVb0vV5qUJJBwELvvFxrP+TIly1xKnw+TtGeonf4Nbe6+WS5Hbxw+K yUf4ubNEklQZ6OhSeku5G9NqwLaSOlliVdOFsQfQ9jMqApNkCEYE6SaYH1ys5XNRdZ QWtDcR6Vmwyy/qSS+nnNS6xXzmjxAq4y124thVRZB8Agf5UZkjV6GOdNCMWsht4a4D caZhhArNRMktA== Date: Sun, 07 Apr 2024 08:58:50 +0000 To: Alice Ryhl From: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page` Message-ID: In-Reply-To: References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> Feedback-ID: 71780778:user:proton Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05.04.24 09:44, Alice Ryhl wrote: > On Fri, Apr 5, 2024 at 12:33=E2=80=AFAM Benno Lossin wrote: >> >> On 04.04.24 14:31, Alice Ryhl wrote: >>> +/// A bitwise shift for the page size. >>> +#[allow(clippy::unnecessary_cast)] >> >> Why can't you remove the cast? >=20 > Bindgen could decide to use a different type in the future or on > different platforms. Did that already happen? I think that we might want to know if the type changes, since then the value might change? --=20 Cheers, Benno