Received-SPF: pass (google.com: domain of linux-kernel+bounces-132778-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 5 Apr 2024 10:54:22 +0100
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Dawei Li <dawei.li@shingroup.cn>
CC: <will@kernel.org>, <mark.rutland@arm.com>, <yury.norov@gmail.com>,
	<linux@rasmusvillemoes.dk>, <xueshuai@linux.alibaba.com>,
	<renyu.zj@linux.alibaba.com>, <yangyicong@hisilicon.com>,
	<andersson@kernel.org>, <konrad.dybcio@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v3 07/10] perf/hisi_pcie: Avoid placing cpumask on the
 stack
Message-ID: <20240405105422.00006352@Huawei.com>
In-Reply-To: <20240403155950.2068109-8-dawei.li@shingroup.cn>
References: <20240403155950.2068109-1-dawei.li@shingroup.cn>
	<20240403155950.2068109-8-dawei.li@shingroup.cn>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Wed, 3 Apr 2024 23:59:47 +0800
Dawei Li <dawei.li@shingroup.cn> wrote:

> In general it's preferable to avoid placing cpumasks on the stack, as
> for large values of NR_CPUS these can consume significant amounts of
> stack space and make stack overflows more likely.
> 
> Use cpumask_any_and_but() to avoid the need for a temporary cpumask on
> the stack.
> 
> Suggested-by: Mark Rutland <mark.rutland@arm.com>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>