Received-SPF: pass (google.com: domain of linux-kernel+bounces-139615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <CAEkJfYOs-szTK0rYvDw5UNGfzbTG_7RvjqFOZA=c6LXvxdUt2g@mail.gmail.com>
 <CAEkJfYMcdmXAhe9oTpEPGL+_661PNAvM58Y+irwnbLW8FKohNw@mail.gmail.com> <2d5e3b6c-3a66-4f74-8367-51fa55bf0a1a@acm.org>
In-Reply-To: <2d5e3b6c-3a66-4f74-8367-51fa55bf0a1a@acm.org>
From: Sam Sun <samsun1006219@gmail.com>
Date: Thu, 11 Apr 2024 09:17:48 +0800
Message-ID: <CAEkJfYMcLycLfaRzhn=DmQjAuLHn29wSXN0b0Zf0oJr=sDVBTg@mail.gmail.com>
Subject: Re: [Bug] UBSAN: shift-out-of-bounds in sg_build_indirect
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, 
	martin.petersen@oracle.com, jejb@linux.ibm.com, dgilbert@interlog.com, 
	syzkaller@googlegroups.com, xrivendell7@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 10, 2024 at 12:59=E2=80=AFAM Bart Van Assche <bvanassche@acm.or=
g> wrote:
>
> On 4/9/24 05:51, Sam Sun wrote:
> > We further analyzed the root cause of this bug. In function
> > sg_build_indirect of drivers/scsi/sg.c, variable order of line 1900 is
> > calculated out using get_order(num), and num comes from
> > scatter_elem_sz. If scatter_elem_sz is equal or below zero, the order
> > returned will be 52, so that PAGE_SHIFT + order is 64, which is larger
> > than 32 bits int range, causing shift-out-of bound. This bug is tested
> > and still remains in the latest upstream linux (6.9-rc3).
> > If you have any questions, please contact us.
>
> Thank you for having root-caused this issue and also for having shared
> your root-cause analysis. Do you perhaps plan to post a patch that fixes
> this issue?
>
> Thanks,
>
> Bart.
>

Sure, I am glad to help! But it is my first time submitting a patch, I
need to find some instructions. I would appreciate if you could help
me out. Also, I need to double check the patch to avoid introducing a
new one. It might take some time.

Best,
Yue