Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp126425lqg; Wed, 10 Apr 2024 18:45:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX1z2LcZ67AhOgpUsiOlNc2uFRAGb5H71LODNpVs6eTcMjPK5Ab72NNwDWCUV2P+yzet4MqwF3ilt6/NR2OdO9EdVHq1WI7+j0v1C2aQg== X-Google-Smtp-Source: AGHT+IGLKNPwBa5QisKfwVWZeKDO2qsw324zawWVMl9X1+K4BGX8krdyM6mAjtgecOxedYAFzWD0 X-Received: by 2002:a05:6a00:14c1:b0:6ed:973d:936 with SMTP id w1-20020a056a0014c100b006ed973d0936mr4876724pfu.9.1712799959524; Wed, 10 Apr 2024 18:45:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712799959; cv=pass; d=google.com; s=arc-20160816; b=yd/b5qNKoJBE5M+wFMoGhwmzTog1ETTP8H8queQ0fFvcsQLsENzRiFQ+w+BFsH3rog CRdXWfNZGdBgUtjiwXMx+G3lezrnplaH3JBhqtOFkQCvOYR3l38X7W5S5eQgrUES2iRM QWgwrdcjuDIGmwZ8ztrfPFTYnqgM7d6GxH8W9Wa/iHjGfWt1r5vPachzhYtjwrCW7T9y fl3iMy2QtZkqswQwGNsTsB0fAtETZ4HV8dhoSlh2OqGYFAQzu3qKjoKj52YiHplHl1yg oAvFQNJYuIWKGzapg3i6tA4jyKcpT6L/ODml6VmbEoEO3q91lKETSiE65NVGkKZkGrV/ KZ3w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=UaqR2TRyL/KlRQTADiPWxvs69y75ijF2SSwiBYUK9Ik=; fh=jlAqRH2z+jgxdbA24wUf8Zm+/RZmCK/U1PBlc/DHOgI=; b=b4VCNk5rI7LfwYu5TVnKqH4QcmXMSISi7ccQzYJtrrWR3na7sHNTzPJ3qtaMMrbdO8 4qxaXrtVUnBO8lmE+++odq+VShQ4Ib7nPle2MQcmP0Wr47C4mar1oPDZD75vnOLnTJbe QmX3GgExhgZ3bm3UfxrEQrTUUcjYYZBBGjk5TRcQnfUrA7x1xSZKXCMw2GqHzr2ZglEh ThMWtl4A9davY2hgdfzn9ZdXPrRo+M71Na0ZOO+R5GnO5Eu1owZgyb8by/cumhMGVYee iWX3gTyX5II97iNO5rAXkQT2IplebqanLc3G9ruKTxjW36Y7vAiPYf9bl6jukZfI1zlw 2DZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=syKWPlVB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139639-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139639-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i31-20020a63221f000000b005dc81a6b2c9si311357pgi.666.2024.04.10.18.45.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 18:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139639-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=syKWPlVB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139639-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139639-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1CAB4287557 for ; Thu, 11 Apr 2024 01:45:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 043FC627E2; Thu, 11 Apr 2024 01:45:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="syKWPlVB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 266AE79DC; Thu, 11 Apr 2024 01:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712799951; cv=none; b=pkZDruTYrwoeXYAnc509bj1OJP91Ffp3EUfPtoCK2szY1hxULEI2oAq+DGevrX4mApaj0IasYO3ObJupbDxbmf+yWKfPYquPeYNvhs+uvggMF1Ys5o5qE2dWQxa3XeNGX8KfPllEgXghntkwEg+UMNNxK1U50eXUPwodS3qoHD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712799951; c=relaxed/simple; bh=96JPsyovHm70cO+dYlyEAybI9z60jEL3XL8FpVSQQQc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=omQjsJD6mdjIzrzZiuAyuhswoYldDuAKYaXNPns2E5z0KOO5IYiowZOev720GkJ3DcN3gSPPcXIjwmyNT9d2FRzXVjUENvk7zxJqo9YIV4+hkxB6ksztXv2MI7f57LjTDliX4WTg62tenCub46aW2+jj6d+jEuPDPptcmA93WPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=syKWPlVB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50F16C433F1; Thu, 11 Apr 2024 01:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712799950; bh=96JPsyovHm70cO+dYlyEAybI9z60jEL3XL8FpVSQQQc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=syKWPlVBgVOF1VvO1O9a91ej57SnGUP82id2usB9LXZt32Fk2T9norGprxc/1W9ua ARt8pw+yWBictAqdKx2eXHH634nYa0CToKSd+VbCgXmvv861AxXLo3D+Al1q7ZGkSn kTnxbukvVVCCdjkREtXVYJTI104h0lGZ+thvm/7zQsL+g01w3ojC6UihRZBfO3gyCI UlTMZCFC0qcPL8HO+exdDYRJcx/zBONUc4Aq/rjx1KVmp/7/R1QQCiworMMMlWK5W4 u2JmgCAegfDsy8qDpLOpIDwL3Ea/LCv7A+fmRhEP/oJTJmmenpJiimbDCcghydChmz iwIB8vcFRFQfQ== Date: Wed, 10 Apr 2024 18:45:49 -0700 From: Jakub Kicinski To: Breno Leitao Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 4/4] net: dqs: make struct dql more cache efficient Message-ID: <20240410184549.5e5f77f2@kernel.org> In-Reply-To: References: <20240408172605.635508-1-leitao@debian.org> <20240408172605.635508-5-leitao@debian.org> <20240409172149.6f285b68@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 10 Apr 2024 06:52:56 -0700 Breno Leitao wrote: > > Doesn't this move the cache line bouncing problem to the other side? > > I think so. Looking at dql_check_stall(), it only uses fields in the > second cache line, except now 'dql->stall_thrs' that is in the first > cache line. We do read num_queued at the beginning of dql_completed(). So maybe we we move the read of the threshold there we will be fine.