Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp136691lqg; Wed, 10 Apr 2024 19:18:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUlT/IOg0GN/54BcjUKxUAhSGWcgjqEDKC7IQIsSRiUdRATKSz4kda3od7hCrdT26gzF+MHQXN87XQUA11AqoqlECGfCnA07Tcq4QlRmg== X-Google-Smtp-Source: AGHT+IHgTq8aQ7qG0Q6A64hBWcnyA5bGHFlULRfuF94fCNLKbjd+T3j6wF0qp1eqk/VyX7cp173M X-Received: by 2002:a05:6a21:3b4a:b0:1a7:84e8:8037 with SMTP id zy10-20020a056a213b4a00b001a784e88037mr5691065pzb.41.1712801919615; Wed, 10 Apr 2024 19:18:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712801919; cv=pass; d=google.com; s=arc-20160816; b=KmL6qz5gmTc/QQ17D4uiaOvFvrGhXlfZAkxfYNUQmGnEL9c8dHGvR7vSqCnrtSbf89 nnRTPVwRcd+FLDz/LjpggRAwpBVjxhhlZwCqzZNK4fYH5ShuMRQbXeW9/ip13HIT/xgo +wGNtblvuHa0WlnMvdDA9LSAOw1+7IdJuI6OiVsp8qCfr6NToYfIIjENE47JzIp1AY6n S8KuBoZfOiWTW4pnb8KnJax6fchHGMPt+nkaFMGrizciiDgXTPqHVMt+dCeCT7Uxfxwh OzjTp0nYktt0kBnDBFWOJ1R4TmtEVVo9+MOdDYUToBr3YpHtBWizBLcMvtWamgglJNqs 0QgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TP9zUgSe0wsLdvk6LJpioiSOfrL68NakoGrm4RdN0Pk=; fh=4gPSYPuVVZBa/vNK8Mih0lUKM1iDVcJhVvB6zLmx6Hk=; b=BJpTUPxkpuExqCBbTmuPLSwmTGqH6d5J7MSMrrMcQ0YKW1FxB4j6lsiijP0lXWmACS D95u2aSWfOrW0kGzbier+p6P1FsZjctkUQsOwzwhAv9YgOr1LEpZZD9SEUbBRRTJxljo 9/kejvMZd3H6VGyslQVtUuY965RmBCxA1m9A0/1iyYl5aZ9ygLypglOiIS9Nn4BsjNKQ uVF5FLLukgg1zzk7xyeCubQflp4umHGFraG7NWFcffTFatFUosUu/z/5XloVDlTo3UaB DfalGiq8NTNsYm5IUmPYkrl4m8ONMKuHrTVR2jHgUDOot2LKn21xkH5+t697Rzsf+wLB 0ncA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sriAHo9A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139647-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q5-20020a170902bd8500b001e462e3dde8si357199pls.244.2024.04.10.19.18.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 19:18:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sriAHo9A; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139647-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139647-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 31647284B8C for ; Thu, 11 Apr 2024 02:18:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6826264CD0; Thu, 11 Apr 2024 02:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sriAHo9A" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A1A6217D; Thu, 11 Apr 2024 02:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712801912; cv=none; b=QSryDWWwFsSsgTDhaVEXzk6F0sT5qxnyj0GaW/Q7cDYSRuJaE7eDrgThf5LQVBYhVh174SCivjSbG8/FnpMo/KXuZip5Sm8FYFHsADywmQ21OEDBzK54Z7Nu07ImluCcPEtOZSgbD1ftIr88mYRtYa0gVMFGK/osWHuqrppYgjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712801912; c=relaxed/simple; bh=3szFjZcS6dYXoKzbbtos+AFGu/s1GpsB7xiQE6oD8jU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uls0dtWL6SmpQOes+2ghrk8MFoejUBYdkuxOtQnqQaAPUdP92SDlCnhcYUiaGiJA8XuaZ2CoHY9UKC49F4adSC2u9PP1oS8QIj25BJJKjpcp+k3VP6nBe9BATDD0t27NbDOF+xSW48IEGRnROqYjw1/N7lbV3s9DQmfC3rw6Fek= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sriAHo9A; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5246C433F1; Thu, 11 Apr 2024 02:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712801912; bh=3szFjZcS6dYXoKzbbtos+AFGu/s1GpsB7xiQE6oD8jU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sriAHo9AyKBRDBbME148MrgeGc+XAFLNXaBA2iJGz1i/F2ai617j3Wc/LvKpb4YqD AB+2WjiKXXYAcnSd5p0zf3IcHKp/aLrvh+omWR5qzlvJYSldgOQmEnsdK2tFgETlxq laX2XwlOj9es6QUdpYF9H+RtdZNo96gPnUh+VQrBkQ/1TExOdrgI/1UcJkL2uSLDpe IDHJ+v0raqSsza1tbHGmRIbhD0D/M1A77SjOL7dwOS6MYkzxa2n6WFkC3u+yVP2q+b VdWoeaFle0BmlTFkbW1qpwB/0S400SkECDltz/nblEkH6IKrLTG8RuopScdBDKWipi Kj5jrpXyIJ2ug== Date: Thu, 11 Apr 2024 10:18:27 +0800 From: Tzung-Bi Shih To: Noah Loomans Cc: Guenter Roeck , Bhanu Prakash Maiya , Benson Leung , Guenter Roeck , Robert Zieba , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] platform/chrome: cros_ec_uart: properly fix race condition Message-ID: References: <20240410182618.169042-2-noah@noahloomans.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Apr 11, 2024 at 12:06:33AM +0200, Noah Loomans wrote: > On 2024-04-10 at 21:48 UTC+02, Guenter Roeck wrote: > > On Wed, Apr 10, 2024 at 11:29 AM Noah Loomans wrote: > > > This is my first time contributing to Linux, I hope this is a good > > > patch. Feedback on how to improve is welcome! > > > > The commit message is a bit long, but the patch itself looks good to me. > > Hmm yeah it's a bit on a long side. I'm not sure what could be removed > though, it all seems relevant for understanding the bug and the fix. Applied with shortening the message slightly.