Received-SPF: pass (google.com: domain of linux-kernel+bounces-139661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 10 Apr 2024 22:40:49 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: peng.fan@nxp.com, vkoul@kernel.org, imx@lists.linux.dev,
	dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] dmaengine: fsl-edma: optimize edma driver for
 imx8QM
Message-ID: <ZhdNsRyMxm0m83P0@lizhi-Precision-Tower-5810>
References: <20240411024417.2170609-1-joy.zou@nxp.com>
 <20240411024417.2170609-2-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240411024417.2170609-2-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PehnSGMwQGy7/CFLuzufQxpbEfvYRSo/gSivuthZ0tiPbMMfqRLKof0Mt8f9?=
 =?us-ascii?Q?wRn2KH4UCnNLG9p8W1rCKcOWAIcNwkqJmCYtmXc/4g0PB3Wc6mwR7O7TXey/?=
 =?us-ascii?Q?zIAdPXR/qiLYi9NauL1m2gsYBDdir5TIwLkgAZb+lmG4kH4yzx5qiCGeeKbD?=
 =?us-ascii?Q?FvuHRdHbVvYnNkS/PiHsY3FG0jwNSjnwmMcrijsRa7hh3efxh9JmD3340E3A?=
 =?us-ascii?Q?8jh9lTTzZV+qvcpwbTDTwrEYwETFSSlQOvdVUKhrM9mjUR7j6Eq1uiQ7Gj/O?=
 =?us-ascii?Q?eJA4URceV8y1xlcdWIkIXh2CCuaBSFAtQiWYZWJsodm/kTC/hq8FuVQEb7Eq?=
 =?us-ascii?Q?dXcVUacSzsAkM5X9XiKUYzosZqL0NrOniUFlivqwkCgpespe9iUP9WmSjuwF?=
 =?us-ascii?Q?/7dyGdP8QrlAA20MmMEdMAq2g6Xl4NPai8mJ7YMHgwy6T/xThjd7eUMGejz9?=
 =?us-ascii?Q?Uo8ltSmdzn6C7Ssbcgm95abtBdNuS4yio8zSuuKzglnlZLAZwt4LtLGIRjuK?=
 =?us-ascii?Q?vSxmjQUMKsmdVfdeKTwOsDJr5xZ8H4QqOnhsjYPdU2h8rhfi8LYLBLO+uPvr?=
 =?us-ascii?Q?DB9i77y310RapQO/xWfdDgNAEqVUrXLg14v07fv5KL7SYWjUKwjyiSVi9K3N?=
 =?us-ascii?Q?g/zYHVBov9xdtdZIapiH3abCYVQyGJQV9ZaTQKOMYwbfvxcKHudVpv9hJR0j?=
 =?us-ascii?Q?xA5fbVwexSufLu8iENL/Ma4Y4NE3z1X1OZMI+SErqiMAbTNdLu7InEfvMaiK?=
 =?us-ascii?Q?wZmOLcmfsjxP0RBh9cJyR3/ZCf01B31+sHKJooweRip6LIga6+PMH/Wo5UF9?=
 =?us-ascii?Q?LDMLzLLdq5CaYjV0AZmf6rR/lZFOWfJih6CsTkwsVjr2I1/fOikw5Cioczna?=
 =?us-ascii?Q?/BqLN+gx3w5+iTCKQR9FiuxmW9ecwhhts/Ygja2R9rEPXV0aWLrNrrEaVDMV?=
 =?us-ascii?Q?IJAkKyC4dL+YLKpLhjzFUH3kGlMDJvUCVkjF5uwCIgKYLHODHTo/VbgblcxR?=
 =?us-ascii?Q?7Q1Sl+5/SsC5INcyfAwSrpNUMGH0MihVwOXxsdVPgRAkzCAG9SgVD9SZmDSt?=
 =?us-ascii?Q?82HcWd0FxFdwcRGeq2rRqwRp4o8MIyUuUW6UeOpZg6wQHK938adkzIYcxvyH?=
 =?us-ascii?Q?H5u8pQQ7DCVvA+MVBmMne8E9qUe+RMI3oPdioFSSOJBYAZ3Aq4mLbst1XRjJ?=
 =?us-ascii?Q?6mz/SjB80EUt8i0NsqVbsLgAo9Sj1C08iClRgnEb3aqw2Q3OxJiDO7epCV6s?=
 =?us-ascii?Q?hCvya1ita2mdc/D8jVJbI2LMzedDrOC9BmWYi4trfVBjKGHc9XfaRlpXKLUB?=
 =?us-ascii?Q?CCl8X3Cp9ZUG/6Bx0zciCyYovPt1preEvbF80QGZOCoSIY/icukPjZEZy+GV?=
 =?us-ascii?Q?iDkqZHrSXnjBGvxuLuDTAb+l3JwGX0X5RUdUcgd2WVkpceb+//z/zj5JgNHR?=
 =?us-ascii?Q?uP1uoSExkDqaF6zBQHeoT9CjiFbg+U6UPxBac3JoYEIfyf5OFOMwyc3wrV4f?=
 =?us-ascii?Q?rWYCoww1usDT1VCMllWbpnGiJ4xquTEQJL6aV6X/zjMAhEowjIuDhx4BGQ6S?=
 =?us-ascii?Q?qEQg7Wt13l2fnAhomxTTK3Ydp/Lowvl6urutZBl5?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: def32ce7-f00c-491a-b51a-08dc59d0d01e
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 02:40:56.0776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7gmTqjNxfHDzqLJ6b70Hpk02DBJEkqYNvDNpPooHu8Cs8i1UyzsWsNBtLEZ7P1Xu0q46UfvNkyEZb8V/MykBGQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8566

On Thu, Apr 11, 2024 at 10:44:17AM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> So remove the workaround safely.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
>  drivers/dma/fsl-edma-common.c | 16 ++++------------
>  drivers/dma/fsl-edma-main.c   |  8 --------
>  2 files changed, 4 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index f9144b015439..ed93e01282d5 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -75,18 +75,10 @@ static void fsl_edma3_enable_request(struct fsl_edma_chan *fsl_chan)
>  
>  	flags = fsl_edma_drvflags(fsl_chan);
>  	val = edma_readl_chreg(fsl_chan, ch_sbr);
> -	/* Remote/local swapped wrongly on iMX8 QM Audio edma */
> -	if (flags & FSL_EDMA_DRV_QUIRK_SWAPPED) {
> -		if (!fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	} else {
> -		if (fsl_chan->is_rxchan)
> -			val |= EDMA_V3_CH_SBR_RD;
> -		else
> -			val |= EDMA_V3_CH_SBR_WR;
> -	}
> +	if (fsl_chan->is_rxchan)
> +		val |= EDMA_V3_CH_SBR_RD;
> +	else
> +		val |= EDMA_V3_CH_SBR_WR;
>  
>  	if (fsl_chan->is_remote)
>  		val &= ~(EDMA_V3_CH_SBR_RD | EDMA_V3_CH_SBR_WR);
> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
> index 755a3dc3b0a7..b06fa147d6ba 100644
> --- a/drivers/dma/fsl-edma-main.c
> +++ b/drivers/dma/fsl-edma-main.c
> @@ -349,13 +349,6 @@ static struct fsl_edma_drvdata imx8qm_data = {
>  	.setup_irq = fsl_edma3_irq_init,
>  };
>  
> -static struct fsl_edma_drvdata imx8qm_audio_data = {
> -	.flags = FSL_EDMA_DRV_QUIRK_SWAPPED | FSL_EDMA_DRV_HAS_PD | FSL_EDMA_DRV_EDMA3,
> -	.chreg_space_sz = 0x10000,
> -	.chreg_off = 0x10000,
> -	.setup_irq = fsl_edma3_irq_init,
> -};
> -
>  static struct fsl_edma_drvdata imx8ulp_data = {
>  	.flags = FSL_EDMA_DRV_HAS_CHMUX | FSL_EDMA_DRV_HAS_CHCLK | FSL_EDMA_DRV_HAS_DMACLK |
>  		 FSL_EDMA_DRV_EDMA3,
> @@ -397,7 +390,6 @@ static const struct of_device_id fsl_edma_dt_ids[] = {
>  	{ .compatible = "fsl,ls1028a-edma", .data = &ls1028a_data},
>  	{ .compatible = "fsl,imx7ulp-edma", .data = &imx7ulp_data},
>  	{ .compatible = "fsl,imx8qm-edma", .data = &imx8qm_data},
> -	{ .compatible = "fsl,imx8qm-adma", .data = &imx8qm_audio_data},

Please update binding doc also.

Frank Li

>  	{ .compatible = "fsl,imx8ulp-edma", .data = &imx8ulp_data},
>  	{ .compatible = "fsl,imx93-edma3", .data = &imx93_data3},
>  	{ .compatible = "fsl,imx93-edma4", .data = &imx93_data4},
> -- 
> 2.37.1
>