Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp158681lqg; Wed, 10 Apr 2024 20:33:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVcgUM1Ln73Hg3pQusuHXKkd7zHsLa9FpwOM4iAhld8t8QAM2Fp3h5xXqa4X+UqYw6vA64CRSH+Ci0nwdCy/o1N1mxxu51Z64maSBmy2Q== X-Google-Smtp-Source: AGHT+IFXxBdrCUfDCtP5q/TvsZleqpLLxPoe/2z6bCg4VQ3I63BApKmv/Q7nKKerZi+2lgXt3lWf X-Received: by 2002:a05:6a21:4981:b0:1a7:5fe0:1c99 with SMTP id ax1-20020a056a21498100b001a75fe01c99mr5252692pzc.46.1712806394929; Wed, 10 Apr 2024 20:33:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712806394; cv=pass; d=google.com; s=arc-20160816; b=EQR8UXjEDWrGnUf7dlcV9QM+vTmwf9T5bBi/TbJZFNasAZAqoabgiG3FKwy2l6gOP2 1YC2hBI9nZnefucI/6wUcXIUnhTGIX5xP/ijKzPT5B5WzCW9z01taRxQllg/dhJBYg97 bH2Uzhnzpt5OUIdyiYpuQfuDdOjMUZZ7kPp1QiwWJ8d3WikTiBMclbMzqc7lWC0AE6Q/ FMTgF8R7cUx81yTM+5Cj28NqHDS96srQruABNl+x1aW+whj8FhQJVm20ENCIg5X7vwJQ X5Efdik9vgrpdgKMx2tlc5mEREM+/Cxp51DhLAtCa2svVDmT+6UZjY03oCYFBH45ZYgX 5v9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=0BxO2ShU/fZNhlv0h0GS9doHCY/ZbG1BmofHQ8i1XlA=; fh=fHhbvXgCev/wpffLVpfaAi8pPyv7hrTyhVPgsZ7HNrs=; b=Zi9AwOR20cykV2uE9IGaI+V6XYl1pjsnyw0MXDcArkwb1eOARAMyMETPqsxbZMOgkR FVD+y8s+yjcKvR09rpXmU/wM+I//Iqu1QAglwv5j7KFQNtAxF0A8sWO67ZAlqHj67wQk kyDaYa1tFvLQVlEnM5tvNGkrEikrjhw+sSEOe5UILflsmzV2pVkCdJsObffRtm7v4gSG AJaoJ96jCArB+Uwz4ZeEM/FgV4jvCstOt0YM1WmjjZ/+WeuwaZi3G+EpyIMbFn2ZTBG4 qDzgd4gUIAOvNsnPar2HzyFIE9+iGu1lh9SRXzVmOyHKOLsfWDmqIcKoGh6YDPtdPcjP VKtw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkAlxtus; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139713-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id e10-20020a170902f1ca00b001e51f5c83ddsi458439plc.371.2024.04.10.20.33.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 20:33:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YkAlxtus; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-139713-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139713-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9970F28335B for ; Thu, 11 Apr 2024 03:33:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0A4C13BAED; Thu, 11 Apr 2024 03:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YkAlxtus" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2116F13BAD1; Thu, 11 Apr 2024 03:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712806378; cv=none; b=mpD7q8op3IR5deO30VVH4tIDp3A1PaXlXB9qe4TniH+8hz5pTS/Yuwg73hFhYh0swNrD2ydALXWAKfuwzy67nwboXLSWLjsplOtKrtIlzAQwr02jy52R98VqE+Z6nU8sC47G1nwnCaeC03IJSHCbb/9BqqNrrihFRoLWr25mGGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712806378; c=relaxed/simple; bh=CHiFbLxairoTiGbx1GSuvG58rkHjFayrKvmJhpk8jPo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UyYARM69c0r+Cy23UP1fRJltPCJfOBA0hBYnNIkqcUWOFlto2/e2dN58MJ7HlX2jjuc5eUtRWH9boq349EXWpNoS1bmtRzuVbRS0WhHV7+5CPiOoH99SD5GCS5CVmzS7WjEoxiwefrNkpbUo/NcgT5h0fe1HSP+VgUAs2SuhzVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YkAlxtus; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A7F1C433F1; Thu, 11 Apr 2024 03:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712806377; bh=CHiFbLxairoTiGbx1GSuvG58rkHjFayrKvmJhpk8jPo=; h=From:To:Cc:Subject:Date:From; b=YkAlxtusli66qs6gLp55URIOphPV2pF5UXWeBFTpSqzaTpd+W3B8F/dimLoysV/uN qDl99WYXqCelcSHVvAHwx3aLJigG+a7ayfBRoZFyABiC/gi7a1VCdK2HUBUpfBzLR/ hChtfViXoVqX0IAcs9257yYYm+bc/tJGlq/JuAQO/MSIJxrbjFM/CNSOzbld8Mpys3 /gtw0LEmiQlVJW7LvmU+MM19Jgh0Z91hsusZk//Dw7Bc08pA+q0oZTsMMuu3CWj2JP qYchvLqpksGoFhz8iP5DhY6JLMYLLVV09zPO151iIIzCACSkU5M4uj64CPk2OsBAhZ EKDAuFAC5ktEA== From: Namhyung Kim To: Arnaldo Carvalho de Melo , Ian Rogers , Kan Liang Cc: Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org Subject: [PATCHSET 0/7] perf annotate: Add TUI support for data type profiling (v2) Date: Wed, 10 Apr 2024 20:32:49 -0700 Message-ID: <20240411033256.2099646-1-namhyung@kernel.org> X-Mailer: git-send-email 2.44.0.478.gd926399ef9-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, This is to support interactive TUI browser for type annotation. v2 changes: * fix build errors when libslang2 or libdw is missing (Arnaldo) * update commit messages with examples (Arnaldo) * skip updating sample histogram for stack canary (Arnaldo) * add Reviewed-by from Ian Like the normal (code) annotation, it should be able to display the data type annotation. Now `perf annotate --data-type` will show the result in TUI by default if it's enabled. Also `perf report -s type` can show the same output using a menu item. It's still in a very early stage and supports the basic functionalities only. I'll work on more features like in the normal annotation browser later. The code is also available at 'perf/annotate-data-tui-v2' branch at git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (7): perf annotate-data: Skip sample histogram for stack canary perf annotate: Show progress of sample processing perf annotate-data: Add hist_entry__annotate_data_tty() perf annotate-data: Add hist_entry__annotate_data_tui() perf annotate-data: Support event group display in TUI perf report: Add a menu item to annotate data type in TUI perf report: Do not collect sample histogram unnecessarily tools/perf/builtin-annotate.c | 149 ++++-------- tools/perf/builtin-report.c | 7 +- tools/perf/ui/browsers/Build | 1 + tools/perf/ui/browsers/annotate-data.c | 312 +++++++++++++++++++++++++ tools/perf/ui/browsers/hists.c | 31 +++ tools/perf/util/annotate-data.c | 113 +++++++++ tools/perf/util/annotate-data.h | 22 ++ tools/perf/util/annotate.c | 12 +- 8 files changed, 534 insertions(+), 113 deletions(-) create mode 100644 tools/perf/ui/browsers/annotate-data.c base-commit: 9c3e9af74326978ba6f4432bb038e6c80f4f56fd -- 2.44.0.478.gd926399ef9-goog