Received-SPF: pass (google.com: domain of linux-kernel+bounces-139700-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 10 Apr 2024 23:22:00 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, 
 John Fraker <jfraker@google.com>
Cc: netdev@vger.kernel.org, 
 Praveen Kaligineedi <pkaligineedi@google.com>, 
 Harshitha Ramamurthy <hramamurthy@google.com>, 
 Shailend Chand <shailend@google.com>, 
 Willem de Bruijn <willemb@google.com>, 
 "David S. Miller" <davem@davemloft.net>, 
 Junfeng Guo <junfeng.guo@intel.com>, 
 Ziwei Xiao <ziweixiao@google.com>, 
 Jeroen de Borst <jeroendb@google.com>, 
 linux-kernel@vger.kernel.org
Message-ID: <66175758bab7c_2dcc3c294a@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240409172602.3284f1c6@kernel.org>
References: <20240408180918.2773238-1-jfraker@google.com>
 <20240409172602.3284f1c6@kernel.org>
Subject: Re: [PATCH net-next] gve: Correctly report software timestamping
 capabilities
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Jakub Kicinski wrote:
> On Mon,  8 Apr 2024 11:09:01 -0700 John Fraker wrote:
> > gve has supported software timestamp generation since its inception,
> > but has not advertised that support via ethtool. This patch correctly
> > advertises that support.
> > 
> > Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > Reviewed-by: Harshitha Ramamurthy <hramamurthy@google.com>
> > Signed-off-by: John Fraker <jfraker@google.com>
> 
> I think it should be a single line diff:
> 
> +	.get_ts_info = ethtool_op_get_ts_info,
> 
> right?

If inserted above .get_link_ksettings that works. The current
ordering is not based on actual struct layout anyway.

Probably all statements should just end in a comma, including a
trailing comma. To avoid these two line changes on each subsequent
change.

The rest of the discussion in this thread is actually quite
unrelated to this patch. Didn't meant to sidetrack that.