Received-SPF: pass (google.com: domain of linux-kernel+bounces-139729-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e6ecf39d6b4378731f3aa19350e0d5b7.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240308-mtk-fhctl-no-node-error-v1-1-51e446eb149a@collabora.com>
References: <20240308-mtk-fhctl-no-node-error-v1-1-51e446eb149a@collabora.com>
Subject: Re: [PATCH] clk: mediatek: pllfh: Don't log error for missing fhctl node
From: Stephen Boyd <sboyd@kernel.org>
Cc: kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?utf-8?q?N=C3=ADcolas?= F. R. A. Prado <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Chen-Yu Tsai <wenst@chromium.org>, Edward-JW Yang <edward-jw.yang@mediatek.com>, Johnson Wang <johnson.wang@mediatek.com>, Matthias Brugger <matthias.bgg@gmail.com>, Michael Turquette <mturquette@baylibre.com>, =?utf-8?q?N=C3=ADcolas?= F. R. A. Prado <nfraprado@collabora.com>
Date: Wed, 10 Apr 2024 20:49:48 -0700
User-Agent: alot/0.10

Quoting N=C3=ADcolas F. R. A. Prado (2024-03-08 12:29:56)
> Support for fhctl clocks in apmixedsys was introduced at a later point
> and to this moment only one mt6795 based platform has a fhctl DT node
> present. Therefore the fhctl support in apmixedsys should be seen as
> optional and not cause an error when it is missing.
>=20
> Change the message's log level to warning. The warning level is chosen
> so that it will still alert the fact that fhctl support might be
> unintentionally missing, but without implying that this is necessarily
> an issue.
>=20
> Even if the FHCTL DT nodes are added to all current platforms moving
> forward, since those changes won't be backported, this ensures stable
> kernel releases won't have live with this error.
>=20
> Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL=
 hardware")
> Signed-off-by: N=C3=ADcolas F. R. A. Prado <nfraprado@collabora.com>
> ---

Applied to clk-next