Received-SPF: pass (google.com: domain of linux-kernel+bounces-139762-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5fc87d10b06f8b5b3024ac6c5674b18b.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <a70e7219-5fd8-4797-be43-199f8995409b@quicinc.com>
References: <20231220221724.3822-1-ansuelsmth@gmail.com> <a70e7219-5fd8-4797-be43-199f8995409b@quicinc.com>
Subject: Re: [PATCH v8 0/3] clk: qcom: clk-rcg2: introduce support for multiple conf for same freq
From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>, Christian Marangi <ansuelsmth@gmail.com>, Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>, Konrad Dybcio <konrad.dybcio@linaro.org>, Michael Turquette <mturquette@baylibre.com>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 10 Apr 2024 22:01:00 -0700
User-Agent: alot/0.10

Quoting Kathiravan Thirumoorthy (2024-01-22 09:46:23)
>=20
>=20
> On 12/21/2023 3:47 AM, Christian Marangi wrote:
> > This small series fix a current problem with ipq8074 where the 2 uniphy
> > port doesn't work in some corner case with some clk configuration. The
> > port to correctly work require a specific frequency, using the wrong one
> > results in the port not transmitting data.
> >=20
> > With the current code with a requested freq of 125MHz, the frequency is
> > set to 105MHz. This is caused by the fact that there are 2 different
> > configuration to set 125MHz and it's always selected the first one that
> > results in 105MHz.
> >=20
> > In the original QSDK code, the frequency configuration selection is
> > different and the CEIL FLOOR logic is not present. Instead it's used a
> > BEST approach where the frequency table is checked and then it's checked
> > if there are duplicate entry.
> >=20
> > This proposed implementation is more specific and introduce an entire n=
ew
> > set of ops and a specific freq table to support this special configurat=
ion.
> >=20
> > A union is introduced in rcg2 struct to not duplicate the struct.
> > A new set of ops clk_rcg2_fm_ops are introduced to support this new kind
> > of frequency table.
> >=20
>=20
>=20
> Bjorn / Stephen Boyd,
>=20
> I would like to know if there are any comments on this series. To enable =

> the clocks required for the Ethernet interfaces on the IPQ platforms,=20
> these patches are needed. If no concerns, can this be picked up for v6.9?
>=20

I'm fine if Bjorn wants to pick it up.

Acked-by: Stephen Boyd <sboyd@kernel.org>