Received: by 2002:ab2:1347:0:b0:1f4:ac9d:b246 with SMTP id g7csp203298lqg; Wed, 10 Apr 2024 23:06:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUNDXWJ5zjIG4BSkmIkkfQa1pPNlVVAeme001hOTX183SN8SyP6XIgUWrjhgDRmczHuRi3bo0koQUbfno4l3voZ+jWicaLA0M5Ug1zz0Q== X-Google-Smtp-Source: AGHT+IHLXKuWCsW0nhMD6x5kE0ncoXXFl+8ckRMsUOOvSH7WeLuA1T/CjeeFn6JrDXaviL2bdCwm X-Received: by 2002:a05:6a21:78a9:b0:1a7:6918:9e96 with SMTP id bf41-20020a056a2178a900b001a769189e96mr5874831pzc.3.1712815574075; Wed, 10 Apr 2024 23:06:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712815574; cv=pass; d=google.com; s=arc-20160816; b=fhCKv1yImapn4T1HxPxE2XOvBD2BBiZNIx0Ylc1T0u6NjV+mBMFomvXjcc+G+pzobe w+X8Oc4e/T65KhfwJ/jl3NVxAJt6gY0PZ2udKp9ThY5DOmkElD+OQ6MVx6xugM0UFYfZ 7V+3oVjSuCawiim5OWLoT8dw92dii3nSymVFlRvlglyloKwL6nzaqL91DC5GBOSjLNSY kbtHpvyDCvzXEdPprnoIdwVVfPTTjz6ppfYw9pHAlgTBpVbEiIBFJb13KtFeZ1TnLpWj XHYFXwaq8aLGTY0STMaOLbe1MmdiGgs2md2IWx7GReld7LTRZ3xmgx5fxUU1BZZVtQfA aZMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=FXmAKscTbgNJ1p29Two6+cxbrIyx3G8HLoeSBvRIChc=; fh=SYx7FiglzFf3P/czyjWyIOLuV4vbgCu/P5nVaTHZL80=; b=DIpd2lszZw+F4IdAbigtRXkiIPwskSTBn1PGbh1nYtn/NSNayQxhu72+flGG5MK2Cq YuoUvFVjRCUQTBDjUKezizJSw5qJV4B1yf/r2JG283PslIntXP4PlrHUG1SHoSSBemTd HKSV+i25JJbFjozdFD4XtDgcsH5JonknYGqWjxw4cvlAEMVQHgI66u6ehOPnB+6wBTYu a0J9eVez3EzMxGl2TuBQ7P3Zc5fslVQDMRohvl0nu0ErozmQm403gXCubcWmrRnMxGin ZRFeuTBj/rhXTrNLw77IRep1IFo7bRZgmKaWZ6VGuh8XKWeh53klanP1oMvqUZu0TQBV WJug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JE2fo2vX; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-139537-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id r33-20020a17090a43a400b0029c74a38c69si2916019pjg.168.2024.04.10.23.06.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 23:06:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-139537-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=JE2fo2vX; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-139537-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-139537-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 16B55284D1B for ; Wed, 10 Apr 2024 23:34:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81D163FB9A; Wed, 10 Apr 2024 23:34:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="JE2fo2vX" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64CAF3BB43; Wed, 10 Apr 2024 23:34:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712792069; cv=none; b=IO6YmtdnzC0O1EEdaWy5VZp7427gTTOSu+wo+4HuZ2iWmVdJxZRAWRgdFBNGdttieJNJvDddOyLowKhqIr/GXTAdTu3TMjXQhELC4ziuwGnT+YvJv4Br1NccbN4hiUki+k2Wy1K4+6GC3E7dpr1hCgDSbdnMkFoagyfx76nqrbo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712792069; c=relaxed/simple; bh=uqzNxqrBph2PlRsjh6hC900ySu85OHtjJiS7mW6FX+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ljUZ65MQLt0UejX/zHvA6Dr0tpSyhPPYF3sKHOtHrLtc8rpFxwb40MJ3f2qJbRBiz8jMy4BYOdOh6wKb+Ecs4SNoLiUhuKORQRuYeVUHKTrXacqBNCDTuGd98hXXR8VA3ZAIvgpgebdLz2ubF+u0+37Z9o6ghBcIFeqmHX8+PVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=JE2fo2vX; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FXmAKscTbgNJ1p29Two6+cxbrIyx3G8HLoeSBvRIChc=; b=JE2fo2vXsHYBjNsZu7z66/oeOy TmDFDhmMWI9DAzYzarLq47L936opk3bRPR+HQRcRAPsrypIYPj5IBH+1d79t1LK+AnBA+5NqwzAXv TNWkEFAYnKtYuy0h5tNyXJoPw6mPA/ZLGwkw/Vn/jRQml7vmt1L232DP97jJ5uLt2PaI8tFK42Rre a1JqxOrlDlkYEwwZOATQlvCzzPoVitwEw5sALBZYIINr8eL0SYCToM8rS1J4KPxntH2tebwotXZtC 7VN7jbR6LjOg1f1PqKaNoltS7oh8wdYpnuu9FXnUjmMvryJcahiQgKb2l/KRMQpv94xvskr6zJLmZ jPffkkNw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruhSN-00000009Tii-29zF; Wed, 10 Apr 2024 23:34:19 +0000 Date: Wed, 10 Apr 2024 16:34:19 -0700 From: Luis Chamberlain To: Randy Dunlap Cc: John Garry , axboe@kernel.dk, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org, ojaswin@linux.ibm.com, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org, nilay@linux.ibm.com, ritesh.list@gmail.com, willy@infradead.org, Himanshu Madhani Subject: Re: [PATCH v6 05/10] block: Add core atomic write support Message-ID: References: <20240326133813.3224593-1-john.g.garry@oracle.com> <20240326133813.3224593-6-john.g.garry@oracle.com> <0a9fb564-7129-4153-97d6-76e9b3a1b6c1@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a9fb564-7129-4153-97d6-76e9b3a1b6c1@infradead.org> Sender: Luis Chamberlain On Tue, Mar 26, 2024 at 10:11:50AM -0700, Randy Dunlap wrote: > Hi, > > On 3/26/24 06:38, John Garry wrote: > > diff --git a/Documentation/ABI/stable/sysfs-block b/Documentation/ABI/stable/sysfs-block > > index 1fe9a553c37b..4c775f4bdefe 100644 > > --- a/Documentation/ABI/stable/sysfs-block > > +++ b/Documentation/ABI/stable/sysfs-block > > +What: /sys/block//atomic_write_boundary_bytes > > +Date: February 2024 > > +Contact: Himanshu Madhani > > +Description: > > + [RO] A device may need to internally split I/Os which > > + straddle a given logical block address boundary. In that > > + case a single atomic write operation will be processed as > > + one of more sub-operations which each complete atomically. > > or If *or* was meant, wouldn't it be better just to say one or more operations may be processed as one atomically in this situation? Luis