Received-SPF: pass (google.com: domain of linux-kernel+bounces-139850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 08:23:35 +0200
From: Jiri Pirko <jiri@resnulli.us>
To: Jijie Shao <shaojijie@huawei.com>
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, rkannoth@marvell.com, shenjian15@huawei.com,
	wangjie125@huawei.com, liuyonglong@huawei.com,
	chenhao418@huawei.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc
 version by devlink info
Message-ID: <ZheB58bjmkFzIEbG@nanopsycho>
References: <20240410125354.2177067-1-shaojijie@huawei.com>
 <20240410125354.2177067-5-shaojijie@huawei.com>
 <ZhapUja4xXiJe4Q2@nanopsycho>
 <16347737-f0ac-4710-85ee-189abed59d6b@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16347737-f0ac-4710-85ee-189abed59d6b@huawei.com>

Thu, Apr 11, 2024 at 03:05:53AM CEST, shaojijie@huawei.com wrote:
>
>on 2024/4/10 22:59, Jiri Pirko wrote:
>> Wed, Apr 10, 2024 at 02:53:54PM CEST, shaojijie@huawei.com wrote:
>> > From: Hao Chen <chenhao418@huawei.com>
>> > 
>> > Add support to query scc version by devlink info for device V3.
>> > 
>> > Signed-off-by: Hao Chen <chenhao418@huawei.com>
>> > Signed-off-by: Jijie Shao <shaojijie@huawei.com>
>> > ---
>> > Documentation/networking/devlink/hns3.rst     |  3 ++
>> > drivers/net/ethernet/hisilicon/hns3/hnae3.h   |  9 ++++
>> > .../hns3/hns3_common/hclge_comm_cmd.h         |  8 ++++
>> > .../hisilicon/hns3/hns3pf/hclge_devlink.c     | 44 +++++++++++++++++--
>> > .../hisilicon/hns3/hns3pf/hclge_devlink.h     |  2 +
>> > .../hisilicon/hns3/hns3pf/hclge_main.c        | 18 ++++++++
>> > .../hisilicon/hns3/hns3pf/hclge_main.h        |  1 +
>> > 7 files changed, 82 insertions(+), 3 deletions(-)
>> > 
>> > diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
>> > index 4562a6e4782f..e19dea8ef924 100644
>> > --- a/Documentation/networking/devlink/hns3.rst
>> > +++ b/Documentation/networking/devlink/hns3.rst
>> > @@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
>> >     * - ``fw``
>> >       - running
>> >       - Used to represent the firmware version.
>> > +   * - ``fw.scc``
>> What's scc? I don't see it described anywhere.
>
>diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
>index 4562a6e4782f..e19dea8ef924 100644
>--- a/Documentation/networking/devlink/hns3.rst
>+++ b/Documentation/networking/devlink/hns3.rst
>@@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
>    * - ``fw``
>      - running
>      - Used to represent the firmware version.
>+   * - ``fw.scc``
>+     - running
>+     - Used to represent the soft congestion control firmware version.
>
>scc means "soft congestion control"

I guess this is something specific to your device, isn't it? Can't you
please extend the description a bit more?

Thanks!

>