Received-SPF: pass (google.com: domain of linux-kernel+bounces-139852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 11 Apr 2024 08:24:55 +0200
From: Louis Peens <louis.peens@corigine.com>
To: =?iso-8859-1?Q?Asbj=F8rn_Sloth_T=F8nnesen?= <ast@fiberby.net>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-kernel@vger.kernel.org, Yanguo Li <yanguo.li@corigine.com>,
	oss-drivers@corigine.com, Taras Chornyi <taras.chornyi@plvision.eu>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Edward Cree <ecree.xilinx@gmail.com>,
	Jamal Hadi Salim <jhs@mojatatu.com>,
	Cong Wang <xiyou.wangcong@gmail.com>, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next v2 1/4] flow_offload: add control flag checking
 helpers
Message-ID: <ZheCN40U2R7ruypI@LouisNoVo>
References: <20240410093235.5334-1-ast@fiberby.net>
 <20240410093235.5334-2-ast@fiberby.net>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240410093235.5334-2-ast@fiberby.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?iso-8859-1?Q?wG3xzqpDjdgvvtdRIqCNnRKuBWei4cPA62KRnQyXPHaraMP+U4Lge6cF4H?=
 =?iso-8859-1?Q?ilP85g76djbVahzUvkJciTnhaZqDs27/zybkEbY1SwB7zRKM1c7YEgRAHR?=
 =?iso-8859-1?Q?Xkhmv8qtnQhJmxwEpjhtQ9jlzLRr7MLjmgCocJqVwYlWcc1ZJ9Lo9/hr0Z?=
 =?iso-8859-1?Q?8fT3HJe+IGbrva/QLYMG3BBa2VFoqAxjBjHs6TJ9ROjxVnRaEldxvF3UUp?=
 =?iso-8859-1?Q?ffAT5DJipU4BjP3701PueYGWwlOjydrwYcQTP4B6kuwBiSMI05c3Da+GXh?=
 =?iso-8859-1?Q?6PDX+Ey7w5/RHg2vHlJ+RQJ+XpkjbCnUzLzToTjm+ePgo8PhuRqY9awN8M?=
 =?iso-8859-1?Q?S6pae265YSQDP9IZkYBt7sOLZrmnvT3UeHQr2keWGSd4M59BNcKwm6NSuE?=
 =?iso-8859-1?Q?nzrAIi8ACi5+3JvZSQaLYbffP9rqdtHOkk94UHPzESTFCDs5fbOcHnQ8Qk?=
 =?iso-8859-1?Q?8jTm8VogqwX1/rOFSpO5pCMUvnANSsnNM+/By+tOY4TohKe8emX636o3K3?=
 =?iso-8859-1?Q?/9OUVZWvMlajlTmJAABH/PKHGvGwNZ2JzOcBKUNnQmkHzIWp2kx+lHAiCZ?=
 =?iso-8859-1?Q?xJZiCvZN7SAgH9FUGhDHEKBvLrc6SKDS59ESYYcDHnjxuC8bw754bRTcB7?=
 =?iso-8859-1?Q?/tWv02RiruOc7x2KcxjNNbPMshmfhr8sv6JpxFsz2h8J5UiI/F73PxMBxg?=
 =?iso-8859-1?Q?oeEtOIaVbFYSjmQnhdhIJmUU1z7iVeuCDZkYsF8r+/LzB/5jxR2rgAAA9N?=
 =?iso-8859-1?Q?PhhLZwVmLNAvHysg1qCIu7pwliDy8OPFCYzKeH8axPhWDaZLQ2cUP7+F+p?=
 =?iso-8859-1?Q?CoB1tdNnpD6eWElp74bl4jjnD6OSSWY0t0vCRc8UOaUVCcw/7CxxsCylyL?=
 =?iso-8859-1?Q?N7oWS1q3xpjOejcIUjejmnylpYFzHUFm+QomW+Ak/mVu5rLzALfhPwqrU/?=
 =?iso-8859-1?Q?ZiX78w/JqAiyHsvA0bY6feY6mx+dYFNQW+38kCAznrlsui7mMjtYv2oqPP?=
 =?iso-8859-1?Q?zmDhTBVLGSzL4qoAFG7tarcT7SAWxeUc6NBmDSnXYHQA7IwTnXulmLK6mb?=
 =?iso-8859-1?Q?K03pbmXCWnIV/+UhFWRzBK8yPHkzdIOJbKNkygR03B9vT8qVm+Er6mnWIJ?=
 =?iso-8859-1?Q?muDxV+Sq/UpaJg08eoybMkO7iIKHCxQAjPzJhAhglqS9ywhQtOufg+VPXw?=
 =?iso-8859-1?Q?+g3Zgd/Z1J/Cw3ixd/vr6MGX7UYT51aYHOqX3Pfi8edAhYBpamL8oD9a8J?=
 =?iso-8859-1?Q?q+q/Uos4FsAoIwRpEeIRDV+g0JOj+DKfvieREYGHTAfdMgROgmMjfvzioL?=
 =?iso-8859-1?Q?GOEFrnvq41JNBNHwTMTj8MvXmKEvbdoPLBrLFbw3xx/Z2S4kJ3QFkUyUrO?=
 =?iso-8859-1?Q?XfOBaj4FVQEF5DiHW8M5dNNl0L6lk2pGNArbdhYclUkRojj2l9Fri0lf3N?=
 =?iso-8859-1?Q?/06EXeVvVdz/qxoI/89rJLtfWuHwlfFEltOyDnE3XizWLQCJJYP4iwTE3k?=
 =?iso-8859-1?Q?j7BZf662c0QgXV3BJyo/mdLj84o6AHdxkx0RldlzEA5U5JRi6hWChH3oKd?=
 =?iso-8859-1?Q?PGJ4dfwVzznnAsLLdf42lzdDi4c7OijlEUQOloNLzGUFXXLZRyZpuBs7lp?=
 =?iso-8859-1?Q?+V7/u6ZcIycm1MXI8dM20VQaqV1Z8bMszPMQYqNLxEKcHmYl7/WTmQmQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 425a4b15-0e3c-4c25-8852-08dc59f045a3
X-MS-Exchange-CrossTenant-AuthSource: BL0PR13MB4403.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 06:26:07.6117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xjQBxdM/1zF2Jv/M29wYHm4FylVorSUlUQA5zvDXQqmXdlKpotjoTfs7YlG/GIB+HjH9o3bcephLbfe4LQSYgCw4qAHZpisXp/VwPclX/Eg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB5014

On Wed, Apr 10, 2024 at 09:32:22AM +0000, Asbj?rn Sloth T?nnesen wrote:
> These helpers aim to help drivers, with checking
> for the presence of unsupported control flags.
> 
> For drivers supporting at least one control flag:
>   flow_rule_is_supp_control_flags()
> 
> For drivers using flow_rule_match_control(), but not using flags:
>   flow_rule_has_control_flags()
> 
> For drivers not using flow_rule_match_control():
>   flow_rule_match_has_control_flags()
> 
> While primarily aimed at FLOW_DISSECTOR_KEY_CONTROL
> and flow_rule_match_control(), then the first two
> can also be used with FLOW_DISSECTOR_KEY_ENC_CONTROL
> and flow_rule_match_enc_control().
> 
> These helpers mirrors the existing check done in sfc:
>   drivers/net/ethernet/sfc/tc.c +276
> 
> Only compile-tested.
> 
> Signed-off-by: Asbj?rn Sloth T?nnesen <ast@fiberby.net>
> ---

Looks good from my perspective, thanks for the naming updates:
Reviewed-by: Louis Peens <louis.peens@corigine.com>