Received-SPF: pass (google.com: domain of linux-kernel+bounces-139867-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <44e544735066391b2ad1682badae4462.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240123025613.3976-1-zhifeng.tang@unisoc.com>
References: <20240123025613.3976-1-zhifeng.tang@unisoc.com>
Subject: Re: [PATCH V4 0/3] Add reset controller driver for ums512
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Zhifeng Tang <zhifeng.tang23@gmail.com>, Wenming Wu <wenming.wu@unisoc.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Conor Dooley <conor+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Orson Zhai <orsonzhai@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Zhifeng Tang <zhifeng.tang@unisoc.com>
Date: Wed, 10 Apr 2024 23:42:41 -0700
User-Agent: alot/0.10

Quoting Zhifeng Tang (2024-01-22 18:56:10)
> From: "zhifeng.tang" <zhifeng.tang@unisoc.com>
>=20
> In most of Sprd SOCs,The clock controller register block also
> contains reset bits for some of these peripherals,so reset
> controller and clock provider are combined together as a block,
> and put it under the driver/clk/.
>=20
> Changes in v4:
>   - Add description why reset controller put it under the driver/clk/

Please use an auxiliary device and put the code almost entirely under
drivers/reset/. You can still have the data tables in the clk driver if
you want, but I don't see why an auxiliary device can't be used.