Received-SPF: pass (google.com: domain of linux-kernel+bounces-139908-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Javier Martinez Canillas <javierm@redhat.com>
To: neil.armstrong@linaro.org, Krzysztof Kozlowski
 <krzysztof.kozlowski@linaro.org>, Russell King <linux@armlinux.org.uk>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS
In-Reply-To: <7c612f63-fd7d-4f5a-ace6-05b2bc29f3eb@linaro.org>
References: <20240410082218.46525-1-krzysztof.kozlowski@linaro.org>
 <7c612f63-fd7d-4f5a-ace6-05b2bc29f3eb@linaro.org>
Date: Thu, 11 Apr 2024 09:01:43 +0200
Message-ID: <874jc8s7qg.fsf@minerva.mail-host-address-is-not-set>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Neil Armstrong <neil.armstrong@linaro.org> writes:

Hello Neal,

> On 10/04/2024 10:22, Krzysztof Kozlowski wrote:
>> The MODULE_DEVICE_TABLE already creates proper alias for platform
>> driver.  Having another MODULE_ALIAS causes the alias to be duplicated.
>> 
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> 
>> ---
>> 
>> Resent third time
>> https://lore.kernel.org/all/20220407202443.23000-1-krzysztof.kozlowski@linaro.org/
>> 
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>   drivers/gpu/drm/armada/armada_drv.c | 1 -
>>   1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/armada/armada_drv.c b/drivers/gpu/drm/armada/armada_drv.c
>> index e51ecc4f7ef4..f48e2cf8de43 100644
>> --- a/drivers/gpu/drm/armada/armada_drv.c
>> +++ b/drivers/gpu/drm/armada/armada_drv.c
>> @@ -283,4 +283,3 @@ module_exit(armada_drm_exit);
>>   MODULE_AUTHOR("Russell King <rmk+kernel@armlinux.org.uk>");
>>   MODULE_DESCRIPTION("Armada DRM Driver");
>>   MODULE_LICENSE("GPL");
>> -MODULE_ALIAS("platform:armada-drm");
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> I think we'll need maxime or thomas ack to apply this via drm-misc-next
>

I don't think you need an explicit ack for them to commit it:

https://drm.pages.freedesktop.org/maintainer-tools/committer-drm-misc.html#merge-criteria

BTW, the patch looks good to me as well.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat