Received-SPF: pass (google.com: domain of linux-kernel+bounces-139929-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 11 Apr 2024 09:07:02 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 7/8] intel_th: Convert to platform remove callback
 returning void
Message-ID: <rnybbv5sddkgtnxzad7sg2jyosr77vvud6t7ii3sssfsi7td2u@3b5nbhsprcaf>
References: <20231107202818.4005791-1-u.kleine-koenig@pengutronix.de>
 <20231107202818.4005791-8-u.kleine-koenig@pengutronix.de>
 <i3oybmf3axeyk5rcef5kgfdb4cucd63h24gup6idn62nq3vvav@4mfzwzyamq27>
 <jawceotzgdydpz74qr2e5dwgfumwjmt4wxvi43qlwldlbgemzf@v3qa2hoopawv>
 <qiiln66o6uy2nsqdjcykygp3yumonn7jqp7q4wxf56i6pazics@iqfaiglmsgwt>
 <87edd5y7lz.fsf@ubik.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="yl2xwhqpkfytrksb"
Content-Disposition: inline
In-Reply-To: <87edd5y7lz.fsf@ubik.fi.intel.com>


--yl2xwhqpkfytrksb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Alex,

On Wed, Feb 21, 2024 at 08:50:32PM +0200, Alexander Shishkin wrote:
> Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de> writes:
> > On Thu, Feb 15, 2024 at 10:16:41PM +0100, Uwe Kleine-K=F6nig wrote:
> >> On Wed, Jan 10, 2024 at 09:41:54AM +0100, Uwe Kleine-K=F6nig wrote:
> >> > On Tue, Nov 07, 2023 at 09:28:26PM +0100, Uwe Kleine-K=F6nig wrote:
> >> > > The .remove() callback for a platform driver returns an int which =
makes
> >> > > many driver authors wrongly assume it's possible to do error handl=
ing by
> >> > > returning an error code. However the value returned is ignored (ap=
art
> >> > > from emitting a warning) and this typically results in resource le=
aks.
> >> > >=20
> >> > > To improve here there is a quest to make the remove callback return
> >> > > void. In the first step of this quest all drivers are converted to
> >> > > .remove_new(), which already returns void. Eventually after all dr=
ivers
> >> > > are converted, .remove_new() will be renamed to .remove().
> >> > >=20
> >> > > Trivially convert this driver from always returning zero in the re=
move
> >> > > callback to the void returning variant.
> >> > >=20
> >> > > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> >> >=20
> >> > I didn't get any feedback to this patch and it didn't make it into n=
ext
> >> > up to now.
> >> >=20
> >> > Is this still on someone's radar?
> >>=20
> >> Is there a chance to get this patch into v6.9-rc1? Are you the right o=
ne
> >> to talk to about this patch? (According to MAINTAINERS you are.)
> >>=20
> >> The patch was sent during the 6.7 merge window and now already missed
> >> the 6.8 one :-\
> >
> > I failed in several attempts to get feedback on this patch. You applied
> > the last two patches for this driver (that is all patches since the
> > driver was born). Would you care for that one, too? Tell me if you want
> > a resend. Note that the other 7 patches from this series are already
> > cared for, so if you're using b4 am or shazam, make use of -P7.
>=20
> Apologies. This looks good to me, I will pick it up for my next
> submission to Greg unless somebody objects.

Given there are not that many patches left (~50) as of today's next, I'd
like to see this patch going in during the next merge window, that I can
finalize the (next step of the) quest around platform_driver::remove.

Is sending this patch to Greg still on your todo list?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--yl2xwhqpkfytrksb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYXjBYACgkQj4D7WH0S
/k5fEAf+Nq54JrvztGVvk0m0iweAHUrUGtKa/QdaIu1S6HXWyc8KHWLfOPVpGSm/
VPRbXnkPNHB24gmJ4/kamiVXJ8ookD6+Z7Co6R5v/siXNy6lYvnR1q6UpkB7ONib
Oxhj5GgBBJSMnKcpZujnQyHJnt5iyAOAogyCeAjz6syL2CPGfKu3TAflAXTJqgyI
t0SMSFzzoID/lnC3mPSUn0pVvU0477JmvPSJBZLC1r3Y5IqdTdA1mYEkXqZwLSDF
PiRmmof2nTlciKRkm3fvrphGvCi3Fm2xlibmNBJ1OoT8BRtzvfHn8zcwZV1VC1nn
1gIYEMb27GE1QUSBlR/A8X+W4QxMSQ==
=dCQr
-----END PGP SIGNATURE-----

--yl2xwhqpkfytrksb--