Received-SPF: pass (google.com: domain of linux-kernel+bounces-139958-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 11 Apr 2024 09:23:17 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Johannes Thumshirn <morbidrsa@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] mcb: lpc: Convert to platform remove callback returning
 void
Message-ID: <pxr2p4vvn4fr2n7f3eda2geqh5zabmresgj3gfqrls7dag7f2n@abfxhyxszjgc>
References: <20240307175903.189283-2-u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wq7vd63prnpqrjal"
Content-Disposition: inline
In-Reply-To: <20240307175903.189283-2-u.kleine-koenig@pengutronix.de>


--wq7vd63prnpqrjal
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Thu, Mar 07, 2024 at 06:59:03PM +0100, Uwe Kleine-K=F6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

I didn't get any feedback in reply to this patch. My quest to change the
prototype of struct platform_driver::remove depends on that one, so it
would be great if it could make it into the mainline during the next
merge window.

I added Greg to Cc: who's tree the last changes to this driver went in
through. If I don't get feedback until v6.9, I'd ask him to take this
patch without further maintainer feedback.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wq7vd63prnpqrjal
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYXj+QACgkQj4D7WH0S
/k4TEAgAqZjPh6n78yTVmTKep+OdZns+WPVdXyg64mfhi5xyiPnq9UR60jCpd0KL
mLz+w7I4UEWKcEzapFmVtIAM65GMCph2NTsemU7tYP4E4dzFSZi1CkncxSBeLCnv
z9KwcnPN5v05c304rHpvQU/UY1cIBQmoNIZvz621P67pJTpusqUnjJo8p7vxsKLL
kKxsaXBfuxHLQtdT7lWAoDnfdsoFlWswLQkagr8VL/Xq+hA5728ylggHkBBYG0VI
7kruUnBBf+CQZ6BH0sUWmDHufqV7mMwNqHLpynGyrJs7V+7a3H/tgx4ZhWdrz4I7
hHyw0X5CZ+JWxwneD4Z0A5oBjyRTlA==
=PYdu
-----END PGP SIGNATURE-----

--wq7vd63prnpqrjal--