Received-SPF: pass (google.com: domain of linux-kernel+bounces-139936-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <2fb5426c-56ff-4882-8b2e-c68fbc723c8e@amd.com>
Date: Thu, 11 Apr 2024 09:09:30 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 04/18] i2c: cadence: remove printout on handled timeouts
To: Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c@vger.kernel.org
Cc: Andi Shyti <andi.shyti@kernel.org>, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <20240410112418.6400-20-wsa+renesas@sang-engineering.com>
 <20240410112418.6400-24-wsa+renesas@sang-engineering.com>
Content-Language: en-US
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240410112418.6400-24-wsa+renesas@sang-engineering.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aW1nQTVJVjNrZ21JQU1MQ3ZxV3ZKQ09DQ09iUHBFOUJzWnFQOWxaei9WK0Er?=
 =?utf-8?B?QjhzOGt5bURqVjExMUorMTJpM0MvQzlYV3NQdlNKYlJzS1pseG9vRWZHYjJz?=
 =?utf-8?B?dG5XT3NJM2Nzc2hPMzJTZG9qVm1mb2N3ZXhnSDlBZVA5RVB5ZlV4WjgzckNn?=
 =?utf-8?B?TzN4RnRTMFVnekVzNHBtK0FLSTFydEdnU0FsRFBvRGNQd29SSS9zd244aTRn?=
 =?utf-8?B?YkxpeTg2RjUyTHA0WGpaSzdDdjZybGhMZXczeTlidmhXbXlIUGJ1RUhCUE5t?=
 =?utf-8?B?K0hpUG5POUpmVmU2THc5UThJdzV1S1djdXJPaDFPUjYrLzlUQTJPZlJXbEF6?=
 =?utf-8?B?Y1llUkF6NHlHK0VzYWhqUjNLNURRNklSRkdsekRMenEwSVRCRnB6OG5xMGZG?=
 =?utf-8?B?RUxld0M2dnVhcDV6QUFFYWIrWWtqZHd2RXpPWmVZTHcwTlN3Um92WXU3WC9s?=
 =?utf-8?B?eHNML2EzYklNUjg2QVQyQTMrbEFYa2s5UHdOc3h1UVJYNDNKNi9iYjk2b3Zx?=
 =?utf-8?B?aWtoMnBqTC90K1FTWkdIQUdWZk1qTkhncXJZbnFrcnpwSWh6d3dodEROVkNJ?=
 =?utf-8?B?K0JJZjltakJWaEFvbkVTRDZOb0dwd1JZYVBrMlZRaEV5RVl2R2tFeWx2UXlU?=
 =?utf-8?B?LzEvN1RMUitJQlZPWW5kRmFQcEFnZXJxQkZRVkxmUDgwcnkxZm9xTDQ4R2FR?=
 =?utf-8?B?UXVoNkd0VEV6UEhHaFhpVDkwRGIwb1ZVZFRYODJ1dmJ2TExUaUcwOG1KdExt?=
 =?utf-8?B?cnNtdFdoeXZUaHdMOWJTRkd5LzVvOTllREg1dmxQdGJ1ZnR3ZmVzN0xKditS?=
 =?utf-8?B?bUFYZzQxTlVERnU3UlJmOUo3anJWSXNVQ2lHU2VmMUZ5S1BQVlNKN3BQeVFM?=
 =?utf-8?B?VUdNaUg2dmpNYk44WVdLSStqNGNBbDFEbCtCNUM3SlltbTFyTmxmYVc2YjFi?=
 =?utf-8?B?YWlXT2dvc0xlbEZkMDQrS2VUM0M2NWI3akJrRnlMcGlWS0RpUzBjZk42dTI4?=
 =?utf-8?B?QjNpN2F6Y01UeWlYbVVWUDNpSGt6RUhIOGpJNEh5eXJBb2xIdXBRWUI2WXR5?=
 =?utf-8?B?ckVEWkowR2prNGNFbkI5dDlFVGQ1ZjdCcXpFOFhOcThaYkxyR29WeGxtcFpN?=
 =?utf-8?B?aHBOQ0RBckRKSStkWkFvZzFkaVBBTC9FUWNLV3FtZ2dUMVI5VVdTeXdzaXhZ?=
 =?utf-8?B?VFF4djZmdmZ4MjViMitiK0dRSW5kc0VGQWtaQTFRSXIyV2V2QUY1YUVyUkIv?=
 =?utf-8?B?YktNY0U5MlQ0T0dXYjVTQ2g0NUt6Umg5U0dyUFZoK1dQbDM2M3V2VzJKVjhi?=
 =?utf-8?B?VHpRdEJ6bEM4cmJmamczbkcwUmxEcURxM2lwVGk4N0M0aGtWeEdNNGQrK0VF?=
 =?utf-8?B?WU1ncmhERDNvNzZnQm1FbTRMaVFTbFdJZ1EvRTRTd0JkRkJTTTdiZWMrM2xo?=
 =?utf-8?B?NHFuenR4b0tDUThlTkdBOGJ3UFFUN2RqVTl3cVRiUk9Gc2cxbmo5R21QT0s2?=
 =?utf-8?B?QXg2VWFBa0VqeFdIYXJPOFVoVkdJZDRaSHJXWGhod0l6SWZrRTlpTXh4ZXF6?=
 =?utf-8?B?czBweWtIbXlNVVgvdUFNWFdEVFpXd1UrZHFmaTFFcHB6M3FaZXBoSUhubVZh?=
 =?utf-8?B?V3dSUFBJYWVNNERqZVNtWDlBQ3BPWHFjaG9uVFhEaUJNcGNsaTRrem1wYitC?=
 =?utf-8?B?a3lVdWVZTkJKWVhpa2VCaDJGS0pSZkVBMzQ3KzNEQTBsN1NkR2JQbTVNZlhi?=
 =?utf-8?B?ZWhFd2hqS1JVcWVBeUZKV1pMZ2l6WEVxRlBtb3FjY0NQS08ydVZUaFZVM3dq?=
 =?utf-8?B?cVcxaVhrSy82eHRDRS82Y3Y0VWRFRXdiMjVCMnkxYlJWT1FGNXNFVjd3SG9m?=
 =?utf-8?B?cmlFd2tpcHlmRU1WMEZXMjVGRXBXTmp1NVUyVjFpR3ViQi9Nbk52emtBMG1B?=
 =?utf-8?B?OXJYVW41alIvMzRIeXVIM0lScFNCeGs0MHJsVDY0VSs3KzJzUkRvUVhCTXdK?=
 =?utf-8?B?NkljbmhqZHNObTBGZklEWFhQQm1LdEduemwrYnluVjFXWXdUR1RPSUJONnJJ?=
 =?utf-8?B?bFVodnoyeGxuUnBKUTJ1Q2xleHVzZDY0ZTIvdFk1UHpmZ1AvWEVGT2x4ZEZP?=
 =?utf-8?Q?tDTTSrwtOT5+rL77PCNa4NnSr?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 533e89ac-f775-4ba5-e72d-08dc59f657ca
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 07:09:35.0265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d/T9WnPAsQ83iqRD0dNAYstNEIpOssFBDlbgErU62SwqA0eNEBcGlQnWOMrcnTCD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6735


On 4/10/24 13:24, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>   drivers/i2c/busses/i2c-cadence.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 4bb7d6756947..1b0006e3b95c 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -789,8 +789,6 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg,
>   	time_left = wait_for_completion_timeout(&id->xfer_done, msg_timeout);
>   	if (time_left == 0) {
>   		cdns_i2c_master_reset(adap);
> -		dev_err(id->adap.dev.parent,
> -				"timeout waiting on completion\n");
>   		return -ETIMEDOUT;
>   	}
>   

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal