Received-SPF: pass (google.com: domain of linux-kernel+bounces-140000-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6e8e553b-8c5f-404a-a396-17d8b3440d93@collabora.com>
Date: Thu, 11 Apr 2024 09:39:25 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: mediatek: Support MT8188
 dual-core SCP
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "olivia.wen" <olivia.wen@mediatek.com>,
 Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>, Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>, Matthias Brugger
 <matthias.bgg@gmail.com>, Tinghan Shen <tinghan.shen@mediatek.com>,
 linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org,
 Project_Global_Chrome_Upstream_Group@mediatek.com,
 jason-ch.chen@mediatek.com, yaya.chang@mediatek.com, teddy.chen@mediatek.com
References: <20240411033750.6476-1-olivia.wen@mediatek.com>
 <20240411033750.6476-2-olivia.wen@mediatek.com>
 <5cf005b9-d737-4509-a9fb-f0e59465482c@collabora.com>
Content-Language: en-US
In-Reply-To: <5cf005b9-d737-4509-a9fb-f0e59465482c@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Il 11/04/24 09:34, AngeloGioacchino Del Regno ha scritto:
> Il 11/04/24 05:37, olivia.wen ha scritto:
>> Under different applications, the MT8188 SCP can be used as single-core
>> or dual-core.
>>
>> Signed-off-by: olivia.wen <olivia.wen@mediatek.com>
>> ---
>>   Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml 
>> b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> index 507f98f..7e7b567 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
>> @@ -22,7 +22,7 @@ properties:
>>         - mediatek,mt8192-scp
>>         - mediatek,mt8195-scp
>>         - mediatek,mt8195-scp-dual
>> -
> 
> Don't remove the blank line, it's there for readability.
> 
>> +      - mediatek,mt8188-scp-dual

Ah, sorry, one more comment. Please, keep the entries ordered by name.
8188 goes before 8195.

> 
> After addressing that comment,
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> 
>>     reg:
>>       description:
>>         Should contain the address ranges for memory regions SRAM, CFG, and,
>> @@ -195,6 +195,7 @@ allOf:
>>           compatible:
>>             enum:
>>               - mediatek,mt8195-scp-dual
>> +            - mediatek,mt8188-scp-dual

same here.

>>       then:
>>         properties:
>>           reg:
> 
>