Received-SPF: pass (google.com: domain of linux-kernel+bounces-140013-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID:
 <SEZPR06MB6959E563B692827A3E5152DD96052@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Thu, 11 Apr 2024 15:44:33 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC 1/2] clk: hisilicon: rename hi3519 PLL registration
 function
To: Stephen Boyd <sboyd@kernel.org>,
 Michael Turquette <mturquette@baylibre.com>,
 Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>, Igor Opaniuk
 <igor.opaniuk@foundries.io>,
 Jorge Ramirez-Ortiz Gmail <jorge.ramirez.ortiz@gmail.com>,
 linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240225-pll-v1-0-fad6511479c6@outlook.com>
 <20240225-pll-v1-1-fad6511479c6@outlook.com>
 <d8dc639c2c6d188d2ce3728573d9a53d.sboyd@kernel.org>
Content-Language: en-US
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <d8dc639c2c6d188d2ce3728573d9a53d.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SEZPR06MB6958:EE_
X-MS-Office365-Filtering-Correlation-Id: 1e83d031-8fb3-4bdb-f6d5-08dc59fb3e11
X-MS-Exchange-SLBlob-MailProps:
	Cq7lScuPrnqJKUMRjg6lpwFly6pLS7oBG38mDNplFPHYnvKqiofdj5Nsy91x4Pf2e/nPhl0eEYj8pD0kNFzDJ7svFqRrk2jbCwAAgIC5LvcCQ+OqvaD3IWFFKbnK9BgeLWRVFGAP94ofBkzOzireFYUitk/rN5VbhIOP/o3ldVuJWBtlP3tLKjSwwws68P2/0tn9j70KstH03OGiyefRnfqhr+/DiXz9ag8sqaq62juuu02OtThToaa2dE1DysxOhanN3XSqN6z6wkFtyC9oW0cJUIZ5svFvHxe56ET7Viv0Nfj83uOzoHsdAlRLruEsC2ylxliEKm1BiqUbQXSi/EMkwNLN48ceDVvoUYLz6OB/biQvjR4MBouZ/rOKo2UubsHml7A+2WjGnYSVxHU/ExunLtZRJExa8bvujNOT//HmmyJpcBSFtPlDHBe69s8RROluz00dmOxqWotR/Ypd6vYef65uBefnW2VRoSu68dgFlao6SNG0QHCWj1E+rSHFlaB7fsim5yeC7wMYiHRodFok4Go+h73A4R5/WAPP/GOAff8eO/hH+/NST4Yc2y8serlr1mhHahCdlj8LhgVnSCkKZHtYAG+8OMoH8uiokINbYo0VI/h5Mms+AXSvgiBjJ33yx/8YTO4CEBCRlXqhr8szEEoIQfvwmK9jG4EcgSSWEt3aKLjsCfKcyJWEWEV8lhpCd8RHLFyQh8Go8FhQ7FOHt/Gkbuanp9ReyKapwvIvU+UKLTFSUj2+ML3ovwmy009VZ4eEgiU=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	B2YpWrLeJ1mJk/wa0e04HVxvZXbJjDb3wm+pf5Yy7UWedBTWEe4Z+VmUEEw8DJncl+gTDBR0jrYKfrz3ovbMvZsLo5BUQyUJrA3SRqi18hmyMfmsA8lYNO+bMQS1n97WLJfTc3qfRmw0lqluo+02mlEpTaXmwb7N6W4cqQN1YqwPJQfsi+S/pDF/8USLbGIKNp/U0TBtKSKBDSAAbizrlHZRPSEXeIJ2WGJ7BZwBXuOC3nFPrXmainQ3kBMqlztRgbMfkTbIAXP03ap3IhA+Z/tXligpoesKCTS5S0s2pixy2mYx8Uo0qeeVM/68xM7+swj4oNbRcHSbJlmR3xtU+JLktIo7CVNPGgpvl4tDYFcFPz6H1qKI60FsmeURZs4hGqSRA4ub8D8SXm8+Sa5yD7OdRd63dCjqa6tKA+357z8LbA8GRXrl1BHnhbTKEFK8xz9679p9u9eTwQ3WiI7Che3HsrXZmG7FpmEgTMsA3JyoWu9KK5RAx98KBeC/kW1tQyltup0ZppClOICBOZOhgbKM9AXEJI3pzlewDT2myIGWZbbAS0L7LxrV1QQyMXLT
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?STEyL05mTnQrd3JXbmFQLzNRaHJoTEUxWU1EWGRLWEx2QmEvejZnUENpSUkz?=
 =?utf-8?B?MTZJTnZLeFJEWXlLSDI1SWdLQXVvUHFPWS9DUEtFTFAxbURXdWFFdUtnZUZZ?=
 =?utf-8?B?ODQ0QmczMjh6a2hGcDh3L3RuSXJRRW5ZS3hyei84bVJEeXBLd1Y0T1JlcXNQ?=
 =?utf-8?B?S2xJWkkxK2REZXhybFZXZFUwRnVZNXZiMVBTNDBQSG1ST3RpOTFhV0JDQVZC?=
 =?utf-8?B?S2VMaWhTa1dZOExqcUlUNzEyaWszWk5IS1RqT0t4M29kQk9xQ2pNTW5MRG5m?=
 =?utf-8?B?eCsySDBQV0MvWFJ6Ymh1bHZWdVNzRlQ2aHZmdUd1b2dMZFNvMDJsNWtUL0JR?=
 =?utf-8?B?bkFBVVBBUFhYMjBhTTFlSVU0YVN6WlFia2cvR3hrU3dwRXcyWm9rOWU5U2F2?=
 =?utf-8?B?alB6WllmOHFPRUE0R2tab3dwR242aHlIV0JLYlZRaHJvVEFxWmVKaUFMSHkv?=
 =?utf-8?B?YUg2NzRvNDRoZDVTVWMyVFV5TzY5Y1pGbVd4dTR1U254dG8vZzExQ0c5SEYx?=
 =?utf-8?B?NG5BdkZhTjZHUloyUXBzNW81NVVXUHZTSW9YQzh5c0FJWWxwcndIbGIrWmgr?=
 =?utf-8?B?RDU5VHVjU0gyZXVVdVY3ZUJ6VVhlaStRMEFHL3pEZlVJb0xrQXdoRndJQnI4?=
 =?utf-8?B?b2tTek9lbEs2bzFLY0dnNXpoclRzZGxNMzNvc2JnNU1ka0YrZi9MWkFrTSt4?=
 =?utf-8?B?c2R3RjUycENDcWJlSmk4MlJ5WlEyMGpRdExNVTZYaEM4ODdjQ1p5dXg3YnZK?=
 =?utf-8?B?RjZMZWpYRWJVUm9rQ0dGRHRQYm44aHo3YWpFNnhTUm05L2xjbzdXUDF4cjRh?=
 =?utf-8?B?QUZabVJjZjI0aDZqNU9DNWJiazRKSldvWWlXT3NUN3Qxa1lPRkhJNXVDbTNu?=
 =?utf-8?B?R2FRdEczUTI4L25zbDdQZHhNOUxvaTIvVWxjNWRQZG43djVnK0VObys0ZUYv?=
 =?utf-8?B?MjNqdEJOSlZ5d0V6THMrdXJPVHpldW1teXFiVDNiVitkYVlIZCtjTzFtQ1lR?=
 =?utf-8?B?M2NVQVhNZGVNaGNidUJwaSsrVW5ZZmVwVnczWWovUGM3K2FIQ1hROWIzNzFJ?=
 =?utf-8?B?UCs3SlJkenZwZVBwYWlDQUxuUWplVXhCTjA3S1phKzJiMUErMmtsYXlpY3Z0?=
 =?utf-8?B?L2hTR3RTR0pTengvM2gvNnFZdU1oU2oxWWNsUXJWSzQvQUw4RzI4RCtuM2Zr?=
 =?utf-8?B?TjN5ZnN1UThLaEZZR0RqVEVzbHgvcFUvdGNPcTRYRXh0WVlvczdUdkVYYS9Z?=
 =?utf-8?B?UEhCUit2YWp2T2ROeXA3NVEyNno3d2lmeHZwbis4aUxzUmFsTUZUMllGMXJI?=
 =?utf-8?B?eWN6VjdYbDVteWlJaWoyTWVlZHRwR3FTaWlrZzlVRGZBWVpFSFVzb3BqWnpK?=
 =?utf-8?B?Uk1WWU5MMllsWC9PcEVpci9nd2l6b05rbFUyeVJpeWo2MUlyVVRlNzlpODdz?=
 =?utf-8?B?NVBTVGdUQWIvYkoyT25zTjRrYkdVNXZYblNqcjlVQWZBcnBhbWVBQzFENEVG?=
 =?utf-8?B?RkNlU2dhdzZ2dTVWMHVkbVVSMmVPZmw2ZXh5NXVTck92VzhLeHkxWTM3Mjdn?=
 =?utf-8?B?eCtUbGcrTDRncFF1QVhJdytOTVFScHZBYUhRSEcvdjVKaXpIOWtpT1JudXh1?=
 =?utf-8?B?UnNORU5NS0N2NWJDblQ2cUJkdXZDM3JCK29pUTAxSXE2a1c1NVg5QVlEYzJz?=
 =?utf-8?B?SS9MVU5ScGh0NXZ1N1lDREVlaktyakZrV1A3aE5PNm9PeWVVK3BGTEpBaW5o?=
 =?utf-8?Q?CHJjIGpcKMIGIJAwL5BAMii+xKo6YhRZeseH4Fi?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e83d031-8fb3-4bdb-f6d5-08dc59fb3e11
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 07:44:39.5447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6958

On 4/11/2024 2:52 PM, Stephen Boyd wrote:
> Quoting Yang Xiwen via B4 Relay (2024-02-24 08:56:09)
>> diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c
>> index ff4ca0edce06..77fa4203a428 100644
>> --- a/drivers/clk/hisilicon/clk-hi3559a.c
>> +++ b/drivers/clk/hisilicon/clk-hi3559a.c
>> @@ -452,7 +452,7 @@ static const struct clk_ops hisi_clk_pll_ops = {
>>          .recalc_rate = clk_pll_recalc_rate,
>>   };
>>   
>> -static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks,
>> +static void _hisi_clk_register_pll(struct hi3559av100_pll_clock *clks,
> Prefix it with hi3559a then to be SoC specific please. But this is also
> static so I'm not sure why this patch is needed at all.


it includes the header that marks this function non-static. Also the 
prototype is incompatible.


-- 
Regards,
Yang Xiwen