Received-SPF: pass (google.com: domain of linux-kernel+bounces-140016-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240409-rzn1-gmac1-v2-0-79ca45f2fc79@bootlin.com>
 <20240409-rzn1-gmac1-v2-4-79ca45f2fc79@bootlin.com> <CAMuHMdX-F8LXWx=Ras4f+Dt_r485HKjRDLydDXZsnZBW8HJzxw@mail.gmail.com>
 <9bd8eee4-952d-d5b2-c462-45c1466c54d6@bootlin.com>
In-Reply-To: <9bd8eee4-952d-d5b2-c462-45c1466c54d6@bootlin.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 11 Apr 2024 09:45:27 +0200
Message-ID: <CAMuHMdVAB8CuSkrnp+b7-+s3v0eHLr0Lvm1=MveGMVRW3T9T-A@mail.gmail.com>
Subject: Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC
To: Romain Gantois <romain.gantois@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Geert Uytterhoeven <geert+renesas@glider.be>, Magnus Damm <magnus.damm@gmail.com>, 
	Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, 
	Maxime Coquelin <mcoquelin.stm32@gmail.com>, Russell King <linux@armlinux.org.uk>, 
	=?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>, 
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-renesas-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, 
	linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Romain,

On Wed, Apr 10, 2024 at 2:24=E2=80=AFPM Romain Gantois
<romain.gantois@bootlin.com> wrote:
> On Tue, 9 Apr 2024, Geert Uytterhoeven wrote:
> > > +config DWMAC_RZN1
> > > +       tristate "Renesas RZ/N1 dwmac support"
> > > +       default ARCH_RZN1
> >
> > Why default to enabled?
> >
> > > +       depends on OF && (ARCH_RZN1 || COMPILE_TEST)
>
> The kernel doc states this as one of the possible cases where setting def=
ault
> y/m makes sense:
>
> ```
> Sub-driver behavior or similar options for a driver that is =E2=80=9Cdefa=
ult n=E2=80=9D. This
> allows you to provide sane defaults.
> ```
>
> In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default =
n", and
> I think it makes sense to enable the RZN1 ethernet controller driver if b=
oth the
> stmmac driver and the RZN1 architecture were explicitely selected.

Thanks for your answer, that makes perfect sense!

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds