Received-SPF: pass (google.com: domain of linux-kernel+bounces-140012-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240409173921.1080616-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240409173921.1080616-1-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 11 Apr 2024 09:43:48 +0200
Message-ID: <CAMuHMdUm77VFSraw0KTKYoUknZ4Eyfgt9GeP9T-0_ET7L_zVsA@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] auxdisplay: charlcd: Don't rebuild when CONFIG_PANEL_BOOT_MESSAGE=y
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Tue, Apr 9, 2024 at 7:39=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> When CONFIG_PANEL_BOOT_MESSAGE=3Dy the module still includes
> the generated header and gets rebuilt even if it doesn't use
> anything from that header.  Include generated header conditionally
> to avoid unnecessary rebuilds.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for your patch!

> --- a/drivers/auxdisplay/charlcd.c
> +++ b/drivers/auxdisplay/charlcd.c
> @@ -17,7 +17,9 @@
>  #include <linux/uaccess.h>
>  #include <linux/workqueue.h>
>
> +#ifndef CONFIG_PANEL_BOOT_MESSAGE
>  #include <generated/utsrelease.h>
> +#endif

Perhaps move the existing "#ifdef CONFIG_PANEL_BOOT_MESSAGE"-block
up, and move the #include inside the #else branch?

>
>  #include "charlcd.h"

Regardless
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds