Received-SPF: pass (google.com: domain of linux-kernel+bounces-140059-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: jackson.lee <jackson.lee@chipsnmedia.com>
To: Ivan Bornyakov <brnkv.i1@gmail.com>, Nas Chung
	<nas.chung@chipsnmedia.com>, Mauro Carvalho Chehab <mchehab@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>, Sebastian Fricke
	<sebastian.fricke@collabora.com>
CC: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/5] Wave515 decoder IP support
Thread-Topic: [PATCH v3 0/5] Wave515 decoder IP support
Thread-Index: AQHah3gdQC6P/IVPV0iUT4LRIjlhhbFiwQfQ
Date: Thu, 11 Apr 2024 08:13:39 +0000
Message-ID:
 <SE1P216MB130385EC5A67C80D9CB61522ED052@SE1P216MB1303.KORP216.PROD.OUTLOOK.COM>
References: <20240405164112.24571-1-brnkv.i1@gmail.com>
In-Reply-To: <20240405164112.24571-1-brnkv.i1@gmail.com>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?aUjfZ+oI7lzg5bxe34LXo4A7+x/8e9hQptML95o03sxFxwTQjVN5wY3ExHqQ?=
 =?us-ascii?Q?vPCyOlV+NoGm1Z+MedpC6Tyr4ZwaPvWPYqR1veJjn8dfI4qMO5PBFBKoSpxS?=
 =?us-ascii?Q?PA3oj/ql/QPvkKREQNIKC1vKId8H/tHho+wvAzDbsTbQHe8R7u7avBsSHR9N?=
 =?us-ascii?Q?9oAiOoJuIwbvCngZyr3mC03CpOibsMDA7FdEXndoQw52dXJ2kjBOtTqjtISM?=
 =?us-ascii?Q?YFIq3vbBsixo50GXnD77K9CtZECSBCe76uWtjsVed20Mq2b6Gr6XWtccR458?=
 =?us-ascii?Q?a7YlAt1pEswVE4kCNn+IGVkLe+lzP7ZRSf4FPXRZlqITpgnAiY+YeuSXuk/g?=
 =?us-ascii?Q?XVomH9r8LS6iEzkgPdo5l9t7yJkdl3kSciF1Ndzb0bWId0Mzb2Zwsea3IY9j?=
 =?us-ascii?Q?ykcI9y6EeGVBqiFt6Z74LvDJ0FsGdh8cmm4iI2MsJBJRVAaINGrss6YzzfLQ?=
 =?us-ascii?Q?nBR8/uMKB2U8gcfDxLpNtZ3s0/8CaqxcqCeFUlSdOKpB6rYVqCKpnTxBOgyW?=
 =?us-ascii?Q?ULdpr/Y4jCYTJquQmUJZO5F8aRm5o/EA8hQKngUl7Em0Waw48rTJa/pYDhuu?=
 =?us-ascii?Q?eqM262FaMwQRk860Pt4V7haWybx0SJ1o6ErQlUzhIdJ/LouaUUcqmCMZpBUf?=
 =?us-ascii?Q?1EsYZZInwHRreWzDQFw0XxpJFhkMrSKhPdNHSJBOeB30SsDhC2nRTZw5ESTI?=
 =?us-ascii?Q?gABLZEtoQFOBSM3bLL6Afi5NRIDINLaA084bZVHhAThGK7INMhVDALwtVOGv?=
 =?us-ascii?Q?b+mp9wHjc1OfiTW1a0cGlFgvoKCEKmD7B4J4s4X3fD5vPHHFcKmGNHTLZOst?=
 =?us-ascii?Q?ZJMlrRD0jaHEYIo/cI6FVeo7yTOmYxl6sPjC6BmSImC8KeRdP6NcK9kqrirC?=
 =?us-ascii?Q?fPrMWidJnMCdQOMtbmizMUDmQBwOunMxDS7L9fyaKF1gnXuxXyRyGTYmQoOu?=
 =?us-ascii?Q?ZfhYc3AYc+2D3P78R107o/3H22PbaLg0RAKfbgXDsFLR6yYTeqZ8DO0zZYsU?=
 =?us-ascii?Q?rViin4cwbaAgiBxRb1KsQ1DbLo0XklJ53X7Ssr9TWRBohXFLP+v6KHY5T0mn?=
 =?us-ascii?Q?6yksPsMd0S+7UZHbCKIXgjoFxoH6e1F8n8PXdG+WWTVDhF9KBW95LD7CNLCe?=
 =?us-ascii?Q?0G5tQbA1aOcBUValZX9l/6hCKfypPBIMS1CKbKMbiI9ZBqwDrWDk15iUVOP+?=
 =?us-ascii?Q?xwx/aOsGNwjdeaJ6lympw2VH+tjOy50ecTbjdjbKOiTLA+MnQSoj3K0luBRd?=
 =?us-ascii?Q?77YCc0CJ9jzAusxDVWLCR3eJ3jfOp4apGdgeSA/za3XMvxe5ELTSmh5vCiLU?=
 =?us-ascii?Q?rex1izYxV2PAd7ZK14p/ayHO1RbrYtX3YwSVgXjxx/+QQldlfxQ59YCgyzM9?=
 =?us-ascii?Q?iRgjQizJiETzoXZ9wUlULy2vXCrTUqoJVZGaeJCf/9UD+B/foqfu082tOm1S?=
 =?us-ascii?Q?80pkTXHqUCADXHfkyK/ogV3EcwEllXIkzujMWD20ixSuHdfAch+9j5aVpp3K?=
 =?us-ascii?Q?RgqLA8V9jlXpVL+9ApbjcgmCoKgfAKLW2NZg3GE8jthKN0K7KzYgjVxhWCdm?=
 =?us-ascii?Q?WlT6vDkFvFPm80S4bT7JnOmla1QQRD5uSbq0DnqH395VGtmvkHfXEEi2HiKv?=
 =?us-ascii?Q?Hw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SE1P216MB1303.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 08e3e6a7-de1e-4516-6a3d-08dc59ff4b71
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2024 08:13:39.6737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PT8VdJsTL3ez8hVDik/tAGLviq2FeEu6w3MmnmxM8MMvE1SZQAb0cTbUDLwoIekRB5Qb52s5d8SZnduOWt1j9s7Ra2HwiMqLEsctml0jGPA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SL2P216MB1692

Hi Ivan

Can you provide a score for testing a fluster tool so that we can verify th=
e change on your HW?

Thanks
Jackson

> -----Original Message-----
> From: Ivan Bornyakov <brnkv.i1@gmail.com>
> Sent: Saturday, April 6, 2024 1:41 AM
> To: Nas Chung <nas.chung@chipsnmedia.com>; jackson.lee
> <jackson.lee@chipsnmedia.com>; Mauro Carvalho Chehab <mchehab@kernel.org>=
;
> Philipp Zabel <p.zabel@pengutronix.de>; Sebastian Fricke
> <sebastian.fricke@collabora.com>
> Cc: Ivan Bornyakov <brnkv.i1@gmail.com>; linux-media@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH v3 0/5] Wave515 decoder IP support
>=20
> Initial support for Wave515 multi-decoder IP among other refinements.
> This was tested on FPGA prototype, so wave5_dt_ids[] was not expanded.
>=20
> fluster score for JCT-VC-HEVC_V1 testsuite with
> GStreamer-H.265-V4L2-Gst1.0 decoder is 132/147
>=20
> The issue with Main10 tests is that fluster expects decoded file to be in
> yuv420p10le format while this driver decodes HEVC Main10 into 8-bit
> yuv420p. Though result is looks alright to the naked eye, proper decoding
> into yuv420p10le is to be added.
>=20
> The rest failed fluster tests are common with Wave521.
>=20
> ChangeLog:
>   v1:
> https://lore.kernel.org/linux-media/20240318144225.30835-1-
> brnkv.i1@gmail.com/
>   v2:
> https://lore.kernel.org/linux-media/20240325064102.9278-1-
> brnkv.i1@gmail.com/
>     * drop patch "dt-bindings: media: cnm,wave521c: drop resets
> restriction"
>       The only user of Wave5 in mainline is TI K3 boards, thus there is
>       no real need to alter dt-bindings
>     * in patch "media: chips-media: wave5: support decoding HEVC Main10
> profile"
>       add check for flag "support_hevc10bit_dec"
>     * in patch "media: chips-media: wave5: support reset lines" move
>       reset_control_deassert() out of else branch, add
>       reset_control_assert() to probe error path.
>     * rework patch "media: chips-media: wave5: drop "sram-size" DT prop"
>        - don't move alloc/free form device open/close
>        - intead of exact configuration of reserved SRAM memory in DT and
> 	 allocating all of it, allocate all available SRAM memory up to
> 	 WAVE5_MAX_SRAM_SIZE from whatever pool provided.
>     * adjust patch "media: chips-media: wave5: support Wave515 decoder"
>       according to changes in patches
>       "media: chips-media: wave5: support decoding HEVC Main10 profile" a=
nd
>       "media: chips-media: wave5: drop "sram-size" DT prop"
>   v3:
>     * reword patch "media: chips-media: wave5: separate irq setup routine=
"
>       a bit.
>     * in patch "media: chips-media: wave5: drop "sram-size" DT prop"
>        - move MAX_SRAM_SIZE define into match_data->sram_size
>        - add placeholders for validation that allocated SRAM memory is
> 	 enough to encode/decode bitstream of given resolution before
> 	 setting W5_USE_SEC_AXI and W5_CMD_ENC_PIC_USE_SEC_AXI registers
>        - reword accordingly
>     * in patch "media: chips-media: wave5: support Wave515 decoder"
>        - add comments around SRAM memory allocation/freeing about
> 	 Wave515 specifics
>        - add comments about BSOPTION_RD_PTR_VALID_FLAG bit in
> 	 W5_BS_OPTION register
>        - add W[AVE]521_ prefix to defines, for wich there are W[AVE]515_
> 	 alternatieves
>        - add semi-magic Wave515 specific formulas to estimate SRAM usage
>=20
> Ivan Bornyakov (5):
>   media: chips-media: wave5: support decoding HEVC Main10 profile
>   media: chips-media: wave5: support reset lines
>   media: chips-media: wave5: separate irq setup routine
>   media: chips-media: wave5: drop "sram-size" DT prop
>   media: chips-media: wave5: support Wave515 decoder
>=20
>  .../platform/chips-media/wave5/wave5-helper.c |   8 +-
>  .../platform/chips-media/wave5/wave5-hw.c     | 395 +++++++++++++-----
>  .../chips-media/wave5/wave5-regdefine.h       |   5 +
>  .../platform/chips-media/wave5/wave5-vdi.c    |  27 +-
>  .../chips-media/wave5/wave5-vpu-dec.c         |  51 ++-
>  .../chips-media/wave5/wave5-vpu-enc.c         |   2 +-
>  .../platform/chips-media/wave5/wave5-vpu.c    |  35 +-
>  .../platform/chips-media/wave5/wave5-vpuapi.h |   3 +
>  .../chips-media/wave5/wave5-vpuconfig.h       |  16 +-
>  .../media/platform/chips-media/wave5/wave5.h  |   6 +
>  10 files changed, 407 insertions(+), 141 deletions(-)
>=20
> --
> 2.44.0