Received-SPF: pass (google.com: domain of linux-kernel+bounces-140160-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a2683fad-07db-4857-9ebf-7adf31a09e50@huawei.com>
Date: Thu, 11 Apr 2024 17:21:05 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bcachefs: fix typo in reference to BCACHEFS_DEBUG
Content-Language: en-US
To: Lukas Bulwahn <lbulwahn@redhat.com>, Kent Overstreet
	<kent.overstreet@linux.dev>, Brian Foster <bfoster@redhat.com>,
	<linux-bcachefs@vger.kernel.org>
CC: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Lukas
 Bulwahn <lukas.bulwahn@redhat.com>
References: <20240411082931.56362-1-lukas.bulwahn@redhat.com>
From: Hongbo Li <lihongbo22@huawei.com>
In-Reply-To: <20240411082931.56362-1-lukas.bulwahn@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Also, I am curious why such spelling errors cannot be detected at the 
compilation stage.

On 2024/4/11 16:29, Lukas Bulwahn wrote:
> Commit ec9cc18fc2e6 ("bcachefs: Add checks for invalid snapshot IDs")
> intends to check the sanity of a snapshot and panic when
> BCACHEFS_DEBUG is set, but that conditional has a typo.
> 
> Fix the typo to refer to the actual existing Kconfig symbol.
> 
> This was found with ./scripts/checkkconfigsymbols.py.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> ---
>   fs/bcachefs/snapshot.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/snapshot.h b/fs/bcachefs/snapshot.h
> index b7d2fed37c4f..3fdb41b33d2d 100644
> --- a/fs/bcachefs/snapshot.h
> +++ b/fs/bcachefs/snapshot.h
> @@ -77,7 +77,7 @@ static inline u32 __bch2_snapshot_parent(struct bch_fs *c, u32 id)
>   		return 0;
>   
>   	u32 parent = s->parent;
> -	if (IS_ENABLED(CONFIG_BCACHEFS_DEBU) &&
> +	if (IS_ENABLED(CONFIG_BCACHEFS_DEBUG) &&
>   	    parent &&
>   	    s->depth != snapshot_t(c, parent)->depth + 1)
>   		panic("id %u depth=%u parent %u depth=%u\n",