Received-SPF: pass (google.com: domain of linux-kernel+bounces-140173-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 11 Apr 2024 11:27:43 +0200
Message-Id: <D0H6QDTNE0FO.27IGZ1AWYO11S@bootlin.com>
To: "Mark Brown" <broonie@kernel.org>
From: =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
Subject: Re: [PATCH v3 4/9] spi: cadence-qspi: allow FIFO depth detection
Cc: "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>,
 "Vaishnav Achath" <vaishnav.a@ti.com>, "Thomas Bogendoerfer"
 <tsbogend@alpha.franken.de>, "Rob Herring" <robh@kernel.org>,
 <linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>, "Vladimir
 Kondratiev" <vladimir.kondratiev@mobileye.com>, "Gregory CLEMENT"
 <gregory.clement@bootlin.com>, "Thomas Petazzoni"
 <thomas.petazzoni@bootlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@mobileye.com>
References: <20240410-cdns-qspi-mbly-v3-0-7b7053449cf7@bootlin.com>
 <20240410-cdns-qspi-mbly-v3-4-7b7053449cf7@bootlin.com>
 <161eebc1-9417-4ab0-ad8c-c1b17be119b4@sirena.org.uk>
In-Reply-To: <161eebc1-9417-4ab0-ad8c-c1b17be119b4@sirena.org.uk>

Hello,

On Wed Apr 10, 2024 at 10:03 PM CEST, Mark Brown wrote:
> On Wed, Apr 10, 2024 at 11:29:07AM +0200, Th=C3=A9o Lebrun wrote:
>
> > If FIFO depth DT property is provided, check it matches what hardware
> > reports and warn otherwise. Else, use hardware provided value.
> >=20
> > Hardware exposes FIFO depth indirectly because
> > CQSPI_REG_SRAMPARTITION is partially read-only.
>
> This breaks an allmodconfig build:
>
> /build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function =E2=80=
=98cqspi_of_get_
> pdata=E2=80=99:
> /build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1506:45: error: unus=
ed vari
> able =E2=80=98ddata=E2=80=99 [-Werror=3Dunused-variable]
>  1506 |         const struct cqspi_driver_platdata *ddata =3D cqspi->ddat=
a;
>       |                                             ^~~~~
> /build/stage/linux/drivers/spi/spi-cadence-quadspi.c: In function =E2=80=
=98cqspi_control
> ler_detect_fifo_depth=E2=80=99:
> /build/stage/linux/drivers/spi/spi-cadence-quadspi.c:1582:45: error: unus=
ed vari
> able =E2=80=98ddata=E2=80=99 [-Werror=3Dunused-variable]
>  1582 |         const struct cqspi_driver_platdata *ddata =3D cqspi->ddat=
a;
>       |                                             ^~~~~
> cc1: all warnings being treated as errors

I really should fix my kernel compiler warnings. Sorry about that.
Will fix next revision.

Regards,

--
Th=C3=A9o Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com