Received-SPF: pass (google.com: domain of linux-kernel+bounces-140247-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1f14cb75-ee6b-4a7d-9041-23a8cfcd8476@intel.com>
Date: Thu, 11 Apr 2024 12:28:08 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC net-next 7/7] netdev_features: convert
 NETIF_F_FCOE_MTU to IFF_FCOE_MTU
To: Jakub Kicinski <kuba@kernel.org>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, David Ahern
	<dsahern@kernel.org>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, Andrew Lunn
	<andrew@lunn.ch>, <nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240405133731.1010128-1-aleksander.lobakin@intel.com>
 <20240405133731.1010128-8-aleksander.lobakin@intel.com>
 <20240408193806.18e227c8@kernel.org>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <20240408193806.18e227c8@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3A3MFV2NlBEK2hmYTJ2SXNqL0k1cUQrUnoxYy9LTlhEL3ErUHZMUUpGZC85?=
 =?utf-8?B?eDFKNHB5UE91WTM5MDNMTDZ1ZU8xcXFqeklDOUFJNEJQdFdNa01udCtQQXFO?=
 =?utf-8?B?eU5FbFZyQlczcGFUek5DUVR4bFBhUXZPUGE3ZnVVOEd6d1NtdGFoN3hmNHZS?=
 =?utf-8?B?S3B3TjV2UFRxQlNtZDA3S2x0alJkUVEzWCtyRFNyK2Vic01BNW5nbXkya25t?=
 =?utf-8?B?VVZkZXpwblRNbkh2YzR4N3FPMUJGV0ErYm1qRGx1VlZjRng2R05WS2xnUkdX?=
 =?utf-8?B?aWsvZTN1bkd1OFdXQlRicE5JRVRVbmJEZjhoVnZnb0taMHR4TitJRnNka1FG?=
 =?utf-8?B?WlNsL0NZSk5sRnk4SUp0amFZdkVRekVDdWdMWW5ycnFvTWVDQ05UbnlpWkhC?=
 =?utf-8?B?VmdXRzVRQjI2ZEc1RGpCV2hLSnhKdHVZTXQwZGtMYlZVc0lrLzMxeHk5VFJX?=
 =?utf-8?B?SjZZbzlBa2ZOMlZaamM4aEZEbHRxNEZ4by9PSlRHZFZGMzlBekYwSjVDRUlE?=
 =?utf-8?B?ZU04TFFIellzWHNiSjBXd1gxRWFLcWgxVVIzMFBwS1ozNUdxYzJRbitFMG52?=
 =?utf-8?B?YVFwcURKUHZUYjVGRE5FaUdzQWt4S3JxOXJ5WEZLYmVOejFHa3ROa2tyYWZ3?=
 =?utf-8?B?WDVTd0ZXT2pnWDJ5KzhyRlJ3UmtwckxyMmR2L0NXV0dIVitISzB2LzhOTGUy?=
 =?utf-8?B?TVRqditsYzI0Yy9RTFo4UGhrNGdkbCsvYk9LNS83aWtPcnBORkhZOXpaR0NI?=
 =?utf-8?B?UXpXaVZ3ZEExc1lySWc2NEJxd2IvVzFFMnk1NmRSZUlWT2I5M2hrUXVvMDJQ?=
 =?utf-8?B?akpZRkNnVTFkUW9USTBraWFTZjFaelZBdW5tY3V0WnF3MVMzb2RsQ2U0bDBT?=
 =?utf-8?B?d1ZJdnlBR3A0UzdyeVhyVWJUelk5eEhERm90Z1hvWlRuWUtkWnAxVmVNUmND?=
 =?utf-8?B?UkR1STM0UWJXMmxnMmpHUkloTlhleVV3M2VmY3NIcmIrY0owMXR5QXFjOEVF?=
 =?utf-8?B?Mm9YTkhUeGJLTFNtQU1tME9TRmJBK05leXp1ZG9kc2R6T2JacDFScEVLWVhM?=
 =?utf-8?B?K012S3NOdUQzQjFLVi9hWldKUkpka3JoeGF0UEtXT3NFeWNZbnRqRWVaQXg0?=
 =?utf-8?B?TlBsKy9kdnJidHJXVTV1UzI3blUvakMvYlNLanI5ZHVlSTNyM1ZoNFdBV2li?=
 =?utf-8?B?RDNWV3A0VG9pRk9DeWk0cHE3NjAzcmNEWEtkT3VmOHgwUUdFcktMNFRjS0pB?=
 =?utf-8?B?NXUyTEp5Zk5ZUHFBa3NvWEIvbXZCaElIYTVsRkdhMFNtUjAvcHBLV0VkZ3Bp?=
 =?utf-8?B?Z1NmenFoOTd0SWFtKzlzOHA1TnFCZ2ZSQzZUMzEzNzZHWHJjQUpJV0xIQlNl?=
 =?utf-8?B?cThDMEN3NGxaVVNadVJPZk05VHhaK1B4ZjllZDVxVmhteXh0QW1kNHpCZFRG?=
 =?utf-8?B?dVA4NUtic2JvdEpqMHg4TnpNeUw2ZlNSMDJGNWJiWnRXb3VJRUVlUkM3N0J2?=
 =?utf-8?B?NitHYlArS0ZxTUxJQVAyeFhlNEZWbFdJTjZmejMzd3ZKSnRFWER0bjdQcUk3?=
 =?utf-8?B?ME56bzYybE1MWnFWMGdMRkVFdzBLZy9WbVczTUF5ODV3OXpSTms1alc0L3lS?=
 =?utf-8?B?dHBYeDlhNndXSTBHbzNWNnRsRFRqQmYvdStRazNjL0F2c0p3UHVBN2RuKzJR?=
 =?utf-8?B?VVhQdFYzQXAySTg1T1Rjck1ZbnY0MUtRVS8xK2QvbXBtWGFLaWRQS2hVZ0ZF?=
 =?utf-8?B?T296L1Z1QnRyRkpveXE2cmJ0clRUU01aZU53eEE2TlZOOWxjdThlSjQ1OCtv?=
 =?utf-8?B?elN3MUNaL05HZnZoTUsxMFA0TXIwSStMN1o1bXRKdlhzT2t1YnIzcUN2ZXY0?=
 =?utf-8?B?NWppT0wwN2VobUFaRENqVHk4WW92NDZPaFMrbHhzWlBia281RnppRWdIMWhQ?=
 =?utf-8?B?YTY5cUYxMzRaNEV1K3dQcGdHZ2ZKMHZRUm16amRMaTh2T2gxNDFpa21VVmRs?=
 =?utf-8?B?OUlxVWNYaEhEU2NsN0M0bXNnd0VlcmtGaEo2b2lPbE5BaDNnbWg4eW45MjhI?=
 =?utf-8?B?b2dmcHFsQkJLVGoyODhGOGJPUVNqTFdEeHBDWXBRZnZsMERFWmt1UG1uMXh1?=
 =?utf-8?B?VmUrN0tlbFA4cU9kK3NTNG5GdXZhOEVHVDVKOFRKa0pQbzc1Wi82bmkwME5a?=
 =?utf-8?B?SkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ea017eb7-97ad-4f84-ced6-08dc5a1265c8
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2024 10:30:24.5522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2ZFHun9OfyAIt1QcpS4bZmLr02AvVxi2QtYLV0qrs5nmsq6VwDVZ0vz4Av+q5UfMslyZrlSOZ7GkcXQfAu8Udo8BjSf/KAS+g1ZhgItvsNk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5128
X-OriginatorOrg: intel.com

From: Jakub Kicinski <kuba@kernel.org>
Date: Mon, 8 Apr 2024 19:38:06 -0700

> On Fri,  5 Apr 2024 15:37:31 +0200 Alexander Lobakin wrote:
>> Ability to handle maximum FCoE frames of 2158 bytes can never be changed
>> and thus more of an attribute, not a toggleable feature.
>> Move it from netdev_features_t to netdev_priv_flags and free one more
>> feature bit.
> 
>> @@ -1700,6 +1701,7 @@ enum netdev_priv_flags {
>>  	IFF_NETNS_LOCAL			= BIT_ULL(35),
>>  	IFF_HIGHDMA			= BIT_ULL(36),
>>  	IFF_VLAN_CHALLENGED		= BIT_ULL(37),
>> +	IFF_FCOE_MTU			= BIT_ULL(38),
>>  	IFF_LOGICAL			= IFF_NO_QUEUE | IFF_LLTX,
>>  	IFF_ONE_FOR_ALL			= IFF_HIGHDMA | IFF_VLAN_CHALLENGED,
>>  	IFF_ALL_FOR_ALL			= IFF_XMIT_DST_RELEASE |
> 
> Any reason not to make it a bitfield? I haven't looked at the longer
> patches but this one seems to be used like a basic bool.

This whole enum could be made as bitfields, should we convert it? Would
be a big patch tho ._.

> 
>> diff --git a/net/ethtool/common.c b/net/ethtool/common.c
>> index 2de4dd5a30de..71e36e1a1b15 100644
>> --- a/net/ethtool/common.c
>> +++ b/net/ethtool/common.c
>> @@ -47,7 +47,6 @@ const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN] = {
>>  
>>  	[NETIF_F_FCOE_CRC_BIT] =         "tx-checksum-fcoe-crc",
>>  	[NETIF_F_SCTP_CRC_BIT] =        "tx-checksum-sctp",
>> -	[NETIF_F_FCOE_MTU_BIT] =         "fcoe-mtu",
> 
> 
> But this definitely _is_ a uAPI change, right?

Why?

> Some analysis why this is fine and why avoiding the problem isn't worth
> it in the cover letter would be great.
> 
>>  	[NETIF_F_NTUPLE_BIT] =           "rx-ntuple-filter",
>>  	[NETIF_F_RXHASH_BIT] =           "rx-hashing",
>>  	[NETIF_F_RXCSUM_BIT] =           "rx-checksum",

Thanks,
Olek